You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-22] [Fix CP'd] Expense - System message when paid with bank account is different in LHN and thread #66005
Version Number: 9.1.80-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#65296 Email or phone of affected tester (no customers):applausetester+ds90nu2@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Workspace is set up with bank account.
Admin invites member to the workspace.
Member has a personal bank account.
Go to staging.new.expensify.com
[Member] Submit an expense with amount more than $100 to the workspace chat.
[Member] Click Submit on the expense preview.
[Admin] Open the expense report.
[Admin] Click Approve and Pay by bank account.
[Admin] Right click on paid system message > Reply in thread.
Expected Result:
LHN preview willl show the same message as the expense report - paid with bank account 1111
Paid system message thread header will show the same message as the parent message - paid with bank account 1111
Actual Result:
LHN preview shows "paid amount with bank account 1111", expense report shows "paid with bank account 1111".
Paid system message thread header shows "paid with wallet", when the parent message is "paid with bank account 1111".
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
feat: standardize pay button #65296: Overhauled pay flow, altering PaymentUtils, ReportUtils and ReportActionItemMessage strings for bank-account vs wallet payments, likely causing inconsistent system messages across LHN and thread.
changed the title [-]Expense - System message when paid with bank account is different in LHN and thread[/-][+][Fix CP'd] Expense - System message when paid with bank account is different in LHN and thread[/+]on Jul 14, 2025
changed the title [-][Fix CP'd] Expense - System message when paid with bank account is different in LHN and thread[/-][+][Due for payment 2025-07-22] [Fix CP'd] Expense - System message when paid with bank account is different in LHN and thread[/+]on Jul 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.80-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@AndrewGable / @grgia@JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jul 13, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 13, 2025
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 13, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 13, 2025
💬 A slack conversation has been started in #expensify-open-source
samranahm commentedon Jul 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
System message when paid with bank account is different in LHN and thread
What is the root cause of that problem?
We are using wallet as default return here
App/src/libs/ReportUtils.ts
Lines 5148 to 5154 in 8b943bb
that cause this message to appear in thread report because we are not explicitly checking for VBBA type here
App/src/languages/en.ts
Line 1171 in 8b943bb
What changes do you think we should make in order to solve the problem?
We should explicitly check for VBBA payment type and return the report name for bank account
here
App/src/libs/ReportUtils.ts
Lines 5148 to 5154 in 8b943bb
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
rushatgabhane commentedon Jul 13, 2025
@BlameGPT find the culprits
BlameGPT commentedon Jul 13, 2025
Suspects on the loose 🕵
If not above, check these
4 remaining items
[-]Expense - System message when paid with bank account is different in LHN and thread[/-][+][Fix CP'd] Expense - System message when paid with bank account is different in LHN and thread[/+]luacmartins commentedon Jul 15, 2025
We reverted the #66087. Closing
[-][Fix CP'd] Expense - System message when paid with bank account is different in LHN and thread[/-][+][Due for payment 2025-07-22] [Fix CP'd] Expense - System message when paid with bank account is different in LHN and thread[/+]melvin-bot commentedon Jul 15, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.80-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-22. 🎊
melvin-bot commentedon Jul 15, 2025
@AndrewGable / @grgia @JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]