You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-25] [$125] Report - After downloading expense tapping device back button doesn't trigger action #66027
Version Number: V9.1.80-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6482511 Email or phone of affected tester (no customers): Slottwo1 sm@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: User Settings
Action Performed:
Launch app
Create a manual expense
Go to reports
Select the expense
From dropdown, select download
Tap device back button
Expected Result:
In reports page, after downloading expense tapping device back button must exit user from select mode.
Actual Result:
In reports page, after downloading expense tapping device back button doesn't trigger any action.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
feat: standardize pay button #65296: Large refactor of MoneyReportHeader and related report components could interfere with selection mode state and hardware back behaviour on the report page.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@adelekennedy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
@adelekennedy Could you please help withdraw the Upwork offer?
I’m in the process of setting up ND payment and will submit the request as soon as it’s ready.
Thank you!
Activity
melvin-bot commentedon Jul 14, 2025
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 14, 2025
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 14, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 14, 2025
💬 A slack conversation has been started in #expensify-open-source
rushatgabhane commentedon Jul 14, 2025
@BlameGPT please help us find the cause
BlameGPT commentedon Jul 14, 2025
Vibe check failed for these PRs 💅
If not above, check these
nabi-ebrahimi commentedon Jul 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report - After downloading expense tapping device back button doesn't trigger action
What is the root cause of that problem?
It comes from this commit. We check if the selected reports' length is not more than
0, so we return early.App/src/components/Search/SearchContext.tsx
Line 117 in 15e4323
So it doesn't turn off the selection mode. We only call
clearSelectedTransactionsin the back button handler.App/src/pages/Search/SearchPageNarrow.tsx
Lines 60 to 68 in 15e4323
What changes do you think we should make in order to solve the problem?
We can turn off the selection mode as well, after calling
clearSelectedTransactionson the back button handler like we do here.App/src/pages/Search/SearchPageNarrow.tsx
Lines 190 to 197 in 15e4323
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
We can also include shouldTurnOffSelectionMode in the condition to prevent returning early when it's true.
38 remaining items
melvin-bot commentedon Jul 18, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 18, 2025
@suneox @adelekennedy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
suneox commentedon Jul 26, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/65421/files#r2232789566
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A: It isn't an impactful bug
adelekennedy commentedon Jul 28, 2025
Payment Summary
Contributor: @nabi-ebrahimi paid $125 via Upwork (Pending Offer here)
Contributor+: @suneox due $125 via NewDot
suneox commentedon Jul 29, 2025
@adelekennedy Could you please help withdraw the Upwork offer?
I’m in the process of setting up ND payment and will submit the request as soon as it’s ready.
Thank you!
nabi-ebrahimi commentedon Jul 29, 2025
@adelekennedy Thanks, I accepted the offer.
adelekennedy commentedon Jul 29, 2025
Perfect @nabi-ebrahimi paid out, @suneox I just withdrew the offer and updated the summary above!
suneox commentedon Jul 30, 2025
Thank you. I've requested in ND
isabelastisser commentedon Aug 8, 2025
$125 approved in ND for @suneox
trjExpensify commentedon Aug 13, 2025
$125 approved for @suneox in ND.
(We changed approvers, so this has bounced to me!)