Skip to content

[Due for payment 2025-07-25] Expense - Unable to add unreported expense to expense report #66107

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.81-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): sdiodsjnosnodsi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Chat Report View

Action Performed:

Precondition:

  • Account has self DM.
  1. Go to staging.expensify.com
  2. Go to self DM.
  3. Submit a track expense.
  4. Go to workspace chat.
  5. Create a new report.
  6. Click Add expense > Add unreported expense.
  7. Select the track expense.
  8. Click Add to report.

Expected Result:

User will be able to add unreported expense to expense report.

Actual Result:

User is unable to add unreported expense to expense report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 15, 2025
  2. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Jul 15, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. daledah commented on Jul 15, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User is unable to add unreported expense to expense report.

    What is the root cause of that problem?

    This comes from #65802

    We check for isMoneyRequestReport here

    if (report && isMoneyRequestReport(report)) {

    This condition also returns true if report is WS Chat. And in WS chat, there's no recipient, so we return early here and do nothing

    App/src/libs/actions/IOU.ts

    Lines 5098 to 5101 in 8c0d91a

    if (!payerAccountID) {
    Log.warn('[convertBulkTrackedExpensesToIOU] No payer found', {targetReportID, participantAccountIDs});
    return;
    }

    What changes do you think we should make in order to solve the problem?

    We should only check for IOU report here

    if (report && isMoneyRequestReport(report)) {

    if (report && isIOUReport(report)) {

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. 6 remaining items

  8. rayane-d commented on Jul 15, 2025

    @rayane-d
    Contributor

    PR is up #66130

  9. luacmartins commented on Jul 16, 2025

    @luacmartins
    Contributor

    This is fixed in staging. Regression from #65802, no payments needed. CLosing.

    Screen.Recording.2025-07-16.at.11.30.50.AM.mov
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 18, 2025
  11. changed the title [-]Expense - Unable to add unreported expense to expense report[/-] [+][Due for payment 2025-07-25] Expense - Unable to add unreported expense to expense report[/+] on Jul 18, 2025
  12. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-25. 🎊

    For reference, here are some details about the assignees on this issue:

    • @rayane-d requires payment through NewDot Manual Requests
  14. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    @MariaHCD @stephanieelliott @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions