You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-19] [$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN. #66227
Version Number: 9.1.81-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: 4090253 Email or phone of affected tester (no customers):ibellicotest+1264@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome App Component: Left Hand Navigation (LHN)
Action Performed:
Prerequisite: Account has at least one workspace.
Prerequisite 2: Account has a Self DM.
Open the staging.new.expensify.com website.
Navigate to "Account" and select "Preferences"
Tap on "Language" and select any language except english.
Navigate to a workspace chat.
Create a manual expense.
Open the just created expense.
Tap on the report field and remove the expense from report.
Navigate to "Inbox"
Note that the "Moved this expense to your personal space" message, is not translated on report preview.
Open the expense report.
Note that "Moved this expense to your personal space" message is correctly translated on report.
Expected Result:
When removing an expense from a report, the system message generated, should appear translated on report preview on LHN and also inside the report.
Actual Result:
When changing the language on app to any language different to english, and removing an expense from a report, the system message generated, is correctly translated inside expense report, but it´s not translated on report preview on LHN.
Please re-state the problem that we are trying to solve in this issue.
When changing the language on app to any language different to english, and removing an expense from a report, the system message generated, is correctly translated inside expense report, but it´s not translated on report preview on LHN.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
When changing the language on app to any language different to english, and removing an expense from a report, the system message generated, is correctly translated inside expense report, but it´s not translated on report preview on LHN.
What is the root cause of that problem?
The function getLastMessageTextForReport doesn't handle translation for the actionName: "UNREPORTEDTRANSACTION"
changed the title [-]LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/-][+][$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/+]on Jul 16, 2025
changed the title [-][$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/-][+][Due for payment 2025-08-19] [$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/+]on Aug 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.92-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@akinwale@trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Account is an admin or member of at least one workspace.
Account has a Self DM.
Test:
Launch Expensify.
Navigate to Account and select Preferences.
Tap on Language and select any language except English.
Navigate to a workspace chat.
Create a manual expense.
Open the manual expense that was created.
Tap on the Report field and remove the expense from the report.
Navigate to the self-DM and open the expense report.
Verify that the "Moved this expense to your personal space" message is translated.
Activity
melvin-bot commentedon Jul 16, 2025
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
nkdengineer commentedon Jul 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When changing the language on app to any language different to english, and removing an expense from a report, the system message generated, is correctly translated inside expense report, but it´s not translated on report preview on LHN.
What is the root cause of that problem?
Action name: UNREPORTEDTRANSACTION
App/src/pages/home/report/PureReportActionItem.tsx
Lines 1086 to 1088 in 17e84c8
We do not cover this case in function
getOptionDatainSidebarUitls.tsWhat changes do you think we should make in order to solve the problem?
We should update this case in
getOptionDatafunction like we did with other actionsApp/src/libs/SidebarUtils.ts
Lines 734 to 735 in 17e84c8
Note: we also need to cover this case in getReportNameInternal to update the report name and in contextMenuActions to update when copying the translation
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nyomanjyotisa commentedon Jul 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
LHN - "Moved this expense to your personal space" is translated on report but not on LHN.
What is the root cause of that problem?
Currently we don't have check for
UNREPORTED_TRANSACTIONactions ingetLastMessageTextForReportApp/src/libs/OptionsListUtils.ts
Line 720 in 17e84c8
What changes do you think we should make in order to solve the problem?
Add handling for
UNREPORTED_TRANSACTIONactions ingetLastMessageTextForReporthereWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
ijmalik commentedon Jul 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When changing the language on app to any language different to english, and removing an expense from a report, the system message generated, is correctly translated inside expense report, but it´s not translated on report preview on LHN.
What is the root cause of that problem?
The function getLastMessageTextForReport doesn't handle translation for the actionName: "UNREPORTEDTRANSACTION"
App/src/libs/OptionsListUtils.ts
Lines 717 to 723 in 17e84c8
What changes do you think we should make in order to solve the problem?
Replace
App/src/libs/OptionsListUtils.ts
Lines 838 to 839 in 17e84c8
With
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
trjExpensify commentedon Jul 16, 2025
@roryabraham thoughts on this one? It's a missing translation, but seems maybe because of a functional reason vs an LLM reason.
roryabraham commentedon Jul 16, 2025
yeah, let's fix. Looks to me like @nkdengineer had the first sufficient proposal, so I'll get the ball rolling here
[-]LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/-][+][$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/+]melvin-bot commentedon Jul 16, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021945572382256834621
12 remaining items
luacmartins commentedon Jul 30, 2025
We just merged it again today #67048
[-][$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/-][+][Due for payment 2025-08-19] [$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/+]melvin-bot commentedon Aug 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.92-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 12, 2025
@akinwale @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
akinwale commentedon Aug 18, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎?
trjExpensify commentedon Aug 20, 2025
Not going to add a test for the LHN preview.
Payment summary as follows:
All done, closing. Thanks!
quinthar commentedon Aug 28, 2025
$250 approved for @akinwale