Skip to content

[Due for payment 2025-08-19] [$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN. #66227

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.81-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: 4090253
Email or phone of affected tester (no customers): ibellicotest+1264@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Account has a Self DM.

  1. Open the staging.new.expensify.com website.
  2. Navigate to "Account" and select "Preferences"
  3. Tap on "Language" and select any language except english.
  4. Navigate to a workspace chat.
  5. Create a manual expense.
  6. Open the just created expense.
  7. Tap on the report field and remove the expense from report.
  8. Navigate to "Inbox"
  9. Note that the "Moved this expense to your personal space" message, is not translated on report preview.
  10. Open the expense report.
  11. Note that "Moved this expense to your personal space" message is correctly translated on report.

Expected Result:

When removing an expense from a report, the system message generated, should appear translated on report preview on LHN and also inside the report.

Actual Result:

When changing the language on app to any language different to english, and removing an expense from a report, the system message generated, is correctly translated inside expense report, but it´s not translated on report preview on LHN.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021945572382256834621
  • Upwork Job ID: 1945572382256834621
  • Last Price Increase: 2025-07-16
  • Automatic offers:
    • nkdengineer | Contributor | 108072999
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  3. nkdengineer commented on Jul 16, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When changing the language on app to any language different to english, and removing an expense from a report, the system message generated, is correctly translated inside expense report, but it´s not translated on report preview on LHN.

    What is the root cause of that problem?

    Action name: UNREPORTEDTRANSACTION

    } else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION) {
    children = <ReportActionItemBasicMessage message={translate('iou.unreportedTransaction')} />;
    } else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.MERGED_WITH_CASH_TRANSACTION) {

    We do not cover this case in function getOptionData in SidebarUitls.ts

    What changes do you think we should make in order to solve the problem?

    We should update this case in getOptionData function like we did with other actions

        else if (isActionOfType(lastAction, CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION)) {
                result.alternateText = translateLocal('iou.unreportedTransaction');
            }
    

    } else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_FIELD) {
    result.alternateText = getWorkspaceUpdateFieldMessage(lastAction);

    Note: we also need to cover this case in getReportNameInternal to update the report name and in contextMenuActions to update when copying the translation

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. nyomanjyotisa commented on Jul 16, 2025

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    LHN - "Moved this expense to your personal space" is translated on report but not on LHN.

    What is the root cause of that problem?

    Currently we don't have check for UNREPORTED_TRANSACTION actions in getLastMessageTextForReport

    function getLastMessageTextForReport(report: OnyxEntry<Report>, lastActorDetails: Partial<PersonalDetails> | null, policy?: OnyxEntry<Policy>, isReportArchived = false): string {

    What changes do you think we should make in order to solve the problem?

    Add handling for UNREPORTED_TRANSACTION actions in getLastMessageTextForReport here

        } else if (isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION)) {
            lastMessageTextFromReport = translateLocal('iou.unreportedTransaction');
        }
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  5. ijmalik commented on Jul 16, 2025

    @ijmalik
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When changing the language on app to any language different to english, and removing an expense from a report, the system message generated, is correctly translated inside expense report, but it´s not translated on report preview on LHN.

    What is the root cause of that problem?

    The function getLastMessageTextForReport doesn't handle translation for the actionName: "UNREPORTEDTRANSACTION"

    /**
    * Get the last message text from the report directly or from other sources for special cases.
    */
    function getLastMessageTextForReport(report: OnyxEntry<Report>, lastActorDetails: Partial<PersonalDetails> | null, policy?: OnyxEntry<Policy>, isReportArchived = false): string {
    const reportID = report?.reportID;
    const lastReportAction = reportID ? lastVisibleReportActions[reportID] : undefined;
    const lastVisibleMessage = getLastVisibleMessage(report?.reportID);

    What changes do you think we should make in order to solve the problem?

    Replace

    } else if (lastReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.RESOLVED_DUPLICATES) {
    lastMessageTextFromReport = translateLocal('violations.resolvedDuplicates');

    With

        } else if (lastReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.RESOLVED_DUPLICATES) {
            lastMessageTextFromReport = translateLocal('violations.resolvedDuplicates');
        } else if (lastReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION) {
            lastMessageTextFromReport = translateLocal('iou.unreportedTransaction');
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Image
  6. trjExpensify commented on Jul 16, 2025

    @trjExpensify
    Contributor

    @roryabraham thoughts on this one? It's a missing translation, but seems maybe because of a functional reason vs an LLM reason.

  7. roryabraham commented on Jul 16, 2025

    @roryabraham
    Contributor

    yeah, let's fix. Looks to me like @nkdengineer had the first sufficient proposal, so I'll get the ball rolling here

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 16, 2025
  9. changed the title [-]LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/-] [+][$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/+] on Jul 16, 2025
  10. melvin-bot commented on Jul 16, 2025

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 16, 2025
  12. 12 remaining items

  13. luacmartins commented on Jul 30, 2025

    @luacmartins
    Contributor

    We just merged it again today #67048

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 12, 2025
  15. changed the title [-][$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/-] [+][Due for payment 2025-08-19] [$250] LHN - "Moved this expense to your personal space" is translated on report but not on LHN.[/+] on Aug 12, 2025
  16. melvin-bot commented on Aug 12, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Aug 12, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.92-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-19. 🎊

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Aug 12, 2025

    @melvin-bot

    @akinwale @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  19. akinwale commented on Aug 18, 2025

    @akinwale
    Contributor

    BugZero Checklist:

    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A

    • [@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Account is an admin or member of at least one workspace.
    • Account has a Self DM.

    Test:

    1. Launch Expensify.
    2. Navigate to Account and select Preferences.
    3. Tap on Language and select any language except English.
    4. Navigate to a workspace chat.
    5. Create a manual expense.
    6. Open the manual expense that was created.
    7. Tap on the Report field and remove the expense from the report.
    8. Navigate to the self-DM and open the expense report.
    9. Verify that the "Moved this expense to your personal space" message is translated.

    Do we agree 👍 or 👎?

  20. trjExpensify commented on Aug 20, 2025

    @trjExpensify
    Contributor

    Not going to add a test for the LHN preview.

    Payment summary as follows:

    All done, closing. Thanks!

  21. quinthar commented on Aug 28, 2025

    @quinthar
    Contributor

    $250 approved for @akinwale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions