Skip to content

[HOLD for payment 2025-08-21] [$250] Help panel on IOS disappears and freezes the app when opened from a modal #66247

Closed

Description

@blazejkustra

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: N/A
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: @blazejkustra
Slack conversation (hyperlinked to channel name): N/A

Action Performed:

Prerequisites:

  • Run the following command in the web console using the same account:
Onyx.set('nvp_sidePanel', {})
  • Click the Help button, then close the help panel.

Open the app on iOS to reproduce:

  • Open reports page
  • Click on Date filter at the top of the screen
  • Open any input with a calendar
  • Click on the '2025' in order to open year picker modal
  • Open help modal
  • Dismiss all visible modals

Expected Result:

The user should be able to continue interacting with the app.

Actual Result:

The app becomes unresponsive, and the user is unable to click or interact with anything.

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-07-14.at.10.21.35.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. blazejkustra commented on Jul 16, 2025

    @blazejkustra
    ContributorAuthor

    Hi! I’m Błażej Kustra from Software Mansion, an expert agency. I’m familiar with both the modals and the help panel, and I’d be happy to take this on.

  4. ZhenjaHorbach commented on Jul 17, 2025

    @ZhenjaHorbach
    Contributor

    Looks like this is a common issue
    I found the same issue here
    #65544 (comment)
    And here
    #65409 (comment)

  5. ZhenjaHorbach commented on Jul 21, 2025

    @ZhenjaHorbach
    Contributor

    Here are 2 more places

    PushRowModal:

    1. Go to /enable-payments
    2. Open state

    NetSuiteCustomListSelectorModal:

    1. Go to Workspaces > Select a workspace with Netsuite integration
    2. Accounting
    3. Go to /netsuite/import/
    4. Custom lists
    5. Add custom list
    6. Open name
  6. trjExpensify commented on Jul 21, 2025

    @trjExpensify
    Contributor

    Thanks @blazejkustra, are you working on a PR for this now? Thanks!

  7. blazejkustra commented on Jul 21, 2025

    @blazejkustra
    ContributorAuthor

    Ah yes, I was looking into it but got distracted by another issue. I'll come back to this and leave an update tomorrow morning 👍

  8. moved this to Bugs and Follow Up Issues in #expensify-bugson Jul 21, 2025
  9. ZhenjaHorbach commented on Jul 21, 2025

    @ZhenjaHorbach
    Contributor

    By the way, I can be a reviewer here
    Since I am already reviewing a project related to improving modals
    And I constantly encounter this issue

  10. 15 remaining items

  11. changed the title [-]Help panel on IOS disappears and freezes the app when opened from a modal[/-] [+][HOLD for payment 2025-08-21] [$250] Help panel on IOS disappears and freezes the app when opened from a modal[/+] on Aug 21, 2025
  12. melvin-bot commented on Aug 21, 2025

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  13. melvin-bot commented on Aug 21, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@trjExpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. trjExpensify commented on Aug 22, 2025

    @trjExpensify
    Contributor

    Checklist time please, @ZhenjaHorbach.

  15. ZhenjaHorbach commented on Aug 22, 2025

    @ZhenjaHorbach
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      The issue is related to React-Native library and to fix it we used a workaround

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Precondition:

    • Make sure the account has access to the help panel

    Test:

    1. Open App
    2. Open reports page
    3. Click on Date filter at the top of the screen
    4. Open any input with a calendar
    5. Click on the '2025' in order to open year picker modal
    6. Open help modal
    7. Dismiss all visible modals
    8. Verify that the user should be able to continue interacting with the app.

    Do we agree 👍 or 👎

  16. melvin-bot commented on Aug 25, 2025

    @melvin-bot

    @trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. trjExpensify commented on Aug 26, 2025

    @trjExpensify
    Contributor

    The help panel is hidden behind a NVP beta for the foreseeable future, so I'm not going to add a test for this.

    Payment summary as follows:

    Go ahead and request!

  18. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Aug 26, 2025
  19. ZhenjaHorbach commented on Aug 26, 2025

    @ZhenjaHorbach
    Contributor

    Requested in ND !

  20. quinthar commented on Aug 28, 2025

    @quinthar
    Contributor

    $250 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions