Skip to content

[Due for payment 2025-11-03] Remove Onyx.connect() for the key: ONYXKEYS.COUNTRY_CODE in src/libs/LoginUtils.ts #66333

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @isabelastisser
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @isabelastisser this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. pasyukevich commented on Jul 31, 2025

    @pasyukevich
    Contributor

    Hi, I am Eugene from Callstack, an expert agency and I can work on this issue.

  8. pasyukevich commented on Jul 31, 2025

    @pasyukevich
    Contributor

    @tgolen Could you assign me and @DylanDylann as a C+ reviewer?(according to doc)

  9. 139 remaining items

  10. changed the title [-][Due for payment 2025-10-31] [Due for payment 2025-10-28] [Due for payment 2025-10-27] [Due for payment 2025-10-15] [Due for payment 2025-10-09] [Due for payment 2025-10-01] [Due for payment 2025-09-23] [Due for payment 2025-09-16] [Due for payment 2025-08-19] Remove `Onyx.connect()` for the key: `ONYXKEYS.COUNTRY_CODE` in `src/libs/LoginUtils.ts`[/-] [+][Due for payment 2025-11-03] [Due for payment 2025-10-31] [Due for payment 2025-10-28] [Due for payment 2025-10-27] [Due for payment 2025-10-15] [Due for payment 2025-10-09] [Due for payment 2025-10-01] [Due for payment 2025-09-23] [Due for payment 2025-09-16] [Due for payment 2025-08-19] Remove `Onyx.connect()` for the key: `ONYXKEYS.COUNTRY_CODE` in `src/libs/LoginUtils.ts`[/+] on Oct 27, 2025
  11. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.38-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-03. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    @DylanDylann @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. DylanDylann commented on Oct 30, 2025

    @DylanDylann
    Contributor

    @isabelastisser @mountiny I’d like to propose adjusting the bounty for this task, since it ended up being far more time-consuming than initially expected. We’ve merged 12 PRs to address everything, so I think $2,000 would be a fair compensation for the overall effort.

  14. changed the title [-][Due for payment 2025-11-03] [Due for payment 2025-10-31] [Due for payment 2025-10-28] [Due for payment 2025-10-27] [Due for payment 2025-10-15] [Due for payment 2025-10-09] [Due for payment 2025-10-01] [Due for payment 2025-09-23] [Due for payment 2025-09-16] [Due for payment 2025-08-19] Remove `Onyx.connect()` for the key: `ONYXKEYS.COUNTRY_CODE` in `src/libs/LoginUtils.ts`[/-] [+][Due for payment 2025-11-03] Remove `Onyx.connect()` for the key: `ONYXKEYS.COUNTRY_CODE` in `src/libs/LoginUtils.ts`[/+] on Oct 30, 2025
  15. mountiny commented on Oct 30, 2025

    @mountiny
    Contributor

    Discussing in the project room

  16. mountiny commented on Oct 30, 2025

    @mountiny
    Contributor

    @DylanDylann I propose $1750, base should be 12 * $125 = $1500 and it does not look like that many of these prs were very tricky so I think considering 2 would be worth $250 then we get $1750

  17. DylanDylann commented on Oct 30, 2025

    @DylanDylann
    Contributor

    It looks fine to me

  18. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @NicMendonca you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  19. isabelastisser commented on Nov 10, 2025

    @isabelastisser
    Contributor

    Payment summary:

    @pasyukevich does not require payment (Contractor)
    @DylanDylann requires payment through NewDot Manual Requests $1750 for C+ review. Amount context here.

  20. trjExpensify commented on Dec 3, 2025

    @trjExpensify
    Contributor

    approved $1,750 for @DylanDylann.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions