Skip to content

[Due for payment 2025-09-19] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/NetworkConnection.ts #66363

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. allgandalf commented on Aug 12, 2025

    @allgandalf
    Contributor

    @tgolen can you please assign me and @DylanDylann here, thanks !

  8. 18 remaining items

  9. adelekennedy commented on Sep 12, 2025

    @adelekennedy
    Contributor

    I will be ooo when payment is due, reassigning to you @mallenexpensify! And noting @allgandalf comment above on the pay summary

  10. melvin-bot commented on Sep 19, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @allgandalf is from an agency-contributor and not due payment
    • Reviewer: @DylanDylann owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. mallenexpensify commented on Sep 20, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @allgandalf paid $250 via Upwork
    Contributor+: @DylanDylann due $250 via NewDot

    @allgandalf can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021969203037433362638

  12. allgandalf commented on Sep 22, 2025

    @allgandalf
    Contributor

    I accepted the offer @mallenexpensify

  13. mallenexpensify commented on Sep 22, 2025

    @mallenexpensify
    Contributor

    @allgandalf paid! Summary updated above. thx

  14. trjExpensify commented on Nov 13, 2025

    @trjExpensify
    Contributor

    approved $250 for @DylanDylann.

  15. garrettmknight commented on Nov 21, 2025

    @garrettmknight
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions