Skip to content

[Partial Payment] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_ACTIONS in src/libs/OptionsListUtils.ts #66381

Open

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @jliexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. danieldoglas commented on Aug 18, 2025

    @danieldoglas
    Contributor

    Not overdue, will be worked soon.

  7. 221 remaining items

  8. tgolen commented on Nov 11, 2026

    @tgolen
    ContributorAuthor

    PR Payout Summary

    PR Adjusted Lines Files Commits PR Comments Notes Suggested Price
    #85783 1,072 14 27 18 New SORTED_REPORT_ACTIONS derived value plus refactor. About 860 lines are new tests. Design discussion and changes requested before approval. $500
    #86409 355 14 24 24 Passes sortedActions through call sites and adds a hook. Most of the lines are test churn. Three approvers, including a perf-focused review. $250
    #86643 108 3 36 23 getLastMessageTextForReport / getAlternateText migration. Small diff, but long review (eslint/TS fixes, several rounds). $250
    #92308 57 7 3 12 Mechanical createOptionFromReport signature plumbing with tests updated. Light review, two approvals. $125
    #92330 722 7 45 47 getReportOption moved to a params object and sortedActions wired through. About 620 of the lines are test refactors. Changes requested, about 3.5 months in review. $250

    Total: $1,375

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Nov 11, 2026
  10. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_ACTIONS` in `src/libs/OptionsListUtils.ts`[/-] [+][Due for payment 2026-11-11] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_ACTIONS` in `src/libs/OptionsListUtils.ts`[/+] on Nov 11, 2026
  11. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  12. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @tgolen, @mallenexpensify, @grgia, @DylanDylann, @truph01 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  13. mallenexpensify commented on Nov 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @truph01 due $1,375 via NewDot
    Contributor+: @DylanDylann due $1,375 via NewDot

    Partial Payment

  14. changed the title [-][Due for payment 2026-11-11] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_ACTIONS` in `src/libs/OptionsListUtils.ts`[/-] [+][Partial Payment] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_ACTIONS` in `src/libs/OptionsListUtils.ts`[/+] on Nov 16, 2026
  15. removed their assignment
    on Nov 16, 2026
  16. melvin-bot commented on Nov 18, 2026

    @melvin-bot

    @DylanDylann / @truph01

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.40-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  17. melvin-bot commented on Nov 18, 2026

    @melvin-bot

    @DylanDylann / @truph01

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.41-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions