Skip to content

[Partial Payment] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT in src/libs/ReportUtils.ts #66416

Open

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/ReportUtils.ts
  • Onyx Key: ONYXKEYS.COLLECTION.REPORT
  • Reference: Line 946: ONYXKEYS.COLLECTION.REPORT

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. zanyrenney commented on Aug 18, 2025

    @zanyrenney
    Contributor

    Not overdue, this will be worked on when a contributor is assigned according to the correct priority.

  8. 203 remaining items

  9. added
    ReviewingHas a PR in review
    and removed
    ReviewingHas a PR in review
    on Nov 10, 2026
  10. tgolen commented on Nov 11, 2026

    @tgolen
    ContributorAuthor

    PR Payout Summary

    PR Adjusted Lines Files Commits Reviews Notes Suggested Price
    #86953 389 9 11 10 New derived key plus deprecated renames. About 146 lines are mechanical renames, 156 are unit tests, and review was light. $250
    #87339 174 11 12 8 Logic change to the move-IOU-to-policy flow, with tests. $250
    #87714 228 24 46 31 Largest by files. Many call-site refactors plus a new hook, with a lot of review back-and-forth. Over 200 lines but nowhere near the $500 scale. $250
    #90174 135 8 32 20 Signature changes through the report-name path, with tests and several review rounds. $250
    #93267 171 9 27 26 Passes the concierge, admins and self-DM reports through the onboarding flow, with tests and heavy review. $250
    #93423 128 11 53 27 New policyExpenseChatSelector used across 6 hooks and components, with tests. Open about 5 months with many commits. $250
    #94564 137 7 15 4 getReportForHeader now takes the parent report, updated in 5 callers, with tests. $250
    #94628 146 7 26 20 isInvoiceReport and isCategoryBeingAnalyzed now take report objects, with tests. $250

    Total: $2,000

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Nov 11, 2026
  12. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT` in `src/libs/ReportUtils.ts`[/-] [+][Due for payment 2026-11-11] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT` in `src/libs/ReportUtils.ts`[/+] on Nov 11, 2026
  13. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. mallenexpensify commented on Nov 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @truph01 due $2000 via NewDot
    Contributor+: @DylanDylann due $2000 via NewDot

    Partial Payment

  15. changed the title [-][Due for payment 2026-11-11] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT` in `src/libs/ReportUtils.ts`[/-] [+][Partial Payment] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT` in `src/libs/ReportUtils.ts`[/+] on Nov 16, 2026
  16. removed their assignment
    on Nov 16, 2026
  17. garrettmknight commented on Nov 18, 2026

    @garrettmknight
    Contributor

    $2000 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions