Skip to content

[Due for payment 2026-01-21] Remove Onyx.connect() for the key: ONYXKEYS.ONBOARDING_COMPANY_SIZE in src/libs/ReportUtils.ts #66429

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/ReportUtils.ts
  • Onyx Key: ONYXKEYS.ONBOARDING_COMPANY_SIZE
  • Reference: Line 1112: ONYXKEYS.ONBOARDING_COMPANY_SIZE

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @sakluger this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. sakluger commented on Aug 18, 2025

    @sakluger
    Contributor

    No updates

  8. 20 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 14, 2026
  10. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.ONBOARDING_COMPANY_SIZE` in `src/libs/ReportUtils.ts`[/-] [+][Due for payment 2026-01-21] Remove `Onyx.connect()` for the key: `ONYXKEYS.ONBOARDING_COMPANY_SIZE` in `src/libs/ReportUtils.ts`[/+] on Jan 14, 2026
  11. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.1-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-21. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hungvu193 requires payment through NewDot Manual Requests
    • @DylanDylann requires payment through NewDot Manual Requests
  13. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    @hungvu193 / @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. sakluger commented on Jan 22, 2026

    @sakluger
    Contributor

    Payment Summary

    Contributor: @hungvu193 due $250 via NewDot
    Contributor+: @DylanDylann due $250 via Newdot

  15. twisterdotcom commented on Jan 23, 2026

    @twisterdotcom
    Contributor

    @hungvu193 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-1a9d-a0cc-edba-8a4ad9c05d94
  16. sakluger commented on Jan 23, 2026

    @sakluger
    Contributor

    @DylanDylann I removed the hold for the BZ checklist because this is part of the refactor project, which doesn't require those checklists. Sorry about that - Feel free to request payment now!

  17. JmillsExpensify commented on Jan 28, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions