Skip to content

[Due for payment 2025-09-16] [$125] Remove Onyx.connect() for the key: ONYXKEYS.IS_SIDEBAR_LOADED in src/libs/actions/App.ts #66480

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/actions/App.ts
  • Onyx Key: ONYXKEYS.IS_SIDEBAR_LOADED
  • Reference: Line 53: ONYXKEYS.IS_SIDEBAR_LOADED

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @sonialiap this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. danieldoglas commented on Aug 18, 2025

    @danieldoglas
    Contributor

    Not overdue, will be worked soon.

  7. 11 remaining items

  8. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.IS_SIDEBAR_LOADED` in `src/libs/actions/App.ts`[/-] [+][Due for payment 2025-09-16] Remove `Onyx.connect()` for the key: `ONYXKEYS.IS_SIDEBAR_LOADED` in `src/libs/actions/App.ts`[/+] on Sep 9, 2025
  9. melvin-bot commented on Sep 9, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Sep 9, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.2-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-16. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Sep 9, 2025

    @melvin-bot

    @ikevin127 @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. changed the title [-][Due for payment 2025-09-16] Remove `Onyx.connect()` for the key: `ONYXKEYS.IS_SIDEBAR_LOADED` in `src/libs/actions/App.ts`[/-] [+][Due for payment 2025-09-16] [$125] Remove `Onyx.connect()` for the key: `ONYXKEYS.IS_SIDEBAR_LOADED` in `src/libs/actions/App.ts`[/+] on Sep 9, 2025
  13. melvin-bot commented on Sep 9, 2025

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  14. ikevin127 commented on Sep 12, 2025

    @ikevin127
    Contributor

    🟢 No need for BZ Checklist as this issue is part of a refactoring effort (see above BZ Instructions).
    ⌛ Awaiting payment summary confirmation for ND request.

  15. sonialiap commented on Sep 16, 2025

    @sonialiap
    Contributor

    Payment summary:
    @ikevin127 $125 please request in NewDot

  16. twisterdotcom commented on Sep 16, 2025

    @twisterdotcom
    Contributor

    @ikevin127 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-aefb-af97-a8cb-2fb66d98e661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions