Skip to content

[Due for payment 2025-11-13] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY_CATEGORIES in src/libs/actions/IOU.ts #66515

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/actions/IOU.ts
  • Onyx Key: ONYXKEYS.COLLECTION.POLICY_CATEGORIES
  • Reference: Line 733: ONYXKEYS.COLLECTION.POLICY_CATEGORIES

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. danieldoglas commented on Aug 18, 2025

    @danieldoglas
    Contributor

    Not overdue, will be worked soon.

  7. 28 remaining items

  8. ikevin127 commented on Nov 14, 2025

    @ikevin127
    Contributor

    This one can be closed as we're handling payment on the regression issue.

  9. parasharrajat commented on Nov 14, 2025

    @parasharrajat
    Member

    @ikevin127 let's keep the payment here. We can close the other issue.

  10. parasharrajat commented on Nov 14, 2025

    @parasharrajat
    Member

    I missed passing the new param values to one function during the refactor, which caused this #74433. Then fixed in the next PR #74841

    Should there be a pay deduction for this @tgolen?

    Note: There have been some complicated issues for this project where a standard payment was issued. So having one small regression on this one shouldn't warrant a deduction.

  11. tgolen commented on Nov 14, 2025

    @tgolen
    ContributorAuthor

    I think so, yeah. Thanks for calling that out.

  12. parasharrajat commented on Nov 14, 2025

    @parasharrajat
    Member

    @tgolen do you mean to say to deduct or not?

  13. lschurr commented on Nov 14, 2025

    @lschurr
    Contributor

    @danieldoglas @tgolen - can you confirm the payment amount for this one?

  14. tgolen commented on Nov 14, 2025

    @tgolen
    ContributorAuthor

    Yes, there should be a 50% reduction because of the regression. This one should be $125 I believe.

  15. ikevin127 commented on Nov 14, 2025

    @ikevin127
    Contributor

    This one can be closed as we're handling payment on the #74433.

    I already posted a breakdown on the regression issue where we have the correct payment due date ✅

  16. lschurr commented on Nov 17, 2025

    @lschurr
    Contributor

    Alright, so it sounds like we can close this one and handle payment on the other issue right @ikevin127?

  17. ikevin127 commented on Nov 17, 2025

    @ikevin127
    Contributor

    @lschurr Yes, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions