Skip to content

[Due for payment 2025-12-17] Remove Onyx.connect() for the key: ONYXKEYS.NVP_INTRO_SELECTED in src/libs/actions/Policy/Policy.ts #66585

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @lschurr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. lschurr commented on Aug 18, 2025

    @lschurr
    Contributor

    Still ongoing @tgolen?

  8. 21 remaining items

  9. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @RachCHopkins you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  10. RachCHopkins commented on Dec 18, 2025

    @RachCHopkins
    Contributor

    Per above:

    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  11. RachCHopkins commented on Dec 18, 2025

    @RachCHopkins
    Contributor

    Payment Summary:

    • Contributor: @DylanDylann to be paid $250 via NewDot Manual Request
    • Contributor+: @parasharrajat to be paid $250 via NewDot Manual Request

    No upwork job.

    🟢 to request payment via NewDot.

  12. RachCHopkins commented on Dec 18, 2025

    @RachCHopkins
    Contributor

    No upwork job to close or contracts to pay.

  13. parasharrajat commented on Dec 18, 2025

    @parasharrajat
    Member

    @RachCHopkins This one is not yet completed. There will be more PRs.

  14. DylanDylann commented on Jan 9, 2026

    @DylanDylann
    Contributor

    The work already been done. Ready to pay

  15. JmillsExpensify commented on Jan 20, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

  16. parasharrajat commented on Feb 7, 2026

    @parasharrajat
    Member

    Payment requested as per #66585 (comment)

  17. twisterdotcom commented on Feb 7, 2026

    @twisterdotcom
    Contributor

    @parasharrajat has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-6403-aa31-bfbc-7c0e34c9b014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions