You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Reporting bonus paid] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya #6714
Run web or desktop version
View already uploaded landscape image from chat list.
OR upload any landscape image (i.e. Choose image whose width larger than height)
Attachment view shows image as left aligned (if landscape image) it should be horizontally centre.
Expected Result:
Attachment view should be centered, same as vertical or square image
Actual Result:
Attachment view shows image as left aligned. This issue happen with landscape image only (i.e. width larger than height). For vertical or square image it shows as expected i.e. image shows horizontally centred.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.22-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Oh yep we'll pay for reporting, that's without a doubt, but I'm more wondering about the timing. Typically we'd pay out reporters together with the payment of contributors fixing the issue. But in this case it's a regression so there's no payment of the latter. So I don't think there's a reason to wait with this particular payment until the regression fix is deployed, the reporting payment shouldn't hinge on the fixing of the regression.
But how would you make sure that regression is fixed so we wait for 7 days after PROD deploy.
I know we tested it before merge and QA passed it but it doesn't hurt to wait for last 7 days regression test.
It is good to pass all three checks.
Test before merge.
QA passed.
7 days hold. This is important to capture any unwanted side-effects.
But the above process is applicable when we pay a contributor fixing a bug or regression, we wait for it to pass all tests before paying out.
But in this specific case, we're paying for the reporting of the bug, not the fixing. And the reporting of the bug should be compensated regardless of the outcome of the regression.. right?
Hmm. I don't have a strong argument to hold the payment. Either way is fine. As per my understanding reporting bonus is released when issue is resolved and we consider a issue to be completed when it pass all of above mentioned three stages. And if issue is resolved internally then we can pay them without hold but this issue is resolved externally. I think you can release the payment, this going to be eventually closed.
changed the title [-][HOLD for payment 2021-12-28] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/-][+][Reporting bonus payment only] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/+]on Dec 22, 2021
changed the title [-][Reporting bonus payment only] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/-][+][Reporting bonus paid] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/+]on Dec 22, 2021
Activity
MelvinBot commentedon Dec 11, 2021
Triggered auto assignment to @CortneyOfstad (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Dec 11, 2021
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.PrashantMangukiya commentedon Dec 11, 2021
@mvtglobally thanks, please correct my Github user name as @PrashantMangukiya for reported by. (remove space between first and last name)
AndrewGable commentedon Dec 13, 2021
I've had this happen to me, agree it's a bug and looks like it's an external one too.
MelvinBot commentedon Dec 13, 2021
Triggered auto assignment to @SofiedeVreese (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.29 remaining items
botify commentedon Dec 21, 2021
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.22-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2021-12-28. 🎊
SofiedeVreese commentedon Dec 22, 2021
This was a regression so no payment needed, apart from the contributor who kindly reported the regression (@PrashantMangukiya ).
SofiedeVreese commentedon Dec 22, 2021
Actually, considering this was a regression, I don't think we have to wait to pay Prashant for reporting the regression. Do you agree @parasharrajat ?
parasharrajat commentedon Dec 22, 2021
I don't have much knowledge of this topic but I think all reports are paid.
SofiedeVreese commentedon Dec 22, 2021
Oh yep we'll pay for reporting, that's without a doubt, but I'm more wondering about the timing. Typically we'd pay out reporters together with the payment of contributors fixing the issue. But in this case it's a regression so there's no payment of the latter. So I don't think there's a reason to wait with this particular payment until the regression fix is deployed, the reporting payment shouldn't hinge on the fixing of the regression.
parasharrajat commentedon Dec 22, 2021
But how would you make sure that regression is fixed so we wait for 7 days after PROD deploy.
I know we tested it before merge and QA passed it but it doesn't hurt to wait for last 7 days regression test.
It is good to pass all three checks.
But last is least important and is at your discretion.
SofiedeVreese commentedon Dec 22, 2021
But the above process is applicable when we pay a contributor fixing a bug or regression, we wait for it to pass all tests before paying out.
But in this specific case, we're paying for the reporting of the bug, not the fixing. And the reporting of the bug should be compensated regardless of the outcome of the regression.. right?
parasharrajat commentedon Dec 22, 2021
Hmm. I don't have a strong argument to hold the payment. Either way is fine. As per my understanding reporting bonus is released when issue is resolved and we consider a issue to be completed when it pass all of above mentioned three stages. And if issue is resolved internally then we can pay them without hold but this issue is resolved externally. I think you can release the payment, this going to be eventually closed.
[-][HOLD for payment 2021-12-28] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/-][+][Reporting bonus payment only] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/+]SofiedeVreese commentedon Dec 22, 2021
Created an Upwork post to pay out the reporting bonus and invited @PrashantMangukiya to this Upwork post.
Once that's done, we can just let this GH auto-close via the regression fix' PR.
[-][Reporting bonus payment only] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/-][+][Reporting bonus paid] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/+]PrashantMangukiya commentedon Dec 22, 2021
@SofiedeVreese accepted Upwork invitation. Thank you.
SofiedeVreese commentedon Dec 22, 2021
Perfect thank you @PrashantMangukiya I've just completed the payment for the reporting bonus. Thanks again!
iwiznia commentedon Dec 23, 2021
I think this has been deployed already, closing out