Skip to content

[Reporting bonus paid] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya #6714

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Run web or desktop version
View already uploaded landscape image from chat list.
OR upload any landscape image (i.e. Choose image whose width larger than height)
Attachment view shows image as left aligned (if landscape image) it should be horizontally centre.

Expected Result:

Attachment view should be centered, same as vertical or square image

Actual Result:

Attachment view shows image as left aligned. This issue happen with landscape image only (i.e. width larger than height). For vertical or square image it shows as expected i.e. image shows horizontally centred.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.1.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

AttachmentViiew_ImagePreview.mp4

Expensify/Expensify Issue URL:
Issue reported by: @PrashantMangukiya
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639119563497100

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Dec 11, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. MelvinBot commented on Dec 11, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Dec 11, 2021
  4. PrashantMangukiya commented on Dec 11, 2021

    @PrashantMangukiya
    Contributor

    @mvtglobally thanks, please correct my Github user name as @PrashantMangukiya for reported by. (remove space between first and last name)

  5. AndrewGable commented on Dec 13, 2021

    @AndrewGable
    Contributor

    I've had this happen to me, agree it's a bug and looks like it's an external one too.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 13, 2021
  7. MelvinBot commented on Dec 13, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  8. 29 remaining items

  9. botify commented on Dec 21, 2021

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.22-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2021-12-28. 🎊

  10. SofiedeVreese commented on Dec 22, 2021

    @SofiedeVreese
    Contributor

    This was a regression so no payment needed, apart from the contributor who kindly reported the regression (@PrashantMangukiya ).

  11. SofiedeVreese commented on Dec 22, 2021

    @SofiedeVreese
    Contributor

    Actually, considering this was a regression, I don't think we have to wait to pay Prashant for reporting the regression. Do you agree @parasharrajat ?

  12. parasharrajat commented on Dec 22, 2021

    @parasharrajat
    Member

    I don't have much knowledge of this topic but I think all reports are paid.

  13. SofiedeVreese commented on Dec 22, 2021

    @SofiedeVreese
    Contributor

    Oh yep we'll pay for reporting, that's without a doubt, but I'm more wondering about the timing. Typically we'd pay out reporters together with the payment of contributors fixing the issue. But in this case it's a regression so there's no payment of the latter. So I don't think there's a reason to wait with this particular payment until the regression fix is deployed, the reporting payment shouldn't hinge on the fixing of the regression.

  14. parasharrajat commented on Dec 22, 2021

    @parasharrajat
    Member

    But how would you make sure that regression is fixed so we wait for 7 days after PROD deploy.

    I know we tested it before merge and QA passed it but it doesn't hurt to wait for last 7 days regression test.

    It is good to pass all three checks.

    1. Test before merge.
    2. QA passed.
    3. 7 days hold. This is important to capture any unwanted side-effects.

    But last is least important and is at your discretion.

  15. SofiedeVreese commented on Dec 22, 2021

    @SofiedeVreese
    Contributor

    But how would you make sure that regression is fixed so we wait for 7 days after PROD deploy.

    I know we tested it before merge and QA passed it but it doesn't hurt to wait for last 7 days regression test.

    It is good to pass all three checks.

    Test before merge.
    QA passed.
    7 days hold. This is important to capture any unwanted side-effects.

    But the above process is applicable when we pay a contributor fixing a bug or regression, we wait for it to pass all tests before paying out.

    But in this specific case, we're paying for the reporting of the bug, not the fixing. And the reporting of the bug should be compensated regardless of the outcome of the regression.. right?

  16. parasharrajat commented on Dec 22, 2021

    @parasharrajat
    Member

    Hmm. I don't have a strong argument to hold the payment. Either way is fine. As per my understanding reporting bonus is released when issue is resolved and we consider a issue to be completed when it pass all of above mentioned three stages. And if issue is resolved internally then we can pay them without hold but this issue is resolved externally. I think you can release the payment, this going to be eventually closed.

  17. changed the title [-][HOLD for payment 2021-12-28] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/-] [+][Reporting bonus payment only] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/+] on Dec 22, 2021
  18. SofiedeVreese commented on Dec 22, 2021

    @SofiedeVreese
    Contributor

    Created an Upwork post to pay out the reporting bonus and invited @PrashantMangukiya to this Upwork post.

    Once that's done, we can just let this GH auto-close via the regression fix' PR.

  19. changed the title [-][Reporting bonus payment only] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/-] [+][Reporting bonus paid] Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya[/+] on Dec 22, 2021
  20. PrashantMangukiya commented on Dec 22, 2021

    @PrashantMangukiya
    Contributor

    @SofiedeVreese accepted Upwork invitation. Thank you.

  21. SofiedeVreese commented on Dec 22, 2021

    @SofiedeVreese
    Contributor

    Perfect thank you @PrashantMangukiya I've just completed the payment for the reporting bonus. Thanks again!

  22. iwiznia commented on Dec 23, 2021

    @iwiznia
    Contributor

    I think this has been deployed already, closing out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions