Skip to content

[Due for payment 2025-12-05] Fix free trial message display order #67494

Closed

Description

@carlosmiceli

See the video below, the Free Trial message appears briefly below the task list, and then moves to the top where it should be. Let's fix that flashing bug

Screen.Recording.2025-07-28.at.11.43.35.PM.mov
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021968469432619817709
  • Upwork Job ID: 1968469432619817709
  • Last Price Increase: 2025-09-18
Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. self-assigned this
    on Jul 31, 2025
  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 31, 2025
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 31, 2025
  4. melvin-bot commented on Jul 31, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  5. melvin-bot commented on Jul 31, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. nkdengineer commented on Jul 31, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    the Free Trial message appears briefly below the task list, and then moves to the top where it should be.

    What is the root cause of that problem?

    After we complete the onboarding, GetMissingOnyxMessages is called, and the free trial message is returned from the backend. At this time, the current created of the onboarding task isn't updated due to some APIs are still calling. Then the free trial message is displayed as the last message.

    What changes do you think we should make in order to solve the problem?

    In the same way we create the welcome sign-off message, we can also create the free trial message if we create the task in the admin room

    const welcomeSignOffText =

    1. This action should be created first before the text message to correct the order.

    1. We need to push this message data to the guidedSetupData like the same here

    guidedSetupData.push({type: 'message', ...welcomeSignOffMessage});

    1. Maybe we need the backend change to support creating the free trial message with the data we passed to guidedSetupData

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    Update prepareOnboardingOnyxData unit test to verify that the free trial message is created if the user is not the test user.

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. nabi-ebrahimi commented on Aug 4, 2025

    @nabi-ebrahimi

    This is not reproducible on my end.

    Screen.Recording.1404-05-13.at.7.33.08.PM.mp4
  8. carlosmiceli commented on Aug 4, 2025

    @carlosmiceli
    ContributorAuthor

    @nabi-ebrahimi you should test in production.

  9. melvin-bot commented on Aug 5, 2025

    @melvin-bot

    @akinwale Eep! 4 days overdue now. Issues have feelings too...

  10. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    @akinwale 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  11. 131 remaining items

  12. changed the title [-]Fix free trial message display order[/-] [+][Due for payment 2025-12-05] Fix free trial message display order[/+] on Nov 28, 2025
  13. melvin-bot commented on Nov 28, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Nov 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-05. 🎊

    For reference, here are some details about the assignees on this issue:

    • @akinwale requires payment through NewDot Manual Requests
    • @jnowakow does not require payment (Contractor)
    • @nkdengineer requires payment through NewDot Manual Requests
  15. melvin-bot commented on Nov 28, 2025

    @melvin-bot

    @akinwale @johncschuster The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. mountiny commented on Nov 30, 2025

    @mountiny
    Contributor

    $250 to @akinwale

  17. johncschuster commented on Dec 1, 2025

    @johncschuster
    Contributor

    Looks like this one has already been paid out (here). Let's wait for the regression window to pass and then close this up.

  18. akinwale commented on Dec 1, 2025

    @akinwale
    Contributor

    Looks like this one has already been paid out (here). Let's wait for the regression window to pass and then close this up.

    @johncschuster The previous PR was reverted after the original regression period due to performance issues detected by Sentry. The new PR is a different solution for the same issue.

  19. akinwale commented on Dec 3, 2025

    @akinwale
    Contributor

    BugZero Checklist:

    • [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A

    • [@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Launch Expensify.
    2. Sign in with a new email account (without +).
    3. Select Manage my team's expenses.
    4. Finish onboarding.
    5. Verify that the welcome message and tasks are created and displayed in the correct order in the #admins chat report of the workspace.
    6. Sign in with a new email (without +).
    7. Select Something else.
    8. Finish onboarding.
    9. Go to the workspace tab.
    10. Create a new workspace.
    11. Navigate to the #admins chat report of the workspace.
    12. Verify that the welcome message and tasks are created and displayed in the correct order.
    13. Sign in with a new email (without +).
    14. Select Track and budget expenses.
    15. Create a workspace.
    16. Finish onboarding.
    17. Verify that the welcome message and tasks are created and displayed in the correct order in the #admins chat report of the workspace.

    Do we agree 👍 or 👎?

  20. johncschuster commented on Dec 5, 2025

    @johncschuster
    Contributor

    Payment Summary

    Contributor+: @akinwale due $250 via NewDot

  21. JmillsExpensify commented on Dec 11, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @akinwale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions