You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-05] Fix free trial message display order #67494
See the video below, the Free Trial message appears briefly below the task list, and then moves to the top where it should be. Let's fix that flashing bug
Screen.Recording.2025-07-28.at.11.43.35.PM.movIssue OwnerCurrent Issue Owner: @Upwork Automation - Do Not Edit
Please re-state the problem that we are trying to solve in this issue.
the Free Trial message appears briefly below the task list, and then moves to the top where it should be.
What is the root cause of that problem?
After we complete the onboarding, GetMissingOnyxMessages is called, and the free trial message is returned from the backend. At this time, the current created of the onboarding task isn't updated due to some APIs are still calling. Then the free trial message is displayed as the last message.
What changes do you think we should make in order to solve the problem?
In the same way we create the welcome sign-off message, we can also create the free trial message if we create the task in the admin room
Maybe we need the backend change to support creating the free trial message with the data we passed to guidedSetupData
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update prepareOnboardingOnyxData unit test to verify that the free trial message is created if the user is not the test user.
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@akinwale@johncschuster The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Looks like this one has already been paid out (here). Let's wait for the regression window to pass and then close this up.
@johncschuster The previous PR was reverted after the original regression period due to performance issues detected by Sentry. The new PR is a different solution for the same issue.
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Launch Expensify.
Sign in with a new email account (without +).
Select Manage my team's expenses.
Finish onboarding.
Verify that the welcome message and tasks are created and displayed in the correct order in the #admins chat report of the workspace.
Sign in with a new email (without +).
Select Something else.
Finish onboarding.
Go to the workspace tab.
Create a new workspace.
Navigate to the #admins chat report of the workspace.
Verify that the welcome message and tasks are created and displayed in the correct order.
Sign in with a new email (without +).
Select Track and budget expenses.
Create a workspace.
Finish onboarding.
Verify that the welcome message and tasks are created and displayed in the correct order in the #admins chat report of the workspace.
Activity
melvin-bot commentedon Jul 31, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)melvin-bot commentedon Jul 31, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Jul 31, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
the Free Trial message appears briefly below the task list, and then moves to the top where it should be.
What is the root cause of that problem?
After we complete the onboarding,
GetMissingOnyxMessagesis called, and the free trial message is returned from the backend. At this time, the currentcreatedof the onboarding task isn't updated due to some APIs are still calling. Then the free trial message is displayed as the last message.What changes do you think we should make in order to solve the problem?
In the same way we create the welcome sign-off message, we can also create the free trial message if we create the task in the admin room
App/src/libs/ReportUtils.ts
Line 10281 in a23ee2d
App/src/libs/ReportUtils.ts
Line 10200 in a23ee2d
guidedSetupDatalike the same hereApp/src/libs/ReportUtils.ts
Line 10698 in a23ee2d
guidedSetupDataWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update
prepareOnboardingOnyxDataunit test to verify that the free trial message is created if the user is not the test user.What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nabi-ebrahimi commentedon Aug 4, 2025
This is not reproducible on my end.
Screen.Recording.1404-05-13.at.7.33.08.PM.mp4
carlosmiceli commentedon Aug 4, 2025
@nabi-ebrahimi you should test in production.
melvin-bot commentedon Aug 5, 2025
@akinwale Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Aug 7, 2025
@akinwale 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
131 remaining items
[-]Fix free trial message display order[/-][+][Due for payment 2025-12-05] Fix free trial message display order[/+]melvin-bot commentedon Nov 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 28, 2025
@akinwale @johncschuster The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mountiny commentedon Nov 30, 2025
$250 to @akinwale
johncschuster commentedon Dec 1, 2025
Looks like this one has already been paid out (here). Let's wait for the regression window to pass and then close this up.
akinwale commentedon Dec 1, 2025
@johncschuster The previous PR was reverted after the original regression period due to performance issues detected by Sentry. The new PR is a different solution for the same issue.
akinwale commentedon Dec 3, 2025
BugZero Checklist:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
+).#adminschat report of the workspace.+).#adminschat report of the workspace.+).#adminschat report of the workspace.Do we agree 👍 or 👎?
johncschuster commentedon Dec 5, 2025
Payment Summary
Contributor+: @akinwale due $250 via NewDot
JmillsExpensify commentedon Dec 11, 2025
$250 approved for @akinwale