Skip to content

Update how we apply forked version of react-native-web #6763

Closed

Description

@thienlnam

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


We're currently using a post-install method to apply the patched version of react-native-web in this PR #6738

There are a few issues with this (cc @kidroca)

  1. The post install installs dependencies without maintaining a package-lock
  2. Result is not cacheable and requires a re-compile of the fork
  3. Makes the duration of our PR pipelines longer

Solution:

  1. Use github package service
  2. use patch-package
  3. bundle code in dist https://expensify.slack.com/archives/C01GTK53T8Q/p1637266193313200?thread_ts=1636047163.494200&cid=C01GTK53T8Q

Discussion thread https://expensify.slack.com/archives/C01GTK53T8Q/p1636047163494200

Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Dec 20, 2021

    @MelvinBot
    Contributor

    Huh... This is 4 days overdue. Who can take care of this?

  2. MelvinBot commented on Dec 22, 2021

    @MelvinBot
    Contributor

    6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  3. MelvinBot commented on Dec 24, 2021

    @MelvinBot
    Contributor

    Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  4. MelvinBot commented on Dec 28, 2021

    @MelvinBot
    Contributor

    12 days overdue now... This issue's end is nigh!

  5. MelvinBot commented on Dec 31, 2021

    @MelvinBot
    Contributor

    This issue has not been updated in over 14 days. eroding to Weekly issue.

  6. thienlnam commented on Jan 3, 2022

    @thienlnam
    ContributorAuthor

    No update here

  7. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  8. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  9. 1 remaining item

  10. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  11. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  13. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  14. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  15. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  16. MelvinBot commented on Feb 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  17. MelvinBot commented on Mar 14, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  18. melvin-bot commented on May 27, 2022

    @melvin-bot

    @thienlnam, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions