Skip to content

[Due for payment 2025-08-29] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS in src/libs/migrations/RemoveEmptyReportActionsDrafts.ts #67679

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 1, 2025
  2. tgolen commented on Aug 1, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Aug 1, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. 5 remaining items

  5. danieldoglas commented on Aug 18, 2025

    @danieldoglas
    Contributor

    Merged the PR. #67663

    This was a migration delete, so let's move forward with $125

  6. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 22, 2025
  7. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS` in `src/libs/migrations/RemoveEmptyReportActionsDrafts.ts`[/-] [+][Due for payment 2025-08-29] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS` in `src/libs/migrations/RemoveEmptyReportActionsDrafts.ts`[/+] on Aug 22, 2025
  8. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.97-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-29. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    @shubham1206agra / @DylanDylann @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. sakluger commented on Aug 29, 2025

    @sakluger
    Contributor

    Payment Summary

    Contributor: @shubham1206agra due $125 via Newdot
    Contributor+: @DylanDylann due $125 via Newdot

  12. trjExpensify commented on Sep 1, 2025

    @trjExpensify
    Contributor

    $125 approved for @shubham1206agra

  13. garrettmknight commented on Nov 1, 2025

    @garrettmknight
    Contributor

    $125 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions