Skip to content

[HOLD for payment 2022-01-17] Chat - Indentation is not preserved in comments  #6769

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to any chat
  2. Send a message with indentation
  3. Some item
    i. Some sub-item
    ii. Some other sub-item
  4. Some other item

Expected Result:

Message should be received with indentation

Actual Result:

Format is not persisting

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.20-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen Shot 2021-12-14 at 9 23 12 PM

Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639498323234800

View all open jobs on GitHub

view this job on upwork

Activity

  1. MelvinBot commented on Dec 15, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. added
    ImprovementItem broken or needs improvement.
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Dec 16, 2021
  3. MelvinBot commented on Dec 16, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  4. removed their assignment
    on Dec 16, 2021
  5. jboniface commented on Dec 17, 2021

    @jboniface
  6. 12 remaining items

  7. parasharrajat commented on Dec 27, 2021

    @parasharrajat
    Member

    I can't give you the proper reason why it was marked as dangerous but I think works great for our app and there are no apparant regressions to me.

  8. jsamr commented on Dec 27, 2021

    @jsamr
    Contributor

    @jsamr Any chance you can provide context on why that dangerouslyDisableWhitespaceCollapsing is dangerous?

    Good spot, that is not documented. It is marked dangerous because its side effects are undetermined (have not been assessed thoroughly, appart from the obvious effect of preserving all whitespaces). "dangerous" here means "use it knowingly and with care, strange things could happen"...

  9. deetergp commented on Jan 5, 2022

    @deetergp
    Contributor

    Reviewed, approved, & merged.

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 10, 2022
  11. botify commented on Jan 10, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.26-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-17. 🎊

  12. changed the title [-]Chat - Indentation is not preserved in comments [/-] [+][HOLD for payment 2022-01-17] Chat - Indentation is not preserved in comments [/+] on Jan 10, 2022
  13. jboniface commented on Jan 17, 2022

    @jboniface

    @parasharrajat looks like we never hired on upwork and the job closed itself. i sent a new one.

  14. jboniface commented on Jan 21, 2022

    @jboniface

    paid but forgot to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions