You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-01-17] Chat - Indentation is not preserved in comments #6769
@jsamr Any chance you can provide context on why that dangerouslyDisableWhitespaceCollapsing is dangerous?
Good spot, that is not documented. It is marked dangerous because its side effects are undetermined (have not been assessed thoroughly, appart from the obvious effect of preserving all whitespaces). "dangerous" here means "use it knowingly and with care, strange things could happen"...
Reacted by parasharrajat, Rory Abraham and Scott Deeter
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.26-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]Chat - Indentation is not preserved in comments [/-][+][HOLD for payment 2022-01-17] Chat - Indentation is not preserved in comments [/+]on Jan 10, 2022
Activity
MelvinBot commentedon Dec 15, 2021
Triggered auto assignment to @stitesExpensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Dec 16, 2021
Triggered auto assignment to @jboniface (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.jboniface commentedon Dec 17, 2021
https://www.upwork.com/jobs/~010dbb053733c33760
12 remaining items
parasharrajat commentedon Dec 27, 2021
I can't give you the proper reason why it was marked as dangerous but I think works great for our app and there are no apparant regressions to me.
jsamr commentedon Dec 27, 2021
Good spot, that is not documented. It is marked dangerous because its side effects are undetermined (have not been assessed thoroughly, appart from the obvious effect of preserving all whitespaces). "dangerous" here means "use it knowingly and with care, strange things could happen"...
deetergp commentedon Jan 5, 2022
Reviewed, approved, & merged.
botify commentedon Jan 10, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.26-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-01-17. 🎊
[-]Chat - Indentation is not preserved in comments [/-][+][HOLD for payment 2022-01-17] Chat - Indentation is not preserved in comments [/+]jboniface commentedon Jan 17, 2022
@parasharrajat looks like we never hired on upwork and the job closed itself. i sent a new one.
jboniface commentedon Jan 21, 2022
paid but forgot to close