Skip to content

[Due for payment 2026-03-30] [Due for payment 2026-03-19] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT in src/libs/actions/Transaction.ts #67778

Closed

Description

@danieldoglas

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 4, 2025
  2. danieldoglas commented on Aug 4, 2025

    @danieldoglas
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Aug 4, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. allgandalf commented on Aug 20, 2025

    @allgandalf
    Contributor

    @tgolen can you please assign me and @DylanDylann here, thanks !

  5. dariusz-biela commented on Sep 5, 2025

    @dariusz-biela
    Contributor

    Hi. I'm Dariusz Biela from Software Mansion.

    Gandalf wrote to me that I can take over some of his issues from the "Deprecate Onyx.connect" project from the files:

    • src/libs/actions/App.ts
    • src/libs/actions/Policy/Tag.ts
    • src/libs/migrations/KeyReportActionsDraftByReportActionID.ts
    • src/libs/actions/Transaction.ts

    @tgolen
    Could you assign me to this issue?

  6. 74 remaining items

  7. tgolen commented on Mar 19, 2026

    @tgolen
    Contributor

    I approve $1250 for those PRs. @dukenv0307 it did looks like maybe one or two of them were pretty large PRs here and here. Let me know if you think you should be paid more for them.

  8. melvin-bot commented on Mar 19, 2026

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  9. melvin-bot commented on Mar 19, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. dukenv0307 commented on Mar 20, 2026

    @dukenv0307
    Contributor

    @tgolen Thanks for your response. I'd like to raise the bounty of each PR (#79954 and #79948) to $500 because of their scopes. Then the total bounty will be $1750 cc @DylanDylann

  11. tgolen commented on Mar 20, 2026

    @tgolen
    Contributor

    OK, that makes sense and I approve the increased price.

  12. mallenexpensify commented on Mar 20, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @DylanDylann due $1750 via NewDot
    Contributor+: @dukenv0307 due $1750 via NewDot

    Thx!

  13. changed the title [-][Due for payment 2026-03-19] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.TRANSACTION_DRAFT` in `src/libs/actions/Transaction.ts`[/-] [+][Due for payment 2026-03-30] [Due for payment 2026-03-19] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.TRANSACTION_DRAFT` in `src/libs/actions/Transaction.ts`[/+] on Mar 23, 2026
  14. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @dukenv0307 requires payment through NewDot Manual Requests
    • @DylanDylann requires payment through NewDot Manual Requests
  15. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    @dukenv0307 / @DylanDylann @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. JmillsExpensify commented on Mar 24, 2026

    @JmillsExpensify
    Contributor

    $1,750 approved for @DylanDylann

  17. quinthar commented on Mar 28, 2026

    @quinthar
    Contributor

    Approved $1750 to @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions