Skip to content

Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT in src/libs/actions/Transaction.ts #67779

Closed

Description

@danieldoglas

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 4, 2025
  2. danieldoglas commented on Aug 4, 2025

    @danieldoglas
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Aug 4, 2025

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. allgandalf commented on Aug 20, 2025

    @allgandalf
    Contributor

    @tgolen can you please assign me and @DylanDylann here, thanks !

  5. dariusz-biela commented on Sep 5, 2025

    @dariusz-biela
    Contributor

    Hi. I'm Dariusz Biela from Software Mansion.

    Gandalf wrote to me that I can take over some of his issues from the "Deprecate Onyx.connect" project from the files:

    • src/libs/actions/App.ts
    • src/libs/actions/Policy/Tag.ts
    • src/libs/migrations/KeyReportActionsDraftByReportActionID.ts
    • src/libs/actions/Transaction.ts

    @tgolen
    Could you assign me to this issue?

  6. 21 remaining items

  7. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Jul 24, 2026
  8. melvin-bot commented on Aug 11, 2026

    @melvin-bot

    Triggered auto assignment to @mjasikowski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  9. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    @DylanDylann

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.53-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-21. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  10. DylanDylann commented on Aug 18, 2026

    @DylanDylann
    Contributor

    All done

  11. DylanDylann commented on Aug 18, 2026

    @DylanDylann
    Contributor
  12. mallenexpensify commented on Aug 25, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @DylanDylann due $250 via NewDot

  13. quinthar commented on Sep 26, 2026

    @quinthar
    Contributor

    Approved $250 to @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.Not a prioritySkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions