Skip to content

[Due for payment 2025-10-30] [HOLD 72611][Due for payment 2025-10-03] Require title field rNVP to compute optimistic report names #67823

Closed
1 of 1 issue completed

Description

@neil-marcellini

Problem

As mentioned in this PR comment, when the frontend optimistically computes report names, it should only do so for reports that already have the title field set in the report name value pairs. We will need to modify optimistic report creation in app to copy over the title field from the policy, and also do that for other actions such as changing a report's policy. The reason for this is that the lack of the field is used to signify that the report has been manually renamed, and is used to prevent the name from being recomputed and overriding the manually set name.

Without implementing such logic, the following case will be failing. If report names can be changed, a manually renamed report retains its manual name when the policy report name formula is updated

Image

Solution

Implement the logic in the updateTitleFieldToMatchPolicy function when reports are created or move policies. Check if the title field rNVP exists before optimistically computing report names. cc @sosek108

Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. melvin-bot commented on Aug 4, 2025

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  2. melvin-bot commented on Aug 4, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  3. melvin-bot commented on Aug 4, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  4. dubielzyk-expensify commented on Aug 13, 2025

    @dubielzyk-expensify
    Contributor

    Anything needed from my end here?

  5. neil-marcellini commented on Aug 14, 2025

    @neil-marcellini
    ContributorAuthor

    Asking if @sosek108 can branch off his initial PR and start on this now

  6. sosek108 commented on Aug 18, 2025

    @sosek108
    Contributor

    Please, assign me to this issue

  7. 78 remaining items

  8. changed the title [-][HOLD 72611][Due for payment 2025-10-03] Require title field rNVP to compute optimistic report names[/-] [+][Due for payment 2025-10-30] [HOLD 72611][Due for payment 2025-10-03] Require title field rNVP to compute optimistic report names[/+] on Oct 23, 2025
  9. melvin-bot commented on Oct 23, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Oct 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.36-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sosek108 does not require payment (Contractor)
  11. melvin-bot commented on Oct 23, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sosek108] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  12. bfitzexpensify commented on Oct 30, 2025

    @bfitzexpensify
    Contributor

    @sosek108 bump on this comment - #67823 (comment)

  13. melvin-bot commented on Oct 30, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  14. sosek108 commented on Oct 31, 2025

    @sosek108
    Contributor

    @bfitzexpensify

    Today I think there is nothing to propose as we first introduced some changes and with next PR we reverted some of them so the initial logic works as before.

    We're focusing on other tasks and we'll reintroduce rNVP for optimistic report names after these tasks are done: #72613 #72611

  15. sobitneupane commented on Dec 2, 2025

    @sobitneupane
    Contributor

    @bfitzexpensify I reviewed the associated PR. Could you assign the issue to me and add a payment summary when you get a chance?

  16. bfitzexpensify commented on Dec 3, 2025

    @bfitzexpensify
    Contributor

    Payment summary:

    @sobitneupane due $250 via NewDot manual request for PR review

  17. quinthar commented on Dec 8, 2025

    @quinthar
    Contributor

    Approved $250 to @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions