Skip to content

Expense - Leave option in empty report is always shown for non-admin approver #67864

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.89-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #67338
Email or phone of affected tester (no customers): sdoinjsodjsdidso@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create a workspace with admin, non-admin approver and member.
  1. Go to staging.new.expensify.com
  2. [Member} Go to workspace chat.
  3. [Member] Create an empty report via + > Create report.
  4. [Non-admin approver] Go to workspace chat with member.
  5. [Non-admin approver] Open the empty report.
  6. [Non-admin approver] Click report header.
  7. [Non-admin approver] Click Leave.
  8. [Non-admin approver] Repeat Step 5 to 7.

Expected Result:

Leave option in empty report should not be shown for non-admin approver when non-admin approver did not manually choose to join it in the first place.

Actual Result:

Leave option in empty report is always shown for non-admin approver even though the approver has left the empty report again and again.

The same option is not seen on admin's end.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 5, 2025
  2. melvin-bot commented on Aug 5, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Aug 5, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Aug 5, 2025

    @melvin-bot

    Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Aug 5, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. added
    ReviewingHas a PR in review
    and removed on Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions