Skip to content

[Due for payment 2025-09-19] Merge - Expense created on member´s side on different WS, shown on admin´s side when merging #68195

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.91-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #65596
Email or phone of affected tester (no customers): ibellicotest+1546@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 10 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: User A, has at least one workspace created.
Prerequisite 2: User B, has at least one workspace created.

  1. Open the Expensify app.
  2. Log in as User A.
  3. Navigate to "Workspaces" and open any workspace.
  4. Tap on "Members" and invite User B as member.
  5. As User B, open an owned workspace chat.
  6. Submit a manual expense to it.
  7. Also as User B, navigate to the workspace chat where User A is admin.
  8. Submit a different manual expense to it.
  9. As User A, open the expense created by User B.
  10. Tap on "More" and select "Merge"
  11. Note that the first expense created by User B, appears on the list, despite User A, not being part of the workspace where it was created.
  12. Tap on the expense. and tap on "Continue"
  13. Keep the amount from the selected expense.
  14. Once redirected to report, note that the amount wasn´t changed.

Expected Result:

Admin of a workspace, shouldn´t be able to merge an expense created by a member, selecting an expense that belongs to a workspace from member´s account.

Actual Result:

When admin of a workspace, tries to merge an expense created by a member, an expense that belongs to a different workspace from member´s account, appears on the list, despite admin not being part of that workspace.
Also, amount is not changed after finishing the merging process selecting that expense.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6911146_1754634760098.Admin.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 8, 2025
  2. github-actions commented on Aug 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Aug 8, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Aug 8, 2025

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Aug 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. 22 remaining items

  7. melvin-bot commented on Aug 29, 2025

    @melvin-bot

    @hoangzinh, @youssef-lr, @muttmuure, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. garrettmknight commented on Sep 2, 2025

    @garrettmknight
    Contributor

    Fixed in this adhoc build: https://68204.pr-testing.expensify.com/

  9. youssef-lr commented on Sep 2, 2025

    @youssef-lr
    Contributor

    Not overdue.

  10. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Sep 3, 2025
  11. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 12, 2025
  13. changed the title [-]Merge - Expense created on member´s side on different WS, shown on admin´s side when merging[/-] [+][Due for payment 2025-09-19] Merge - Expense created on member´s side on different WS, shown on admin´s side when merging[/+] on Sep 12, 2025
  14. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.12-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hoangzinh requires payment through NewDot Manual Requests
    • @dominictb requires payment (Needs manual offer from BZ)
  15. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    @hoangzinh / @dominictb @muttmuure The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions