Skip to content

[Due for payment 2025-09-19] Merge flow – Misaligned radio button with long category name #68243

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.1.92-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): Slottwo1 7423@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Money Requests

Action Performed:

  1. Launch app in both mweb and Android
  2. Open workpace chat
  3. Tap category
  4. Add a long category - Advertisingradhe-krishna-dfgggggghhhhhhh-hhhhhhhhh-hhhhhhhhhghbbnnbbbb-radhe-radherradhe-krishncvbbnhhjjjjjjjh Hbb.com
  5. Create 2 expenses with merchant and category. For any one expense select the long category
  6. Open the expense in which long category is not selected
  7. Tap more - merge - select the expense with long category
  8. Note in mweb and Android

Expected Result:

In merge flow, when long category name is entered radio button placement must not be misaligned.

Actual Result:

In merge flow, when long category name is entered radio button placement is misaligned in android and not in mweb.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 9, 2025
  2. melvin-bot commented on Aug 9, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Aug 9, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Aug 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. Krishna2323 commented on Aug 9, 2025

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Merge flow – Misaligned radio button with long category name

    What is the root cause of that problem?

    What changes do you think we should make in order to solve the problem?

    • We should simply add styles.flex1 to the text styles.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Result

  7. hoangzinh commented on Aug 11, 2025

    @hoangzinh
    Contributor

    I fixed in this commit fc9e2e3

  8. 13 remaining items

  9. garrettmknight commented on Aug 29, 2025

    @garrettmknight
    Contributor

    Can't test on current adhoc build (no android), will need to test on another adhoc build or on staging..

  10. garrettmknight commented on Sep 3, 2025

    @garrettmknight
    Contributor

    Same as above, I think we can test this when we deploy. It's super small.

  11. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon Sep 9, 2025
  12. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 12, 2025
  14. changed the title [-]Merge flow – Misaligned radio button with long category name[/-] [+][Due for payment 2025-09-19] Merge flow – Misaligned radio button with long category name[/+] on Sep 12, 2025
  15. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.12-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-19. 🎊

  17. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    @youssef-lr @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions