Skip to content

[Due for payment 2025-10-15] [$250] Exempt .md files in docs/articles from engineering PR checks #68495

Closed

Description

@stephanieelliott

Context:

From an internal Slack discussion: to simplify publishing HelpDot content, we want to exempt HelpDot articles from irrelevant engineering PR checks (GitHub Actions).

These checks should either auto-pass or be skipped (either one works) when a PR changes an affected file.

From @thienlnam

All of these are in App behind docs/articles and are markdown files so we should be able to update the tests to not run on these specific files

Added 8/27:
Let's get the checklist to stop pre-populating in the PR body too. Discussed here, as GitHub supports only one template for PRs we'll have to do a workaround to remove the checklist using a bot.

--

Files this will apply to

all .md files in docs/articles and sub-folders.

Affected tests

Skip or auto-pass these automated PR checks. Note that this is all automated PR checks except spell check:

  • PR Reviewer Checklist / checklist (pull_request_review)
  • imgbot Image Optimization / approveAndMerge (pull_request)
  • PR Presubmit Reviews / review (pull_request)
  • / Changed files ESLint check (pull_request)
  • Check unused styles / Check for unused styles (pull_request)
  • CLA Assistant / CLA / CLA (pull_request_target)
  • ESLint check / ESLint check (pull_request)
  • Generate static translations / dryRun (pull_request)
  • Jest Unit Tests / Storybook tests (pull_request)
  • Jest Unit Tests / test (job 1) (pull_request)
  • Jest Unit Tests / test (job 2) (pull_request)
  • Jest Unit Tests / test (job 3) (pull_request)
  • license/snyk (expensify)
  • PR Author Checklist / checklist (pull_request_target)
  • Prettier check / Prettier check (pull_request)
  • Reassure Performance Tests / perf-tests (pull_request)
  • security/snyk (expensify)
  • TypeScript Checks / typecheck (pull_request)
  • Verify signed commits / verifySignedCommits (pull_request)
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. stephanieelliott commented on Aug 14, 2025

    @stephanieelliott
    ContributorAuthor

    I think a couple of these might live in Expensify/GitHub-Actions, but most should be local to this repo

  2. removed
    InternalRequires API changes or must be handled by Expensify staff
    on Aug 18, 2025
  3. stephanieelliott commented on Aug 18, 2025

    @stephanieelliott
    ContributorAuthor

    Hey @rushatgabhane any blockers for this one, or can we get started?

  4. 41 remaining items

  5. changed the title [-][Due for payment 2025-10-15] Exempt .md files in docs/articles from engineering PR checks[/-] [+][Due for payment 2025-10-15] [Due for payment 2025-10-15] Exempt .md files in docs/articles from engineering PR checks[/+] on Oct 8, 2025
  6. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.27-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-15. 🎊

    For reference, here are some details about the assignees on this issue:

  7. stephanieelliott commented on Oct 9, 2025

    @stephanieelliott
    ContributorAuthor

    Hey @rushatgabhane this is still failing in some scenarios -- Can you check out this PR I created today? Its failing on the PR reviewer CL, and the PR author CL #72282

  8. rushatgabhane commented on Oct 10, 2025

    @rushatgabhane
    Member

    @stephanieelliott looks like all checks passing for that PR, right?

  9. stephanieelliott commented on Oct 10, 2025

    @stephanieelliott
    ContributorAuthor

    It passed because I added the PR author checklist 🙃

  10. rushatgabhane commented on Oct 10, 2025

    @rushatgabhane
    Member

    Ahh I get it. It is because the files in the PR didn't have .md extension.
    We ignore the checks only if the PR is changing a .md file in docs or redirects.csv

    This is intentional

  11. melvin-bot commented on Oct 15, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@stephanieelliott)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. stephanieelliott commented on Oct 16, 2025

    @stephanieelliott
    ContributorAuthor

    Ahh I get it. It is because the files in the PR didn't have .md extension.
    We ignore the checks only if the PR is changing a .md file in docs or redirects.csv

    Ah yes ok that makes sense! Thanks @rushatgabhane

  13. changed the title [-][Due for payment 2025-10-15] [Due for payment 2025-10-15] Exempt .md files in docs/articles from engineering PR checks[/-] [+][Due for payment 2025-10-15] [$250] Exempt .md files in docs/articles from engineering PR checks[/+] on Oct 16, 2025
  14. melvin-bot commented on Oct 16, 2025

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  15. stephanieelliott commented on Oct 16, 2025

    @stephanieelliott
    ContributorAuthor

    Payment Summary

    Contributor: @rushatgabhane due $250 via NewDot
    Contributor+: N/A internal

  16. quinthar commented on Oct 18, 2025

    @quinthar
    Contributor

    Approved $250 to @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionWeeklyKSv2

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions