You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense report previews are missing violations RBR's when an expense in the report is auto-categorized #68549
Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@shawnborton Slack conversation (hyperlinked to channel name): #Quality
Action Performed:
Go to the workspace chat where a report was submitted
View the expense report preview in the chat
Click into the report, then go back to the workspace chat
Expected Result:
The report preview should always show the status, total amount, and correct report title without requiring the user to click into the report first.
Actual Result:
The preview does not display the report status
The preview does not display the total amount until after opening the report, the report title does not update even after clicking into the report (but the total does update)
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
changed the title [-]Expense report preview is missing status, missing total, and report title not updating[/-][+][$250] Expense report preview is missing status, missing total, and report title not updating[/+]on Aug 15, 2025
Bug: when concierge moves an expense with no description into a category that requires descriptions, no violation is created
Enable the "Categories" feature on your workspace if it isn't already
Enable "Require description" under "Category rules" for the "Meals and Entertainment" category on your policy
Create an expense in the workspace, leave the description blank, but set the merchant to a well known restaurant
Go to the workspace chat and wait for concierge to apply the "Meals and Entertainment" category.
Expected: Expense shows "Review required" RBR under category
Observed: no RBR until the user navigates to the report
auto-categorization.violations.do.not.work.mp4
Bug: when concierge moves an expense on a report with existing expenses that have violations, the existing violations are cleared
Create a report and add an expense with any violation
Go to the workspace chat
Add a new expense without a category. It doesn't matter whether this expense has or will have violations or not
Expected: Existing expenses keep their violations after auto-categorization runs
Observed: Existing violations are cleared until the user navigates to the report
Both of these bugs have the same root cause: auto-categorization tries to calculate violations, but we call Violations::get with concierge's accountID, which won't be listed on the actual report or sharedReport records. This requires a backend fix
changed the title [-][$250] Expense report preview is missing status, missing total, and report title not updating[/-][+]Expense report previews are missing violations RBR's when an expense in the report is auto-categorized[/+]on Sep 10, 2025
Would it be too weird to leave them both open but let them both be fixed by the same PR? They're distinct in terms of the user flows that need to be tested, they just have the same underlying cause
Activity
melvin-bot commentedon Aug 14, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Aug 14, 2025
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
joekaufmanexpensify commentedon Aug 15, 2025
Discussing
[-]Expense report preview is missing status, missing total, and report title not updating[/-][+][$250] Expense report preview is missing status, missing total, and report title not updating[/+]melvin-bot commentedon Aug 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021956364914676875554
21 remaining items
chuckdries commentedon Sep 5, 2025
joekaufmanexpensify commentedon Sep 8, 2025
TY!
chuckdries commentedon Sep 10, 2025
So, this is actually two discrete issues
Going forward, this issue will be focused on solving number 1. Number 2 will be tracked by https://github.com/Expensify/Expensify/issues/545950
Expense violations and auto-categorization
Let's start with some concrete, reproducible bugs
Bug: when concierge moves an expense with no description into a category that requires descriptions, no violation is created
Expected: Expense shows "Review required" RBR under category
Observed: no RBR until the user navigates to the report
auto-categorization.violations.do.not.work.mp4
Bug: when concierge moves an expense on a report with existing expenses that have violations, the existing violations are cleared
Expected: Existing expenses keep their violations after auto-categorization runs
Observed: Existing violations are cleared until the user navigates to the report
auto-categorization.clears.existing.violations.mp4
Root cause
Both of these bugs have the same root cause: auto-categorization tries to calculate violations, but we call
Violations::getwith concierge's accountID, which won't be listed on the actual report or sharedReport records. This requires a backend fix[-][$250] Expense report preview is missing status, missing total, and report title not updating[/-][+]Expense report previews are missing violations RBR's when an expense in the report is auto-categorized[/+]s77rt commentedon Sep 15, 2025
This is same as #66825
joekaufmanexpensify commentedon Sep 15, 2025
Ah, interesting. Do you agree with that @chuckdries ?
chuckdries commentedon Sep 15, 2025
Ah yeah looks like they do have the same root cause
joekaufmanexpensify commentedon Sep 15, 2025
Got it. Should we close this one in favor of that one then?
chuckdries commentedon Sep 15, 2025
Would it be too weird to leave them both open but let them both be fixed by the same PR? They're distinct in terms of the user flows that need to be tested, they just have the same underlying cause
joekaufmanexpensify commentedon Sep 15, 2025
Nope, that's fine too. But we'll just go with @s77rt's PR to fix it?
chuckdries commentedon Sep 16, 2025
Yep, looks like their PR did the trick. I'll close this issue out when the fix goes to prod.
joekaufmanexpensify commentedon Sep 17, 2025
great. TY!