Skip to content

[$250] Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion #68800

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.97-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #68269
Email or phone of affected tester (no customers): qaooxx+351@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the app
  2. Create a workspace
  3. Create a distance expense
  4. Delete the workspace
  5. Open the archived report

Expected Result:

Compose box should not appear on an archived report

Actual Result:

Compose box remains visible even though the report is archived

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6921433_1755637638408.1_58_PM_2025-08-19.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021960547763317723557
  • Upwork Job ID: 1960547763317723557
  • Last Price Increase: 2025-08-27
Issue OwnerCurrent Issue Owner: @Ollyws

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 19, 2025
  2. melvin-bot commented on Aug 19, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Eskalifer1 commented on Aug 19, 2025

    @Eskalifer1
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion

    What is the root cause of that problem?

    Here is the line where we check whether composer can be displayed:

    const shouldHideComposer = !canPerformWriteAction || isBlockedFromChat;

    But here we don't check whether the expense is archived, only isArchivedNonExpenseReport inside canUserPerformWriteAction

    What changes do you think we should make in order to solve the problem?

    We need to add more checks to see if the report is archived:
    const shouldHideComposer = !canPerformWriteAction || isBlockedFromChat || isReportArchived;

    PS: If necessary, we can also add a check to see if it is isExpenseReport(report) || isExpenseRequest(report) or isMoneyRequestReport or any other that can be used in this case. What function to use we can discuss during PR stage

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    We can move this check to canUserPerformWriteAction if needed
    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    @johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    @johncschuster Still overdue 6 days?! Let's take care of this!

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 27, 2025
  7. changed the title [-]Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion[/-] [+][$250] Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion[/+] on Aug 27, 2025
  8. melvin-bot commented on Aug 27, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 27, 2025
  10. melvin-bot commented on Aug 27, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  11. Ollyws commented on Aug 27, 2025

    @Ollyws
    Contributor

    Is it not the expected behaviour to be able to comment on archived expense reports?

  12. melvin-bot commented on Sep 1, 2025

    @melvin-bot

    @Ollyws Huh... This is 4 days overdue. Who can take care of this?

  13. Ollyws commented on Sep 2, 2025

    @Ollyws
    Contributor

    Yes I remember explicity adding this in #49169, could you confirm that it's still the case that we should be able to comment on archived expense reports after the workspace has been deleted @trjExpensify?

  14. trjExpensify commented on Sep 2, 2025

    @trjExpensify
    Contributor

    Yes, you should be able to still comment on expense reports. It remains backwards compatible with Classic. 👍

  15. Ollyws commented on Sep 2, 2025

    @Ollyws
    Contributor

    Thanks!
    Ok I think we can close this then @johncschuster as it's the expected behaviour.

  16. melvin-bot commented on Sep 2, 2025

    @melvin-bot

    @johncschuster @Ollyws this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  17. trjExpensify commented on Sep 3, 2025

    @trjExpensify
    Contributor

    Agreed, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions