You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion #68800
Version Number: 9.1.97-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:#68269 Email or phone of affected tester (no customers):qaooxx+351@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Open the app
Create a workspace
Create a distance expense
Delete the workspace
Open the archived report
Expected Result:
Compose box should not appear on an archived report
Actual Result:
Compose box remains visible even though the report is archived
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6921433_1755637638408.1_58_PM_2025-08-19.mp4
But here we don't check whether the expense is archived, only isArchivedNonExpenseReport inside canUserPerformWriteAction
What changes do you think we should make in order to solve the problem?
We need to add more checks to see if the report is archived: const shouldHideComposer = !canPerformWriteAction || isBlockedFromChat || isReportArchived;
PS: If necessary, we can also add a check to see if it is isExpenseReport(report) || isExpenseRequest(report) or isMoneyRequestReport or any other that can be used in this case. What function to use we can discuss during PR stage
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
We can move this check to canUserPerformWriteAction if needed Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion[/-][+][$250] Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion[/+]on Aug 27, 2025
Yes I remember explicity adding this in #49169, could you confirm that it's still the case that we should be able to comment on archived expense reports after the workspace has been deleted @trjExpensify?
@johncschuster@Ollyws this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
melvin-bot commentedon Aug 19, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Eskalifer1 commentedon Aug 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion
What is the root cause of that problem?
Here is the line where we check whether composer can be displayed:
App/src/pages/home/report/ReportFooter.tsx
Line 119 in c88901d
But here we don't check whether the expense is archived, only isArchivedNonExpenseReport inside
canUserPerformWriteActionWhat changes do you think we should make in order to solve the problem?
We need to add more checks to see if the report is archived:
const shouldHideComposer = !canPerformWriteAction || isBlockedFromChat || isReportArchived;PS: If necessary, we can also add a check to see if it is isExpenseReport(report) || isExpenseRequest(report) or isMoneyRequestReport or any other that can be used in this case. What function to use we can discuss during PR stage
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
We can move this check to
canUserPerformWriteActionif neededReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Aug 22, 2025
@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Aug 26, 2025
@johncschuster Still overdue 6 days?! Let's take care of this!
[-]Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion[/-][+][$250] Chat - Compose Box Remains Visible on Archived Report After Workspace Deletion[/+]melvin-bot commentedon Aug 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021960547763317723557
melvin-bot commentedon Aug 27, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)Ollyws commentedon Aug 27, 2025
Is it not the expected behaviour to be able to comment on archived expense reports?
melvin-bot commentedon Sep 1, 2025
@Ollyws Huh... This is 4 days overdue. Who can take care of this?
Ollyws commentedon Sep 2, 2025
Yes I remember explicity adding this in #49169, could you confirm that it's still the case that we should be able to comment on archived expense reports after the workspace has been deleted @trjExpensify?
trjExpensify commentedon Sep 2, 2025
Yes, you should be able to still comment on expense reports. It remains backwards compatible with Classic. 👍
Ollyws commentedon Sep 2, 2025
Thanks!
Ok I think we can close this then @johncschuster as it's the expected behaviour.
melvin-bot commentedon Sep 2, 2025
@johncschuster @Ollyws this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
trjExpensify commentedon Sep 3, 2025
Agreed, closing!