Skip to content

[$250] Split expense - Reimbursable is enabled in split preview when it is disabled during creation #68837

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.97-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #68581
Email or phone of affected tester (no customers): applausetester+140823khh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to Account > Save the world.
  3. Click I am a teacher.
  4. Enter name and work email (any expensifail account).
  5. Once landed in Teachers Unite workspace chat, click +.
  6. If Split expense option disappears, refresh the page.
  7. Click + > Split expense.
  8. Enter amount > Next.
  9. On confirm page, enter merchant and disable Reimbursable toggle.
  10. Click Split button.
  11. Open split preview and transaction thread.

Expected Result:

Reimbursable toggle will be disabled in split preview and transaction thread because it is created with reimbursable disabled on confirm page (Step 9).

Actual Result:

Reimbursable toggle is enabled in split preview and transaction thread when it is created with reimbursable disabled on confirm page (Step 9).

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sonialiap
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021986443382446792997
  • Upwork Job ID: 1986443382446792997
  • Last Price Increase: 2025-12-04

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 20, 2025
  2. melvin-bot commented on Aug 20, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Aug 20, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Aug 20, 2025

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Aug 20, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. daledah commented on Aug 20, 2025

    @daledah
    Contributor

    We need expected behaviour in this case 👀

  7. flaviadefaria commented on Aug 20, 2025

    @flaviadefaria
    Contributor

    This is definitely not a deploy blocker.

    Also @jponikarchuk is this only reproducible when going to Account > Save the world or also from any other workspace (Collect/Control)?

  8. trjExpensify commented on Aug 20, 2025

    @trjExpensify
    Contributor

    Yeah, TU workspace is the only place you can do a P2P style "split expense" on a workspace right now. Totally agree this is an edge case and can be demoted.

  9. 94 remaining items

  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 9, 2025
  11. neil-marcellini commented on Dec 9, 2025

    @neil-marcellini
    Contributor

    I still stand that this is a BE issue.

    As mentioned here, the Cash expenses are is set to Always reimbursable, but disabledFields.reimbursable is false in the TU workspace.

    @neil-marcellini can you please check this?

    Yeah that does sound like the problem. I will investigate.

  12. neil-marcellini commented on Dec 9, 2025

    @neil-marcellini
    Contributor

    Ah wow this is a funny one!

    I supportaled in and found the data from the teacher's unit test policyID ABD1345ED7293535. When on staging we use the test policy

                "defaultReimbursable": true,
                "disabledFields": {
                    "defaultBillable": true,
                    "reimbursable": false
                },

    That's why we see disabledFields.reimbursable == false

    The data is properly set for the prod policyID B795B6319125BDF2

                    "defaultReimbursable": true,
                    "disabledFields": {
                        "defaultBillable": true,
                        "reimbursable": true
                    },

    I think we'll need @sonialiap to fix the setting on the test policy (ABD1345ED7293535) and then we should be all good.

  13. sonialiap commented on Dec 16, 2025

    @sonialiap
    Contributor

    Noting for myself: ABD1345ED7293535 is owned by volunteer@expensify.org

    I changed from reimbursable by default to always reimbursable

    Image
  14. sonialiap commented on Dec 16, 2025

    @sonialiap
    Contributor
  15. m-natarajan commented on Dec 16, 2025

    @m-natarajan

    No Reimbursement toggle, MacOS Monterey / Chrome, Xiaomi Redmi Note 10 / Android 12, iPhone 13 / iOS 18.7.1, v9.2.78-6

    IMG_0441.MP4
    Screenrecorder-2025-12-16-16-01-42-257.mp4
    Screen.Recording.2025-12-16.at.15.49.53.mp4
  16. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. neil-marcellini commented on Dec 22, 2025

    @neil-marcellini
    Contributor

    Ok, I think this is fixed. Closing it. We can re-open if needed for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions