Skip to content

[HOLD for payment 2022-05-02] Can't use slash in debit card expiration date field on iPhone - Reported by @thesahindia #6891

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to app
  2. Navigate to Settings > Payments > Add payment method
  3. Select Debit card
  4. Try to enter / in date field

Expected Result:

User should be able to enter /

Actual Result:

User is unable to enter /

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2021-12-23.at.1.28.22.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640203176471300

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Dec 23, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. sketchydroide commented on Dec 23, 2021

    @sketchydroide
    Contributor

    I see 2 ways to go about this:

    1. Add the / to the symbol keyboard
    2. Automatically add the / after the first 2 numbers

    We coul potentially do both.
    @Jag96 you seem to have worked on thid, any suggestion?

  3. mallenexpensify commented on Dec 23, 2021

    @mallenexpensify
    Contributor

    From the Slack thread

    We could just add the / to the keypad below.
    If so. I think it'd also be good to auto-add the /after numbers 2-12 since that's what the next step/action would be.... right?

    image

  4. mananjadhav commented on Dec 24, 2021

    @mananjadhav
    Collaborator

    Proposal
    None of the keyboard types support '/' in addition to numbers. There's numbers-and-punctuation but it only works on iOS. I would recommend adding / automatically.

    Something on the following lines (not thoroughly tested):

    handleExpiryDateChange = (text) => {
      let currentExpiry = text;
      if (currentExpiry[0] !== '1' && currentExpiry[0] !== '0') {
        currentExpiry = '';
      }
    
      if (currentExpiry.length === 2) {
          if (parseInt(currentExpiry.substring(0, 2)) > 12 || parseInt(currentExpiry.substring(0, 2)) == 0) {
            currentExpiry = currentExpiry[0];
          } else if (this.state.text.length === 2) {
            currentExpiry += '/';
          } else {
            currentExpiry = currentExpiry[0];
          }
        }
        this.clearErrorAndSetValue('expirationDate', currentExpiry)
    }
    

    and then onChangeText call handleExpiryDateChange.

    In addition to this, I have a small enhancement. CardUtils.getYearFromExpirationDateString we're hardcoding 20${cardYear}. While I know it'll work for the next 80 years 😛 , we could just make it dynamic.

    moment().format('YYYY').substring(0, 2)

  5. MelvinBot commented on Dec 28, 2021

    @MelvinBot
    Contributor

    @sketchydroide Huh... This is 4 days overdue. Who can take care of this?

  6. mallenexpensify commented on Dec 28, 2021

    @mallenexpensify
    Contributor

    @sketchydroide can you review @mananjadhav 's Proposal above when you're back? Thx
    #6891 (comment)

  7. MelvinBot commented on Dec 30, 2021

    @MelvinBot
    Contributor

    @sketchydroide Still overdue 6 days?! Let's take care of this!

  8. 80 remaining items

  9. changed the title [-]Can't use slash in debit card expiration date field on iPhone - Reported by @thesahindia[/-] [+][HOLD for payment 2022-05-02] Can't use slash in debit card expiration date field on iPhone - Reported by @thesahindia[/+] on Apr 25, 2022
  10. melvin-bot commented on Apr 25, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.56-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-05-02. 🎊

  11. mallenexpensify commented on Apr 30, 2022

    @mallenexpensify
    Contributor

    @mananjadhav @parasharrajat @thesahindia Hired in Upwork, can you accept the offer please?
    I'll pay on Wednesday, I'm off Mon/Tues
    https://www.upwork.com/jobs/~01bcc8abfe9585856e

  12. Julesssss commented on May 5, 2022

    @Julesssss
    Contributor

    Not overdue

  13. mananjadhav commented on May 5, 2022

    @mananjadhav
    Collaborator

    @mallenexpensify Reminder on Upwork payment

  14. mallenexpensify commented on May 6, 2022

    @mallenexpensify
    Contributor

    Thanks for the ping @mananjadhav .
    @parasharrajat @thesahindia and @mananjadhav paid $250 each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions