You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-05-02] Can't use slash in debit card expiration date field on iPhone - Reported by @thesahindia #6891
We could just add the / to the keypad below.
If so. I think it'd also be good to auto-add the /after numbers 2-12 since that's what the next step/action would be.... right?
Proposal
None of the keyboard types support '/' in addition to numbers. There's numbers-and-punctuation but it only works on iOS. I would recommend adding / automatically.
Something on the following lines (not thoroughly tested):
and then onChangeText call handleExpiryDateChange.
In addition to this, I have a small enhancement. CardUtils.getYearFromExpirationDateString we're hardcoding 20${cardYear}. While I know it'll work for the next 80 years 😛 , we could just make it dynamic.
changed the title [-]Can't use slash in debit card expiration date field on iPhone - Reported by @thesahindia[/-][+][HOLD for payment 2022-05-02] Can't use slash in debit card expiration date field on iPhone - Reported by @thesahindia[/+]on Apr 25, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.56-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
MelvinBot commentedon Dec 23, 2021
Triggered auto assignment to @sketchydroide (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.sketchydroide commentedon Dec 23, 2021
I see 2 ways to go about this:
/to the symbol keyboard/after the first 2 numbersWe coul potentially do both.
@Jag96 you seem to have worked on thid, any suggestion?
mallenexpensify commentedon Dec 23, 2021
From the Slack thread
mananjadhav commentedon Dec 24, 2021
Proposal
None of the keyboard types support '/' in addition to numbers. There's
numbers-and-punctuationbut it only works on iOS. I would recommend adding/automatically.Something on the following lines (not thoroughly tested):
and then
onChangeTextcallhandleExpiryDateChange.In addition to this, I have a small enhancement.
CardUtils.getYearFromExpirationDateStringwe're hardcoding20${cardYear}. While I know it'll work for the next 80 years 😛 , we could just make it dynamic.moment().format('YYYY').substring(0, 2)MelvinBot commentedon Dec 28, 2021
@sketchydroide Huh... This is 4 days overdue. Who can take care of this?
mallenexpensify commentedon Dec 28, 2021
@sketchydroide can you review @mananjadhav 's Proposal above when you're back? Thx
#6891 (comment)
MelvinBot commentedon Dec 30, 2021
@sketchydroide Still overdue 6 days?! Let's take care of this!
80 remaining items
[-]Can't use slash in debit card expiration date field on iPhone - Reported by @thesahindia[/-][+][HOLD for payment 2022-05-02] Can't use slash in debit card expiration date field on iPhone - Reported by @thesahindia[/+]melvin-bot commentedon Apr 25, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.56-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-05-02. 🎊
mallenexpensify commentedon Apr 30, 2022
@mananjadhav @parasharrajat @thesahindia Hired in Upwork, can you accept the offer please?
I'll pay on Wednesday, I'm off Mon/Tues
https://www.upwork.com/jobs/~01bcc8abfe9585856e
Julesssss commentedon May 5, 2022
Not overdue
mananjadhav commentedon May 5, 2022
@mallenexpensify Reminder on Upwork payment
mallenexpensify commentedon May 6, 2022
Thanks for the ping @mananjadhav .
@parasharrajat @thesahindia and @mananjadhav paid $250 each.