Skip to content

[Due for payment 2025-09-09] $125 Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY in src/libs/actions/Policy/Tag.ts #69021

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Aug 22, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2025
  3. tgolen commented on Aug 22, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added
    ReviewingHas a PR in review
    and removed on Aug 22, 2025
  6. 11 remaining items

  7. melvin-bot commented on Sep 9, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  8. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. self-assigned this
    on Sep 13, 2025
  10. allgandalf commented on Sep 13, 2025

    @allgandalf
    Contributor

    @allgandalf does not require payment (Contractor)

    Payment summary is wrong, I require payment via upwork for this job

  11. mallenexpensify commented on Sep 15, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @shubham1206agra due $125 via NewDot
    Contributor+: @allgandalf paid $125 via Upwork

    @allgandalf can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021967729509960833773

  12. allgandalf commented on Sep 16, 2025

    @allgandalf
    Contributor

    allgandalf can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021967729509960833773

    I accepted the offer, thanks!

  13. mallenexpensify commented on Sep 16, 2025

    @mallenexpensify
    Contributor

    @allgandalf can you try again? It shows the offer is still pending on my end. Thx
    https://www.upwork.com/jobs/~021967729509960833773

  14. allgandalf commented on Sep 16, 2025

    @allgandalf
    Contributor

    Oops, I used Upworks native app to accept the offer, seems like the button wasn't responsive, sorry for the trouble 🫣, should be all good now

  15. mallenexpensify commented on Sep 16, 2025

    @mallenexpensify
    Contributor

    Thx, paid! Payment summary updated above. Should be all good here

  16. twisterdotcom commented on Sep 26, 2025

    @twisterdotcom
    Contributor

    @shubham1206agra has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-a2f6-abda-9ba7-3dfe962a2a21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions