You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-12] Chat - Missing placeholder text in the composer and search field #69048
Version Number: 9.1.98-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#67743 Email or phone of affected tester (no customers):sdhshssdjiosdndjs@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Chat Report View
Action Performed:
Go to staging.new.expensify.com
Open any report.
Open search router.
Expected Result:
Composer will show "Write something" placeholder text.
Search field will show "Search for someting" placeholder text.
Actual Result:
Composer and search field are missing placeholder text.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I wouldn't count this as a regression of our PR, but of Implement code and pre blocks support on web's PR, as for who should handle that IMO the PRs author and we could either:
have offending PR author open and merge a follow-up react-native-live-markdown PR fixing the issue and then bump the E/App react-native-live-markdown version to the new one including the fix
As for the RCA of this issue, refer to this comment.
I'm about to go on vacation and am not working on this issue, but I just wanted to ask, to whoever works on this, can we please create unit tests as part of the solution to this issue? This is something that I think really should've been covered by unit tests. Rendering the correct placeholder text should be something that we can assert via Jest pretty easily, and if it's not easy we should use this as an opportunity to think about how we could make it easier.
@mountiny Makes sense. I dropped a comment on our issue which bumped the RNLM version to let the contributor know that this shouldn't count a regression of their work.
Noted in the comment that due to this deploy blocker / revert, payments for our work will most likely be delayed until the version is bumped again (including the placeholder fix). Also who should open this PR, the offending RNLM PR author or us who opened it initially ?
❓ What do you think we should do in the future in case of similar situations with RNLM where there are other PRs in-between versions, but those PRs did not actually originate from an E/App issue, but rather new features / fixes directly in the RNLM library like PR Implement code and pre blocks support on web did, so we can avoid such inconveniences in the future ?
should this always fall on the contributor / C+ reviewer who is performing the E/App version bump to test all PRs in-between the versions even though they didn't author them and they don't originate from E/App issues (no testing steps) ?
besides the requirement to always add unit tests for such changes, should direct RNLM PRs (features / fixes) authors always manually test their changes on E/App before merging the RNLM PR ?
besides the requirement to always add unit tests for such changes, should direct RNLM PRs (features / fixes) authors always manually test their changes on E/App before merging the RNLM PR ?
Yes they should test it in the App I think as that is the core usage of the library
should this always fall on the contributor / C+ reviewer who is performing the E/App version bump to test all PRs in-between the versions even though they didn't author them and they don't originate from E/App issues (no testing steps) ?
I think that, ideally, same as Onyx, the library is always bumped in App after each PR within the library; however, if not done, then it makes sense for the contributor who is bumping the library that includes other changes, not just theirs, to also test whatever is included in the changelog. I know it is not their change; however, you cannot just ignore it as it will add us more work later. We can discuss increasing payment for it in such cases, but it is not showing a careful approach to the PR if the full changelog was not considered in the bump PR.
changed the title [-]Chat - Missing placeholder text in the composer and search field[/-][+][Due for payment 2025-09-12] Chat - Missing placeholder text in the composer and search field[/+]on Sep 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.1-20 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mountiny@sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Aug 22, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 22, 2025
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 22, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 22, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
blimpich commentedon Aug 22, 2025
Relevant conversation here: https://expensify.slack.com/archives/C049HHMV9SM/p1755884247194659
ikevin127 commentedon Aug 22, 2025
RCA breakdown from the Slack 🧵:
I remember looking at the
react-native-live-markdownPRs in between versions0.1.299and0.1.301and PR: Implement code and pre blocks support on web authored by @BartoszGrajdek was one of the in-between versions PR, my error is that I didn't think to ask about / test those PRs behaviour in E/App to check whether there would be regressions coming from them - I keept things within scope, only testing our PR: Fix/68518 - Strike through is not applied for quote markdown text behaviour.I wouldn't count this as a regression of our PR, but of Implement code and pre blocks support on web's PR, as for who should handle that IMO the PRs author and we could either:
react-native-live-markdownversion back to0.1.299to unblock deploy // optionally applying patch of PR: Fix/68518 - Strike through is not applied for quote markdown text to maintain the fix untillreact-native-live-markdownis fixedAs for the RCA of this issue, refer to this comment.
blimpich commentedon Aug 22, 2025
Thank you for the breakdown Kevin!
I'm about to go on vacation and am not working on this issue, but I just wanted to ask, to whoever works on this, can we please create unit tests as part of the solution to this issue? This is something that I think really should've been covered by unit tests. Rendering the correct placeholder text should be something that we can assert via Jest pretty easily, and if it's not easy we should use this as an opportunity to think about how we could make it easier.
8 remaining items
ikevin127 commentedon Aug 23, 2025
@mountiny Makes sense. I dropped a comment on our issue which bumped the RNLM version to let the contributor know that this shouldn't count a regression of their work.
Noted in the comment that due to this deploy blocker / revert, payments for our work will most likely be delayed until the version is bumped again (including the placeholder fix). Also who should open this PR, the offending RNLM PR author or us who opened it initially ?
❓ What do you think we should do in the future in case of similar situations with RNLM where there are other PRs in-between versions, but those PRs did not actually originate from an E/App issue, but rather new features / fixes directly in the RNLM library like PR Implement code and pre blocks support on web did, so we can avoid such inconveniences in the future ?
mountiny commentedon Aug 23, 2025
Yes they should test it in the App I think as that is the core usage of the library
I think that, ideally, same as Onyx, the library is always bumped in App after each PR within the library; however, if not done, then it makes sense for the contributor who is bumping the library that includes other changes, not just theirs, to also test whatever is included in the changelog. I know it is not their change; however, you cannot just ignore it as it will add us more work later. We can discuss increasing payment for it in such cases, but it is not showing a careful approach to the PR if the full changelog was not considered in the bump PR.
[-]Chat - Missing placeholder text in the composer and search field[/-][+][Due for payment 2025-09-12] Chat - Missing placeholder text in the composer and search field[/+]melvin-bot commentedon Sep 5, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.1-20 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-12. 🎊
melvin-bot commentedon Sep 5, 2025
@mountiny @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]