Skip to content

[Due for payment 2025-09-17] [$250] Reports - Missing Submit button and Hold option after moving unreported expense to report #69058

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.98-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #63623
Email or phone of affected tester (no customers): sdjidsjsoisjdos@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense to the workspace chat.
  4. Go to Reports > Expenses.
  5. Select the expense via checkbox.
  6. Click on the dropdown button > Move expense.
  7. Select Remove from report.
  8. Select the expense via checkbox again.
  9. Click on the dropdown button > Move expense.
  10. Select the workspace report.
  11. Select the expense via checkbox.
  12. Click on the dropdown button.
  13. Open the expense row and close it.
  14. Now the expense row shows Submit button.

Expected Result:

In Step 10, after adding unreported expense to an open report, expense row will show Submit button.
In Step 12, Hold option will be shown in the menu.

Actual Result:

In Step 10, after adding unreported expense to an open report, expense row does not show Submit button.
In Step 12, Hold option is not shown.
In Step 14, after opening the expense thread, the expense row shows Submit button.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021960002375419881791
  • Upwork Job ID: 1960002375419881791
  • Last Price Increase: 2025-09-01
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2025
  2. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Aug 22, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. arosiclair commented on Aug 22, 2025

    @arosiclair
    Contributor

    I reproduced in v9.1.98-1 though this

    In Step 14, after opening the expense thread, the expense row shows Submit button.

    Did not work for me.

  7. arosiclair commented on Aug 22, 2025

    @arosiclair
    Contributor

    Could not reproduce in prod v9.1.97-5 since the move expense option does not display again after removing the expense from the report.

  8. arosiclair commented on Aug 22, 2025

    @arosiclair
    Contributor

    #68847 looks related, but reverting the PR locally did not fix the issue and only removed the option to move the expense a second time (similar to prod).

    I am going to demote this since this is not really a regression.

  9. 31 remaining items

  10. changed the title [-][$250] Reports - Missing Submit button and Hold option after moving unreported expense to report[/-] [+][Due for payment 2025-09-17] [$250] Reports - Missing Submit button and Hold option after moving unreported expense to report[/+] on Sep 10, 2025
  11. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.8-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-17. 🎊

    For reference, here are some details about the assignees on this issue:

    • @akinwale requires payment through NewDot Manual Requests
    • @nkdengineer requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    @akinwale @alexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. akinwale commented on Sep 17, 2025

    @akinwale
    Contributor

    BugZero Checklist:

    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A

    • [@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Launch Expensify.
    2. Go to workspace chat.
    3. Submit an expense to the workspace chat.
    4. Go to Reports > Expenses.
    5. Select the expense via checkbox.
    6. Click on the dropdown button > Move expense.
    7. Select Remove from report.
    8. Select the expense via checkbox again.
    9. Click on the dropdown button > Move expense.
    10. Select the workspace report.
    11. Verify that after the unreported expense has been added to an open report, the expense row will show a Submit button.

    Do we agree 👍 or 👎?

  15. melvin-bot commented on Sep 17, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@alexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1960002375419881791/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. alexpensify commented on Sep 18, 2025

    @alexpensify
    Contributor

    Payment Summary

    Contributor: @nkdengineer [pending] $250 via Upwork
    Contributor+: @akinwale due $250 via NewDot

  17. alexpensify commented on Sep 18, 2025

    @alexpensify
    Contributor
  18. garrettmknight commented on Sep 18, 2025

    @garrettmknight
    Contributor

    $250 approved for @akinwale

  19. nkdengineer commented on Sep 19, 2025

    @nkdengineer
    Contributor

    @alexpensify I've accepted.

  20. alexpensify commented on Sep 19, 2025

    @alexpensify
    Contributor

    All set, I've completed the payment to @nkdengineer via Upwork. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions