You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-17] [$250] Reports - Missing Submit button and Hold option after moving unreported expense to report #69058
Version Number: 9.1.98-0 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #63623 Email or phone of affected tester (no customers):sdjidsjsoisjdos@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense to the workspace chat.
Go to Reports > Expenses.
Select the expense via checkbox.
Click on the dropdown button > Move expense.
Select Remove from report.
Select the expense via checkbox again.
Click on the dropdown button > Move expense.
Select the workspace report.
Select the expense via checkbox.
Click on the dropdown button.
Open the expense row and close it.
Now the expense row shows Submit button.
Expected Result:
In Step 10, after adding unreported expense to an open report, expense row will show Submit button.
In Step 12, Hold option will be shown in the menu.
Actual Result:
In Step 10, after adding unreported expense to an open report, expense row does not show Submit button.
In Step 12, Hold option is not shown.
In Step 14, after opening the expense thread, the expense row shows Submit button.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
#68847 looks related, but reverting the PR locally did not fix the issue and only removed the option to move the expense a second time (similar to prod).
I am going to demote this since this is not really a regression.
changed the title [-][$250] Reports - Missing Submit button and Hold option after moving unreported expense to report[/-][+][Due for payment 2025-09-17] [$250] Reports - Missing Submit button and Hold option after moving unreported expense to report[/+]on Sep 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.8-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@akinwale@alexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Launch Expensify.
Go to workspace chat.
Submit an expense to the workspace chat.
Go to Reports > Expenses.
Select the expense via checkbox.
Click on the dropdown button > Move expense.
Select Remove from report.
Select the expense via checkbox again.
Click on the dropdown button > Move expense.
Select the workspace report.
Verify that after the unreported expense has been added to an open report, the expense row will show a Submit button.
Activity
melvin-bot commentedon Aug 22, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 22, 2025
Triggered auto assignment to @arosiclair (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 22, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 22, 2025
💬 A slack conversation has been started in #expensify-open-source
arosiclair commentedon Aug 22, 2025
I reproduced in v9.1.98-1 though this
Did not work for me.
arosiclair commentedon Aug 22, 2025
Could not reproduce in prod v9.1.97-5 since the move expense option does not display again after removing the expense from the report.
arosiclair commentedon Aug 22, 2025
#68847 looks related, but reverting the PR locally did not fix the issue and only removed the option to move the expense a second time (similar to prod).
I am going to demote this since this is not really a regression.
31 remaining items
[-][$250] Reports - Missing Submit button and Hold option after moving unreported expense to report[/-][+][Due for payment 2025-09-17] [$250] Reports - Missing Submit button and Hold option after moving unreported expense to report[/+]melvin-bot commentedon Sep 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.8-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Sep 10, 2025
@akinwale @alexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
akinwale commentedon Sep 17, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎?
melvin-bot commentedon Sep 17, 2025
Payment Summary
Upwork Job
BugZero Checklist (@alexpensify)
alexpensify commentedon Sep 18, 2025
Payment Summary
Contributor: @nkdengineer [pending] $250 via Upwork
Contributor+: @akinwale due $250 via NewDot
alexpensify commentedon Sep 18, 2025
@nkdengineer - Please accept the invite here:
https://www.upwork.com/jobs/~021960002375419881791
garrettmknight commentedon Sep 18, 2025
$250 approved for @akinwale
nkdengineer commentedon Sep 19, 2025
@alexpensify I've accepted.
alexpensify commentedon Sep 19, 2025
All set, I've completed the payment to @nkdengineer via Upwork. Closing!