You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-19] [$250] Dependent tags - Search field is shown in the tag list when there is less than 8 tags #69348
Version Number: 9.1.99-5 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod If this was caught during regression testing, add the test name, ID and link from TestRail:#69118 Email or phone of affected tester (no customers):sdhusdhbidshius@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Import dependent tags to the workspace using the file attached.
Go to staging.new.expensify.com
Go to workspace chat.
Click + > Create expense > Manual.
Enter amount > Next.
On confirm page, click Fund > Select Woodbridge : Operations.
Click GL > Select 91.
Click GL_DEPARTMENT_DESCRIPTION.
Expected Result:
There will be no search field in the tag list when there is less than 8 tags.
Actual Result:
Search field is shown in the tag list when there is less than 8 tags.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
The tag search field incorrectly appears when there are fewer than 8 tags available in the current context.
What is the root cause of that problem?
In multi-level tag systems, the search field shows even when a parent tag (e.g., "Woodbridge") has only 1 child tag, because the component was counting all policy tags instead of contextually filtered tags.
getCountOfEnabledTagsOfList(policyTagList.tags) counts ALL tags in the policy, not the tags available in the current selection context
Default parameter logic shouldShowTextInput = !!textInputLabel || !!textInputIconLeft overrides explicit props when textInputLabel is passed
What changes do you think we should make in order to solve the problem?
Instead of counting all policy tags, count the tags that are actually available to the user in the current context:
But since the tags are dependent, we have a slightly different logic: we display each subsequent tag after “:”. There were 6 tags at the first level, so their length is 6, at the second level there is 1, so the length remains 6, but at the third level their number increases and 6 more are added to each of the previous tags, resulting in 100 tags, but only 1 is displayed.
What changes do you think we should make in order to solve the problem?
We need to obtain the length of the elements that are actually displayed. To do this, we can count all the elements inside the data of each element:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Dependent tags - Search field is shown in the tag list when there is less than 8 tags[/-][+][Due for payment 2025-09-19] [$250] Dependent tags - Search field is shown in the tag list when there is less than 8 tags[/+]on Sep 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.12-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach@kadiealexander The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Unfortunately, I did not find a suitable PR
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Import dependent tags to the workspace using the file attached in the linked issue.
Test:
Go to workspace chat.
Click + > Create expense > Manual.
Enter amount > Next.
On the confirm page, click Fund > Select Woodbridge: Operations.
Activity
melvin-bot commentedon Aug 27, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 27, 2025
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 27, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 27, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
ShridharGoel commentedon Aug 27, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The tag search field incorrectly appears when there are fewer than 8 tags available in the current context.
What is the root cause of that problem?
In multi-level tag systems, the search field shows even when a parent tag (e.g., "Woodbridge") has only 1 child tag, because the component was counting all policy tags instead of contextually filtered tags.
getCountOfEnabledTagsOfList(policyTagList.tags)counts ALL tags in the policy, not the tags available in the current selection contextshouldShowTextInput = !!textInputLabel || !!textInputIconLeftoverrides explicit props whentextInputLabelis passedWhat changes do you think we should make in order to solve the problem?
Instead of counting all policy tags, count the tags that are actually available to the user in the current context:
Also, prevent BaseSelectionList default override by conditionally passing
textInputLabel:What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can add new tests to ensure that such scenarios of filtered tags are handled.
Eskalifer1 commentedon Aug 27, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Dependent tags - Search field is shown in the tag list when there is less than 8 tags
What is the root cause of that problem?
We display search results only if there are more than 8 items:
App/src/components/TagPicker/index.tsx
Lines 66 to 70 in ed4c640
But since the tags are dependent, we have a slightly different logic: we display each subsequent tag after “:”. There were 6 tags at the first level, so their length is 6, at the second level there is 1, so the length remains 6, but at the third level their number increases and 6 more are added to each of the previous tags, resulting in 100 tags, but only 1 is displayed.
What changes do you think we should make in order to solve the problem?
We need to obtain the length of the elements that are actually displayed. To do this, we can count all the elements inside the data of each element:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
samranahm commentedon Aug 27, 2025
Unable to produce
29 remaining items
[-][$250] Dependent tags - Search field is shown in the tag list when there is less than 8 tags[/-][+][Due for payment 2025-09-19] [$250] Dependent tags - Search field is shown in the tag list when there is less than 8 tags[/+]melvin-bot commentedon Sep 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.12-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Sep 12, 2025
@ZhenjaHorbach @kadiealexander The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ZhenjaHorbach commentedon Sep 19, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Unfortunately, I did not find a suitable PR
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Sep 19, 2025
Payment Summary
Upwork Job
BugZero Checklist (@kadiealexander)
kadiealexander commentedon Sep 22, 2025
@ShridharGoel please accept the Upwork offer.
ZhenjaHorbach commentedon Sep 24, 2025
Requested in ND!
flaviadefaria commentedon Oct 2, 2025
$250 approved for @ZhenjaHorbach