You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ping deployers if PR is merged with failing lint rules #7026
Confirm that lint passes before attempting staging deploy
Actual Result:
Staging is broken
The issue occurred in #6819 (comment), we should investigate a way to prevent deploying code w/ failing lint to staging/production and ping mobile deployers.
I like both of those ideas. Creating a deploy blocker issue to prevent deploys seems like a nice improvement. For running additional checks I think e2e might be overkill but adding lint/unit tests/verify podfile seem like good checks to have. I'm thinking these would happen before we create a new version in the preDeploy.yml workflow, but I'll confirm that's the best spot for these.
Activity
AndrewGable commentedon Jan 4, 2022
I have a few questions:
Jag96 commentedon Jan 6, 2022
I like both of those ideas. Creating a deploy blocker issue to prevent deploys seems like a nice improvement. For running additional checks I think e2e might be overkill but adding lint/unit tests/verify podfile seem like good checks to have. I'm thinking these would happen before we create a new version in the preDeploy.yml workflow, but I'll confirm that's the best spot for these.
Jag96 commentedon Jan 13, 2022
Haven't gotten to test my changes, been dealing with deploy failures all week. Will continue on this once the deploy is fixed.
Jag96 commentedon Jan 21, 2022
Still haven't gotten to this, posting the diff I was using for testing:
AndrewGable commentedon Feb 8, 2022
I'll look into this one very soon!