Skip to content

[Due for payment 2025-09-22] Expense - Two expense previews appear briefly after merging with split #70351

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.9-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #68204
Email or phone of affected tester (no customers): sdjnoisjoijoisdnjio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Open expense report.
  5. Click More > Split.
  6. Click Save,
  7. Select an expense via checkbox.
  8. Click More > Merge.
  9. Select the other split > Continue.
  10. Click Merge expenses.

Expected Result:

The merged expense will appear immediately after merging with split.

Actual Result:

Two expense previews appear briefly after merging with split.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 11, 2025
  2. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Sep 11, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. hoangzinh commented on Sep 11, 2025

    @hoangzinh
    Contributor

    Should we demote this DB? @youssef-lr @dominictb

  7. dominictb commented on Sep 11, 2025

    @dominictb
    Contributor

    Merging splits will be handled as follow-up in #70373. Can be demoted cc @youssef-lr @garrettmknight

  8. 25 remaining items

  9. hoangzinh commented on Sep 11, 2025

    @hoangzinh
    Contributor

    @francoisl, here is a quick summary of this issue:

    • Root cause: In mergeTransactionRequest action, we haven't optimistically marked the report action of the source expense as deleted, similar to when we delete an expense

      App/src/libs/actions/IOU.ts

      Lines 8252 to 8256 in 3bffea2

      {
      onyxMethod: Onyx.METHOD.MERGE,
      key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport?.reportID}`,
      value: updatedReportAction,
      },
    • I fixed it in this commit 74a355c
    Screen.Recording.2025-09-12.at.02.27.27.mov

    Feel free to test it again.

  10. francoisl commented on Sep 11, 2025

    @francoisl
    Contributor

    Fixed on v9.2.12-3

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 15, 2025
  12. changed the title [-]Expense - Two expense previews appear briefly after merging with split[/-] [+][Due for payment 2025-09-22] Expense - Two expense previews appear briefly after merging with split[/+] on Sep 15, 2025
  13. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.13-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-22. 🎊

  15. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    @francoisl @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions