Skip to content

Expense - App crashes after approving report containing two non-reimbursable expenses #70359

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.9-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-749/folder/13176730/41237117/889705672
Email or phone of affected tester (no customers): sdiosjndosjdois@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two non-reimbursable expenses.
  4. Open the expense report.
  5. Click on the header subtitle to return to workspace chat.
  6. Click Submit.
  7. Click Approve.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6941191_1757572752741!staging.new.expensify.com-1757572656027.txt

Bug6941191_1757572752735.Screen_Recording_2025-09-11_at_14.36.01.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Sep 11, 2025
  2. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Sep 11, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. inimaga commented on Sep 11, 2025

    @inimaga
    Contributor

    Potentially caused by #67752.
    Investigating... 👀

  7. inimaga commented on Sep 11, 2025

    @inimaga
    Contributor

    Okay confirmed that the mentioned PR is responsible.

  8. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. removed
    DeployBlockerIndicates it should block deploying the API
    on Sep 11, 2025
  10. francoisl commented on Sep 11, 2025

    @francoisl
    Contributor

    No longer reproducible on staging after CP, demoting.

  11. inimaga commented on Sep 11, 2025

    @inimaga
    Contributor

    Going to close as resolved but @dmkt9 do keep this possible regression in mind in your follow up PR.

    cc: @dominictb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions