Skip to content

[Due for payment 2025-11-10] [$500] Clean up report page styles #70369

Closed

Description

@shawnborton

Now that we have collapsible rows on the Reports page, we want to take a moment to clean up some of the styles. Right now, especially on mobile, the table style feels quite heavy and unbalanced:

Image

So we'd like to adjust some styles to:

  • use a consistent normal text weight for titles and totals
  • on mobile, reduce the size of the From/To avatar, reduce the font weight, and make it so that the From/To is at the top of the row
  • use an "extra small" button size on mobile - this will bring the buttons from 28px -> 20px tall

The result is this:

CleanShot.2025-09-10.at.11.28.20.mp4

More in depth mocks for posterity:

Image Image Image Image Image

cc @Expensify/design to make sure we're good with the above changes, cc @Expensify/product-pr for extra eyes too

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021966100442552984512
  • Upwork Job ID: 1966100442552984512
  • Last Price Increase: 2025-11-05
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @brianlee-expensify

Activity

  1. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Current assignee @shawnborton is eligible for the Design assigner, not assigning anyone new.

  2. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Triggered auto assignment to @brianlee-expensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO. Remember to draft any necessary HelpDot updates by following the instructions here.

  3. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Current assignee @shawnborton is eligible for the NewFeature assigner, not assigning anyone new.

  5. mohammadjafarinejad commented on Sep 11, 2025

    @mohammadjafarinejad
    Contributor

    @shawnborton Is this open for contributors?

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 11, 2025
  7. changed the title [-]Clean up report page styles[/-] [+][$250] Clean up report page styles[/+] on Sep 11, 2025
  8. 80 remaining items

  9. danielrvidal commented on Nov 11, 2025

    @danielrvidal
    Contributor

    Woo, great work everyone!

    we still need the BugZero checklist completed by @getusha or @Krishna2323, and to confirm whether we need a regression test?

    For this one, I think @JS00001 and I talked and we think we'd add a test to make sure the > works so @Krishna2323 could you make sure that gets added?

  10. getusha commented on Nov 11, 2025

    @getusha
    Contributor

    Regression Test Proposal

    1. Open app
    2. Navigate to Reports > Expenses
    3. Verify that the title, totals and other texts have consistent text weight
    4. Resize the window to mobile size
    5. Verify that the action buttons are extra small
    6. Verify that the From/To is at the top of the row
    7. Change the tab to Reports
    8. Repeat step 3 - 6 and verify it matches the design below as well
    9. Press the Expenses tab
    10. Click on the arrow on the right of the Submit/Pay button on the workspace expense
    11. Verify it opens the expense detail view
    Image Image

    This one is a bit tricky @JS00001 @Krishna2323 LMK if you guys wanna add more

  11. getusha commented on Nov 11, 2025

    @getusha
    Contributor

    @getusha would you be able to do the checklist and just confirm that you don't need to be paid via the old method for this, please?

    I actually get paid via the regular process for the work I did as a C+, since it was before I joined the BE team. However, @Krishna2323 did a lot more work with the design team and I am okay with the regular amount. ❤️

  12. JS00001 commented on Nov 11, 2025

    @JS00001
    Contributor

    This one is a bit tricky @JS00001 @Krishna2323 LMK if you guys wanna add more

    I think we also added the > Icon to expenses to view them right? There was a regression QA caught where if you clicked it, it submitted the action, so can we add a test to ensure the > icon opens the expenses?

  13. JS00001 commented on Nov 11, 2025

    @JS00001
    Contributor

    I actually get paid via the regular process for the work I did as a C+, since it was before I joined the BE team

    I didnt know this, if so, then you should get the same amount, just let us know what you need from us, I'm not too familiar with all of the ways contributors get paid

  14. getusha commented on Nov 12, 2025

    @getusha
    Contributor

    I didnt know this, if so, then you should get the same amount, just let us know what you need from us, I'm not too familiar with all of the ways contributors get paid

    Just the summary i haven't been removed from the C+ team yet because of a pending project.

  15. getusha commented on Nov 12, 2025

    @getusha
    Contributor

    I think we also added the > Icon to expenses to view them right? There was a regression QA caught where if you clicked it, it submitted the action, so can we add a test to ensure the > icon opens the expenses?

    Added the steps @JS00001

  16. brianlee-expensify commented on Nov 12, 2025

    @brianlee-expensify
    Contributor

    thanks @RachCHopkins for chiming in while i was out! reassigned back to me so i can take the final steps:

  17. JS00001 commented on Nov 13, 2025

    @JS00001
    Contributor

    Yep, sounds right to me!

  18. brianlee-expensify commented on Nov 13, 2025

    @brianlee-expensify
    Contributor

    Payment Summary

    Contributor: @Krishna2323 due $500 via NewDot
    Contributor+: @getusha due $500 via NewDot

  19. Krishna2323 commented on Nov 13, 2025

    @Krishna2323
    Contributor

    Requested in ND.

  20. quinthar commented on Nov 19, 2025

    @quinthar
    Contributor

    Approved $500 to @getusha

  21. quinthar commented on Nov 19, 2025

    @quinthar
    Contributor

    Approved $500 to @Krishna2323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions