Skip to content

[Backward Compatibility] Expenses amounts imported from a personal card cannot be edited in NewDot #70487

Closed

Description

@garrettmknight

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation (hyperlinked to channel name): migrate

Action Performed:

  1. Import a personal card in Classic via Settings > Account > Wallet > Add Bank/Card (you can use this SO)
  2. Open one of the imported expenses
  • Note that you can edit the amount in Classic
  1. Switch to NewDot
  2. Open up one of the imported expenses
  3. Try to change the amount

Expected Result:

You should be able to edit the amount on an imported personal card expense in NewDot.

Actual Result:

We let you attempt to change the amount, but when you save, it shows an error: Amount or currency of imported transaction cannot be updated

This also affects changing amounts by splitting and merging personal card expenses.

Workaround:

They can edit/split/merge in Classic.

Platforms:

Select the officially supported platforms where the issue was reproduced:
All

Screenshots/Videos

Add any screenshot/video evidence Image

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 12, 2025
  2. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. changed the title [-]Expenses amounts imported from a personal card cannot be edited in NewDot[/-] [+][Backward Compatibility] Expenses amounts imported from a personal card cannot be edited in NewDot[/+] on Sep 12, 2025
  4. garrettmknight commented on Sep 15, 2025

    @garrettmknight
    ContributorAuthor

    @johncschuster think this one's gonna be internal.

  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Sep 15, 2025
  6. moved this to Second Cohort - MEDIUM or LOW in [#whatsnext] #migrateon Sep 15, 2025
  7. johncschuster commented on Sep 15, 2025

    @johncschuster
    Contributor
  8. self-assigned this
    on Sep 16, 2025
  9. added and removed on Sep 16, 2025
  10. 30 remaining items

  11. tgolen commented on Jan 1, 2026

    @tgolen
    Contributor

    Thank you for confirming the problem still exists @m-natarajan!

    @youssef-lr is this something you would be able to look into if you're familiar with it?

  12. youssef-lr commented on Jan 1, 2026

    @youssef-lr
    Contributor

    I can if it can wait? I'm going OOO for 2 weeks next week.

  13. tgolen commented on Jan 1, 2026

    @tgolen
    Contributor

    That should probably be OK, but if you do have some context around this, it would be helpful if you could add anything to this issue to help someone else look into it while you're gone.

  14. youssef-lr commented on Jan 1, 2026

    @youssef-lr
    Contributor

    I think we have a check somewhere that prevents editing any type of card expenses. We need to update it to only prevent editing managed cards (ECard or imported company card).

  15. youssef-lr commented on Jan 1, 2026

    @youssef-lr
    Contributor

    We need to prevent editing only if the card is managed https://github.com/Expensify/Auth/blob/23919959a1b4bc01b22ba5d1156937b33f493408/auth/lib/Transaction.cpp#L1909 (has a fundID, transactions from a personal card won't have it)

  16. youssef-lr commented on Jan 1, 2026

    @youssef-lr
    Contributor

    I just made the PR.

  17. self-assigned this
    on Jan 1, 2026
  18. removed their assignment
    on Jan 6, 2026
  19. changed the title [-][HOLD Expensify/issues/549812] [Backward Compatibility] Expenses amounts imported from a personal card cannot be edited in NewDot[/-] [+][Backward Compatibility] Expenses amounts imported from a personal card cannot be edited in NewDot[/+] on Jan 6, 2026
  20. melvin-bot commented on Jan 13, 2026

    @melvin-bot

    @johncschuster, @youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  21. youssef-lr commented on Jan 19, 2026

    @youssef-lr
    Contributor

    This is fixed.

  22. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions