Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.2.13-1
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ikevin127
Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
- Login with a new account, create a workspace and go to workspace settings > Company cards.
- Click Add cards and proceed to add a Direct feed card by either using a real card from one of the bank options or click Other to add a faux BA via Plaid flow (only on staging server).
- Once BA flow is completed, on the Statement close date RHP click Submit to complete BA addition.
- On the Company cards page, click [+] Assign card and assign card to yourself > on Choose a transaction start date step keep default (From the beginning) > click Assign card.
- Navigate to Reports page, click Expenses and verify that you see multiple expenses originating from the company card assigned in the previous step.
- Navigate to workspace settings > Company cards and click Settings > Remove card feed and confirm Delete.
- Navigate to Reports page.
Expected Result:
The app should not crash.
Actual Result:
The app crashes.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Screen.Recording.2025-09-12.at.17.28.28.mov
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021967598674017384654
- Upwork Job ID: 1967598674017384654
- Last Price Increase: 2025-09-22
Issue Owner
Current Issue Owner: @twisterdotcomMetadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Sep 13, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.m-natarajan commentedon Sep 13, 2025
Proposal by @ikevin127
Proposal
Please re-state the problem that we are trying to solve in this issue
App crashes on Reports page after removing direct feed with assigned card transactions.
What is the root cause of that problem?
The crash is coming from the
getBankNamefunction and it happens because we're missing optional chaining on thefeedTypevalue which is missing / undefined upon removing direct card feed with assigned card transactions.Here's a detailed chain of events leading to the crash:
EReceipt.tsxcomponentEReceipt.tsxcomponent callsgetCardDescriptionon this linegetCardDescriptionfunction calls thegetBankNamefunctionfeedTypevalue is missing / undefined because the card feed was removedfeedTypevalueWhat changes do you think we should make in order to solve the problem?
Add optional chaining for the
feedTypevalue on both lines (line 1 and line 2):What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Add missing test for the
getBankNamefunction here to verify that whenfeedTypeis not passed / undefined, the function won't throw error, but instead returnundefined.[-]Reports - App crashes after removing direct feed with assigned card transactions[/-][+][$250] Reports - App crashes after removing direct feed with assigned card transactions[/+]melvin-bot commentedon Sep 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021967598674017384654
melvin-bot commentedon Sep 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)jjcoffee commentedon Sep 17, 2025
@ikevin127's proposal makes sense to me!
🎀👀🎀 C+ reviewed
melvin-bot commentedon Sep 17, 2025
Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
10 remaining items
[-][$250] Reports - App crashes after removing direct feed with assigned card transactions[/-][+][Due for payment 2025-10-01] [$250] Reports - App crashes after removing direct feed with assigned card transactions[/+]melvin-bot commentedon Sep 24, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 24, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.17-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
getBankNamefunction onfeedType#71039If no regressions arise, payment will be issued on 2025-10-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Sep 24, 2025
@jjcoffee / @ikevin127 @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jjcoffee commentedon Oct 1, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/53122/files#r2394945279
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/553335
Regression Test Proposal
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Oct 1, 2025
Payment Summary
Upwork Job
BugZero Checklist (@twisterdotcom)
JmillsExpensify commentedon Oct 6, 2025
$250 approved for @ikevin127
garrettmknight commentedon Oct 7, 2025
$250 approved for @jjcoffee