Skip to content

[Due for payment 2026-01-05] [Due for payment 2025-12-30] [$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite #70746

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.15-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-825/folder/13176904/41237411/899329695
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 16 pro/ 18.6.2
App Component: Other

Action Performed:

Precondition: Create a control workspace enable Accounting

  1. Open app
  2. Go to workspace at precondition
  3. Tap Accounting
  4. Tap on Connect of NetSuite
  5. Tap Next to NetSuite set up
  6. Type something on account ID
  7. Type something on Token ID
  8. Type something on Token Secret
  9. Slide up screen for see Confirm button

Expected Result:

Confirm button should display without visual error

Actual Result:

Confirm button is cut off for some first time slide up screen

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4
ScreenRecording_09-17-2025.14-16-36_1.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021968396598761544429
  • Upwork Job ID: 1968396598761544429
  • Last Price Increase: 2025-09-24
  • Automatic offers:
    • abzokhattab | Contributor | 108921696
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @sonialiap
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 17, 2025
  2. melvin-bot commented on Sep 17, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. abzokhattab commented on Sep 17, 2025

    @abzokhattab
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-09-24 17:35:06 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The Confirm button is cut off at the bottom of the NetSuite setup screen on iOS devices when users enter their credentials.

    What is the root cause of that problem?

    • The ConnectionLayout inside NetSuiteTokenInputPage uses shouldUseScrollView={true} by default, creating nested ScrollViews where the inner ScrollView doesn't inherit proper safe area padding from the outer one
    • The FormProvider component in NetSuiteTokenInputForm explicitly sets addBottomSafeAreaPadding={false}, preventing the submit button from getting proper safe area padding on iOS

    What changes do you think we should make in order to solve the problem?

    • Add shouldUseScrollView={SubStep !== NetSuiteTokenInputForm} to the ConnectionLayout in NetSuiteTokenInputPage to prevent nested ScrollView issues on the form page
    • change addBottomSafeAreaPadding={false} in the FormProvider in NetSuiteTokenInputForm to be true
    • This follows the same pattern used by other working NetSuite forms like NetSuiteCustomFormIDPage

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

  4. daledah commented on Sep 17, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Confirm button is cut off for some first time slide up screen

    What is the root cause of that problem?

    In NetSuiteTokenInputPage component, we are using ConnectionLayout with shouldUseScrollView props as true by default, which creates nested ScrollViews

    <ConnectionLayout
    displayName={NetSuiteTokenInputPage.displayName}
    headerTitle="workspace.netsuite.tokenInput.title"
    accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.CONTROL]}
    policyID={policyID}
    featureName={CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED}
    contentContainerStyle={[styles.flex1]}
    titleStyle={styles.ph5}
    connectionName={CONST.POLICY.CONNECTIONS.NAME.NETSUITE}
    onBackButtonPress={handleBackButtonPress}
    shouldLoadForEmptyConnection={isEmptyObject(policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE])}
    shouldBeBlocked={shouldPageBeBlocked}
    >

    What changes do you think we should make in order to solve the problem?

    We simply add props shouldUseScrollView={false}

    We can check other places that has the same nested ScrollViews

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. ryntgh commented on Sep 17, 2025

    @ryntgh
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Confirm button is being cut off when users paste NetSuite credentials in the token input form

    What is the root cause of that problem?

    ConnectionLayout has shouldUseScrollView (true by default) and FormProvider also creates its own ScrollView (true by default). This creates nested ScrollViews with the same orientation, which causes layout issues where the inner content doesn't properly calculate its height

    <ConnectionLayout
    displayName={NetSuiteTokenInputPage.displayName}
    headerTitle="workspace.netsuite.tokenInput.title"
    accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.CONTROL]}
    policyID={policyID}
    featureName={CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED}
    contentContainerStyle={[styles.flex1]}
    titleStyle={styles.ph5}
    connectionName={CONST.POLICY.CONNECTIONS.NAME.NETSUITE}
    onBackButtonPress={handleBackButtonPress}
    shouldLoadForEmptyConnection={isEmptyObject(policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE])}
    shouldBeBlocked={shouldPageBeBlocked}
    >

    <FormProvider
    formID={ONYXKEYS.FORMS.NETSUITE_TOKEN_INPUT_FORM}
    style={styles.flexGrow1}
    validate={validate}
    onSubmit={connectPolicy}
    submitButtonText={translate('common.confirm')}
    shouldValidateOnBlur
    shouldValidateOnChange
    addBottomSafeAreaPadding={false}
    >

    What changes do you think we should make in order to solve the problem?

    We should add shouldUseScrollView={false} to the FormProvider in NetSuiteTokenInputForm to prevent it from creating its own ScrollView

                    shouldUseScrollView={false}

    <FormProvider
    formID={ONYXKEYS.FORMS.NETSUITE_TOKEN_INPUT_FORM}
    style={styles.flexGrow1}
    validate={validate}
    onSubmit={connectPolicy}
    submitButtonText={translate('common.confirm')}
    shouldValidateOnBlur
    shouldValidateOnChange
    addBottomSafeAreaPadding={false}
    >

    We should not add this prop to the ConnectionLayout in NetSuiteTokenInputPage because it will make the button missing bottom padding, sinceConnectionLayout component wraps the step content in a ScrollView with addBottomSafeAreaPadding={true}

    {shouldUseScrollView ? (
    <ScrollView
    contentContainerStyle={contentContainerStyle}
    addBottomSafeAreaPadding
    >

    Adding the prop to ConnectionLayout in NetSuiteTokenInputPage will cause the button to collide with the offline message indicator

    Missing bottom padding Image Image

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    N/A

  6. self-assigned this
    on Sep 17, 2025
  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 17, 2025
  8. melvin-bot commented on Sep 17, 2025

    @melvin-bot
  9. changed the title [-]iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/-] [+][$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/+] on Sep 17, 2025
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 17, 2025
  11. melvin-bot commented on Sep 17, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

  12. dmkt9 commented on Sep 18, 2025

    @dmkt9
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Confirm button is cut off for some first time slide up screen

    What is the root cause of that problem?

    1. In NetSuiteTokenInputForm, the component uses FormProvider, which by default wraps its content in a ScrollView.

    2. Additionally, NetSuiteTokenInputPage uses ConnectionLayout as its container, and ConnectionLayout has a default prop shouldUseScrollView = true, which means it also wraps its children in a ScrollView :

      shouldUseScrollView = true,

    3. This results in two nested ScrollViews, which causes the inner one to lose its scroll functionality—leading to the current issue.

    What changes do you think we should make in order to solve the problem?

    To resolve this, we need to eliminate the nested ScrollView while still ensuring "BottomSafeAreaPadding" is preserved.

    1. Disable the outer ScrollView: Pass shouldUseScrollView={false} to ConnectionLayout inside NetSuiteTokenInputPage:

      shouldUseScrollView={false}

      Note: After reviewing all usages of ConnectionLayout, it appears that shouldUseScrollView is consistently passed as false. Therefore, we should consider changing its default value to false, encouraging developers to explicitly opt-in when needed.

    2. Add a wrapper component to preserve "BottomSafeAreaPadding": Create a new Container component that uses useBottomSafeSafeAreaPaddingStyle, similar to how it's used in ScrollView here:

      function Container({contentContainerStyle, children}: {contentContainerStyle?: StyleProp<ViewStyle> | undefined; children: React.ReactNode}) {
          const bottomSafeAreaPaddingStyle = useBottomSafeSafeAreaPaddingStyle({
              addBottomSafeAreaPadding: true,
              style: contentContainerStyle,
          });
          return <View style={bottomSafeAreaPaddingStyle}>{children}</View>;
      }

      Note: This is necessary to retain the benefits of ScreenWrapper inside ConnectionLayout.

    3. Replace the existing View with the new Container:

      <View style={contentContainerStyle}>{renderSelectionContent}</View>

      <Container contentContainerStyle={contentContainerStyle}>{renderSelectionContent}</Container>

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

    result.mp4
  13. 55 remaining items

  14. changed the title [-][Due for payment 2025-12-30] [$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/-] [+][Due for payment 2026-01-05] [Due for payment 2025-12-30] [$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/+] on Dec 29, 2025
  15. melvin-bot commented on Dec 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.87-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-05. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Dec 29, 2025

    @melvin-bot

    @Pujan92 / @abzokhattab @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. melvin-bot commented on Jan 1, 2026

    @melvin-bot

    @sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  18. Pujan92 commented on Jan 5, 2026

    @Pujan92
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/44661/changes#r2660321079

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/584151

    Regression Test Proposal

    Precondition: Create a control workspace and enable Accounting

    1. Go to workspace
    2. Tap Accounting
    3. Tap on Connect to NetSuite
    4. Tap Next to NetSuite set up (4 times to reach credentials form)
    5. Ensure that Steps are highlighted correctly when going connection flow with Netsuite
    6. Type something on Account ID
    7. Slide up the screen to see Confirm button
    8. Validate that: Scrolling is working and you can see the Confirm button
    Zapier Logs Run ID: 00040eee-29ae-a619-9b2a-5ac6e499d7a4
  19. sonialiap commented on Jan 5, 2026

    @sonialiap
    Contributor

    Payment summary:
    @Pujan92 $250 please request in NewDot
    @abzokhattab $250 please request in NewDot

  20. twisterdotcom commented on Jan 5, 2026

    @twisterdotcom
    Contributor

    @abzokhattab has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-ca7b-a93c-2f25-995d04ffaaf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions