You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-05] [Due for payment 2025-12-30] [$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite #70746
Version Number: v9.2.15-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:https://test-management.browserstack.com/projects/2219752/test-runs/TR-825/folder/13176904/41237411/899329695 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: iPhone 16 pro/ 18.6.2 App Component: Other
Action Performed:
Precondition: Create a control workspace enable Accounting
Open app
Go to workspace at precondition
Tap Accounting
Tap on Connect of NetSuite
Tap Next to NetSuite set up
Type something on account ID
Type something on Token ID
Type something on Token Secret
Slide up screen for see Confirm button
Expected Result:
Confirm button should display without visual error
Actual Result:
Confirm button is cut off for some first time slide up screen
🚨 Edited by proposal-police: This proposal was edited at 2025-09-24 17:35:06 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Confirm button is cut off at the bottom of the NetSuite setup screen on iOS devices when users enter their credentials.
What is the root cause of that problem?
The ConnectionLayout inside NetSuiteTokenInputPage uses shouldUseScrollView={true} by default, creating nested ScrollViews where the inner ScrollView doesn't inherit proper safe area padding from the outer one
The FormProvider component in NetSuiteTokenInputForm explicitly sets addBottomSafeAreaPadding={false}, preventing the submit button from getting proper safe area padding on iOS
What changes do you think we should make in order to solve the problem?
Add shouldUseScrollView={SubStep !== NetSuiteTokenInputForm} to the ConnectionLayout in NetSuiteTokenInputPage to prevent nested ScrollView issues on the form page
change addBottomSafeAreaPadding={false} in the FormProvider in NetSuiteTokenInputForm to be true
This follows the same pattern used by other working NetSuite forms like NetSuiteCustomFormIDPage
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
What changes do you think we should make in order to solve the problem?
We simply add props shouldUseScrollView={false}
We can check other places that has the same nested ScrollViews
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
Confirm button is being cut off when users paste NetSuite credentials in the token input form
What is the root cause of that problem?
ConnectionLayout has shouldUseScrollView (true by default) and FormProvider also creates its own ScrollView (true by default). This creates nested ScrollViews with the same orientation, which causes layout issues where the inner content doesn't properly calculate its height
We should not add this prop to the ConnectionLayout in NetSuiteTokenInputPage because it will make the button missing bottom padding, sinceConnectionLayout component wraps the step content in a ScrollView with addBottomSafeAreaPadding={true}
changed the title [-]iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/-][+][$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/+]on Sep 17, 2025
Please re-state the problem that we are trying to solve in this issue.
Confirm button is cut off for some first time slide up screen
What is the root cause of that problem?
In NetSuiteTokenInputForm, the component uses FormProvider, which by default wraps its content in a ScrollView.
Additionally, NetSuiteTokenInputPage uses ConnectionLayout as its container, and ConnectionLayout has a default prop shouldUseScrollView = true, which means it also wraps its children in a ScrollView :
Note: After reviewing all usages of ConnectionLayout, it appears that shouldUseScrollView is consistently passed as false. Therefore, we should consider changing its default value to false, encouraging developers to explicitly opt-in when needed.
Add a wrapper component to preserve "BottomSafeAreaPadding": Create a new Container component that uses useBottomSafeSafeAreaPaddingStyle, similar to how it's used in ScrollViewhere:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][Due for payment 2025-12-30] [$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/-][+][Due for payment 2026-01-05] [Due for payment 2025-12-30] [$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/+]on Dec 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.87-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Pujan92 / @abzokhattab@sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Sep 17, 2025
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.abzokhattab commentedon Sep 17, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-09-24 17:35:06 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Confirm button is cut off at the bottom of the NetSuite setup screen on iOS devices when users enter their credentials.
What is the root cause of that problem?
NetSuiteTokenInputPageusesshouldUseScrollView={true}by default, creating nested ScrollViews where the inner ScrollView doesn't inherit proper safe area padding from the outer oneNetSuiteTokenInputFormexplicitly setsaddBottomSafeAreaPadding={false}, preventing the submit button from getting proper safe area padding on iOSWhat changes do you think we should make in order to solve the problem?
shouldUseScrollView={SubStep !== NetSuiteTokenInputForm}to the ConnectionLayout inNetSuiteTokenInputPageto prevent nested ScrollView issues on the form pageaddBottomSafeAreaPadding={false}in theFormProviderin NetSuiteTokenInputForm to betrueNetSuiteCustomFormIDPageWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
daledah commentedon Sep 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Confirm button is cut off for some first time slide up screen
What is the root cause of that problem?
In
NetSuiteTokenInputPagecomponent, we are usingConnectionLayoutwithshouldUseScrollViewprops as true by default, which creates nestedScrollViewsApp/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx
Lines 57 to 69 in b1af723
What changes do you think we should make in order to solve the problem?
We simply add props
shouldUseScrollView={false}We can check other places that has the same nested
ScrollViewsWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
ryntgh commentedon Sep 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Confirm button is being cut off when users paste NetSuite credentials in the token input form
What is the root cause of that problem?
ConnectionLayouthasshouldUseScrollView(true by default) andFormProvideralso creates its ownScrollView(true by default). This creates nestedScrollViewswith the same orientation, which causes layout issues where the inner content doesn't properly calculate its heightApp/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx
Lines 57 to 69 in 24fe08c
App/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/substeps/NetSuiteTokenInputForm.tsx
Lines 58 to 67 in 24fe08c
What changes do you think we should make in order to solve the problem?
We should add
shouldUseScrollView={false}to theFormProviderinNetSuiteTokenInputFormto prevent it from creating its ownScrollViewApp/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/substeps/NetSuiteTokenInputForm.tsx
Lines 58 to 67 in d6ec98b
We should not add this prop to the
ConnectionLayoutinNetSuiteTokenInputPagebecause it will make the button missing bottom padding, sinceConnectionLayoutcomponent wraps the step content in aScrollViewwithaddBottomSafeAreaPadding={true}App/src/components/ConnectionLayout.tsx
Lines 146 to 150 in 24fe08c
Adding the prop to
ConnectionLayoutinNetSuiteTokenInputPagewill cause the button to collide with the offline message indicatorMissing bottom padding
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Sep 17, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021968396598761544429
[-]iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/-][+][$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/+]melvin-bot commentedon Sep 17, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (
External)dmkt9 commentedon Sep 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Confirm button is cut off for some first time slide up screen
What is the root cause of that problem?
In
NetSuiteTokenInputForm, the component usesFormProvider, which by default wraps its content in aScrollView.Additionally,
NetSuiteTokenInputPageusesConnectionLayoutas its container, andConnectionLayouthas a default propshouldUseScrollView = true, which means it also wraps its children in aScrollView:App/src/components/ConnectionLayout.tsx
Line 101 in aacbf6b
This results in two nested
ScrollViews, which causes the inner one to lose its scroll functionality—leading to the current issue.What changes do you think we should make in order to solve the problem?
To resolve this, we need to eliminate the nested
ScrollViewwhile still ensuring "BottomSafeAreaPadding" is preserved.Disable the outer
ScrollView: PassshouldUseScrollView={false}toConnectionLayoutinsideNetSuiteTokenInputPage:App/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx
Line 69 in aacbf6b
Note: After reviewing all usages of
ConnectionLayout, it appears thatshouldUseScrollViewis consistently passed asfalse. Therefore, we should consider changing its default value tofalse, encouraging developers to explicitly opt-in when needed.Add a wrapper component to preserve "BottomSafeAreaPadding": Create a new
Containercomponent that usesuseBottomSafeSafeAreaPaddingStyle, similar to how it's used inScrollViewhere:App/src/components/ConnectionLayout.tsx
Line 87 in aacbf6b
Note: This is necessary to retain the benefits of
ScreenWrapperinsideConnectionLayout.Replace the existing
Viewwith the newContainer:App/src/components/ConnectionLayout.tsx
Line 154 in aacbf6b
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
result.mp4
55 remaining items
[-][Due for payment 2025-12-30] [$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/-][+][Due for payment 2026-01-05] [Due for payment 2025-12-30] [$250] iOS - Accounting - Confirm button is cut off after paste the credentials login NetSuite[/+]melvin-bot commentedon Dec 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.87-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 29, 2025
@Pujan92 / @abzokhattab @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jan 1, 2026
@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Pujan92 commentedon Jan 5, 2026
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/44661/changes#r2660321079
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/584151
Regression Test Proposal
Precondition: Create a control workspace and enable Accounting
Zapier Logs
Run ID: 00040eee-29ae-a619-9b2a-5ac6e499d7a4sonialiap commentedon Jan 5, 2026
Payment summary:
@Pujan92 $250 please request in NewDot
@abzokhattab $250 please request in NewDot
twisterdotcom commentedon Jan 5, 2026
@abzokhattab has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-ca7b-a93c-2f25-995d04ffaaf4