You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-28] [$250] Reports - Infinite skeleton loading on any Reports tab after going online #70887
Sign in to ND (or go to Troubleshoot and clear cache)
On the Inbox or Account page press CMD+D or tap four fingers and enable Force offline mode
Navigate to the Reports tab - Expenses or any other tab
"You appear to be offline" is displayed, go online
Verify the page loads successfully
Expected Result:
The page loads successfully after going online
Actual Result:
The page in Reports tab shows infinite skeleton loading after going online. It loads after re-visiting the page. For expensifail accounts user's avatar is default in Chats
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6949574_1758296567171.Loading_reports.1.mp4
When we go online from the debug modal page, the Search API is also not called because the page isn't focused. It shows the skeleton because the data is not loaded (isDataLoaded is false).
changed the title [-]Reports - Infinite skeleton loading on any Reports tab after going online[/-][+][$250] Reports - Infinite skeleton loading on any Reports tab after going online[/+]on Sep 22, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.35-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox / @bernhardoj@sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
User signed in to Expensify app
User has at least one report in their account
Debug/troubleshoot mode accessible (CMD+D or 4-finger tap)
Test:
Go to Account tab -> Troubleshoot and clear cache)
Enable Force offline mode (CMD+D or 4-finger tap on mobile)
Navigate to Reports tab (Expenses or any other Reports tab)
Verify "You appear to be offline" message is displayed
Disable offline mode to go back online
Verify the page loads successfully without infinite skeleton loading
Activity
melvin-bot commentedon Sep 19, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Sep 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - Infinite skeleton loading on any Reports tab after going online
What is the root cause of that problem?
We doesn't properly handle the offline-to-online transition here
searchResults?.search.isLoadingstate from before going offline can remaintrueorundefinedisLoadingis stilltrueANDdata.length === 0, the component shows infinite skeleton loadingWhat changes do you think we should make in order to solve the problem?
Add an
onReconnectcallback to theuseNetworkhook to trigger a search when the user comes back onlineApp/src/components/Search/index.tsx
Line 219 in bc81793
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
bernhardoj commentedon Sep 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Infinite skeleton shows in reports page after going online.
What is the root cause of that problem?
When we open the Reports page while offline, the Search API is not called.
App/src/components/Search/index.tsx
Lines 367 to 379 in d41575d
When we go online from the debug modal page, the Search API is also not called because the page isn't focused. It shows the skeleton because the data is not loaded (isDataLoaded is false).
App/src/components/Search/index.tsx
Lines 399 to 401 in d41575d
What changes do you think we should make in order to solve the problem?
We can call Search API even if it's not focused if we are going online and there is no result yet.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
We can add an exception for debug modal page too like
isMigratedModalDisplayed, but it will still happen if we switch the network status manually.App/src/components/Search/index.tsx
Lines 369 to 373 in d41575d
melvin-bot commentedon Sep 22, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021970142612481614536
[-]Reports - Infinite skeleton loading on any Reports tab after going online[/-][+][$250] Reports - Infinite skeleton loading on any Reports tab after going online[/+]melvin-bot commentedon Sep 22, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)21 remaining items
melvin-bot commentedon Oct 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.35-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 21, 2025
@suneox / @bernhardoj @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Oct 28, 2025
Payment Summary
Upwork Job
BugZero Checklist (@sakluger)
suneox commentedon Oct 29, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I believe there is no specific PR responsible for this bug as it's an edge case that may have existed for a very long time. The PR that fixes this issue adds a case similar to issue [Due for payment 2025-08-07] Migrated users see prolonged Search loading #67040
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
sakluger commentedon Oct 29, 2025
Thanks everyone, please use the payment summary above to request payment.
bernhardoj commentedon Oct 29, 2025
Requested in ND.
quinthar commentedon Nov 2, 2025
$250 approved to @bernhardoj
garrettmknight commentedon Nov 21, 2025
$250 approved for @suneox