Skip to content

[Awaiting Checklist] [Due for payment 2025-10-01] Expense - Transaction thread has different alignment when opened in RHP and from LHN #70911

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.16-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #70250
Email or phone of affected tester (no customers): sdoijdsoisnjdssosd33@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open 1:1 DM.
  3. Submit two expenses to the user.
  4. Open expense report.
  5. Open any transaction thread.
    → The transaction thread is opened on top when it is opened in RHP.
  6. Create a draft on the transaction thread.
  7. Close the RHP.
  8. Open the transaction thread from LHN.
    → The same transaction thread is not opened on top.

Expected Result:

In Step 5 and Step 8, when the transaction thread is opened in RHP and from LHN, the alignment should be the same.

Actual Result:

In Step 5, when the transaction thread is opened in RHP, the transaction thread is opened on top.
In Step 8, the same transaction thread is not opened on top when opened from LHN.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6950067_1758326426158.Screen_Recording_2025-09-20_at_07.56.30.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Sep 20, 2025
  2. melvin-bot commented on Sep 20, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 20, 2025

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Sep 20, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Sep 20, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. VickyStash commented on Sep 22, 2025

    @VickyStash
    Contributor

    Hey @mitarachim, I'm not sure I get the issue at 100%, could you please provide the expected result vs actual result screenshots comparison? 🙏

  7. 34 remaining items

  8. melvin-bot commented on Sep 24, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.17-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-01. 🎊

    For reference, here are some details about the assignees on this issue:

    • @VickyStash does not require payment (Contractor)
    • @c3024 requires payment through NewDot Manual Requests
  9. melvin-bot commented on Sep 24, 2025

    @melvin-bot

    @c3024 @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. melvin-bot commented on Sep 29, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. melvin-bot commented on Oct 1, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @VickyStash is from an agency-contributor and not due payment
    • Reviewer: @c3024 owed $250 via NewDot

    BugZero Checklist (@garrettmknight)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. garrettmknight commented on Oct 2, 2025

    @garrettmknight
    Contributor

    @c3024 can you complete the checklist for this one?

  13. changed the title [-][Due for payment 2025-10-01] Expense - Transaction thread has different alignment when opened in RHP and from LHN[/-] [+][Awaiting Checklist] [Due for payment 2025-10-01] Expense - Transaction thread has different alignment when opened in RHP and from LHN[/+] on Oct 2, 2025
  14. c3024 commented on Oct 2, 2025

    @c3024
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: The author is aware of the change.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not a critical regression.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • None

    Test:

    1. Open the app
    2. Open 1:1 DM without expenses
    3. Submit two expenses to the user.
    4. Open expense report.
    5. Open any transaction thread.
    6. → The transaction thread is opened on top when it is opened in RHP.
    7. Create a draft comment on the transaction thread (just start typing)
    8. Close the RHP.
    9. Open the same transaction thread from LHN.
    10. → The transaction thread should be opened on top.

    Do we agree 👍 or 👎

  15. garrettmknight commented on Oct 2, 2025

    @garrettmknight
    Contributor
  16. JmillsExpensify commented on Oct 28, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @c3024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions