Skip to content

Expense - No option to approve unheld amount when report has held & unheld negative expenses #71017

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.15-1 PR:65001
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): jsdoinjosdjosjniosdj@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to 65001.pr-testing.expensify.com
  2. Go to workspace
  3. Create two expenses with negative amount
  4. Open the expense report
  5. Click Submit
  6. Select one of the expenses via checkbox
  7. Click More > Hold
  8. Enter reason and save it
  9. Click Approve

Expected Result:

Approve modal should give the option to approve unheld or to approve the total amount

Actual Result:

Approve modal only gives the option to approve the total amount when the report contains held and unheld expense with negative amount

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6952514_1758561107067.Screen_Recording_2025-09-23_at_01.01.30.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 22, 2025
  2. melvin-bot commented on Sep 22, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 22, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Sep 22, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Sep 22, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 3 remaining items

  7. melvin-bot commented on Sep 25, 2025

    @melvin-bot

    @pasyukevich Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. melvin-bot commented on Sep 29, 2025

    @melvin-bot

    @pasyukevich Still overdue 6 days?! Let's take care of this!

  9. melvin-bot commented on Oct 1, 2025

    @melvin-bot

    @pasyukevich 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  10. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    This issue has not been updated in over 14 days. @pasyukevich eroding to Weekly issue.

  11. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    This issue has not been updated in over 15 days. @pasyukevich eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    @pasyukevich, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions