Skip to content

[Due for payment 2025-10-28] [$250] Manager McTest tooltip does not adjust properly to the icon when searching #71353

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.18-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #70530
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 18.5 Safari
App Component: Other

Action Performed:

  1. Sign in to ND with a new gmail account
  2. Choose the "Track" intent
  3. Go to Create expense > Manual
  4. Enter an amount > next
  5. Type "manager" in the input field - observe the tooltip position (it is below the Manager's contact)
  6. Continue typing characters that will not bring any result
  7. Tap delete button the keyboard until there is a "manager" in the input, the Manager with a tooltip is shown at the top of the results
  8. Continue delete button in the keyboard until all the text is removed
  9. Observe the tooltip - it's pointing on the (you) result as it at the top now

Expected Result:

"Choose our test manager and try it out" tooltip follows the Manager's icon while searching contacts on "Choose recipient" page

Actual Result:

The tooltip does not follow the Manager's icon properly

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6955907_1758838129582.Tooltip.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021971614043585370991
  • Upwork Job ID: 1971614043585370991
  • Last Price Increase: 2025-09-26
Issue OwnerCurrent Issue Owner: @dmkt9

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 26, 2025
  2. melvin-bot commented on Sep 26, 2025

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. dmkt9 commented on Sep 26, 2025

    @dmkt9
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The tooltip does not follow the Manager's icon properly

    What is the root cause of that problem?

    Currently, we only recalculate the tooltip position on resizing and scrolling events. Changes in the order of items within the list are not covered by these two events, which leads to the current issue:

    // Re-render the tooltip when resizing ends
    // This is necessary to ensure the tooltip is positioned correctly after resizing
    renderTooltip();

    if (isScrolling) {
    hideTooltip();
    } else {
    renderTooltip();
    }

    What changes do you think we should make in order to solve the problem?

    TEST BRANCH

    We will calculate the position of the BaseEducationalTooltip within the list and include it in the dependency array of the useEffect hook, allowing the renderTooltip function to be triggered and recalculate the position accordingly.

    index={index}
    + sectionIndex={section?.indexOffset ?? 0}

    index={index}
    + sectionIndex={sectionIndex}

    wrapperStyle={styles.productTrainingTooltipWrapper}

    wrapperStyle={styles.productTrainingTooltipWrapper}
    + uniqueID={`${sectionIndex}-${index}`}

    }, [isResizing, renderTooltip, shouldRender]);

    -    }, [isResizing, renderTooltip, shouldRender]);
    +    }, [isResizing, renderTooltip, shouldRender, uniqueID]);

    Note: We can review other cases where tooltips are rendered for items in a list and apply the same approach if necessary.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    If we prefer not to use uniqueID for the EducationalTooltip in InviteMemberListItem, we could consider using the item's key instead. However, this would cause the item to be re-mounted, which may negatively impact performance.

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

    2025-09-26.18-20-39.mp4
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 26, 2025
  5. changed the title [-]Manager McTest tooltip does not adjust properly to the icon when searching[/-] [+][$250] Manager McTest tooltip does not adjust properly to the icon when searching[/+] on Sep 26, 2025
  6. melvin-bot commented on Sep 26, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 26, 2025
  8. melvin-bot commented on Sep 26, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  9. heyjennahay commented on Sep 26, 2025

    @heyjennahay
    Contributor

    Small design bug, low priority but worth fixing

  10. rushatgabhane commented on Sep 26, 2025

    @rushatgabhane
    Member

    agree with @dmkt9 's root cause 🎀👀🎀

    #71353 (comment)

  11. 24 remaining items

  12. heyjennahay commented on Oct 28, 2025

    @heyjennahay
    Contributor

    @dmkt9 can you please complete the above checklist and re-star me so I can process the payment for this job?

  13. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@heyjennahay)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1971614043585370991/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. dmkt9 commented on Oct 29, 2025

    @dmkt9
    Contributor

    @dmkt9 can you please complete the above checklist and re-star me so I can process the payment for this job?

    Hi @heyjennahay, @rushatgabhane is the assigned C+.

  15. rushatgabhane commented on Oct 31, 2025

    @rushatgabhane
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: 1619eb5#r169324425

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

    1. Sign in to ND with a new gmail account
    2. Choose the "Track" intent
    3. Go to Create expense > Manual
    4. Enter an amount > next
    5. Type "manager" in the input field - observe the tooltip position (it is below the Manager's contact)
    6. Continue typing characters that will not bring any result
    7. Tap delete button the keyboard until there is a "manager" in the input, the Manager with a tooltip is shown at the top of the results
    8. Continue delete button in the keyboard until all the text is removed
    9. Verify that "Choose our test manager and try it out" tooltip follows the Manager's icon while searching contacts on "Choose recipient" page

    Do we agree 👍 or 👎

  16. garrettmknight commented on Nov 1, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

  17. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    @heyjennahay Whoops! This issue is 2 days overdue. Let's get this updated quick!

  18. heyjennahay commented on Nov 4, 2025

    @heyjennahay
    Contributor

    Hi @dmkt9 can you please accept this Upwork offer so I can pay you? https://www.upwork.com/nx/wm/offer/109354395

  19. dmkt9 commented on Nov 4, 2025

    @dmkt9
    Contributor

    @heyjennahay Thanks. I've just requested payment.

  20. heyjennahay commented on Nov 4, 2025

    @heyjennahay
    Contributor

    $250 payment process for @dmkt9 on https://www.upwork.com/nx/wm/workroom/42084011/overview

    @dmkt9 not sure if you saw this post but if you can apply for the Upwork job next time then we can make sure your payment is processed faster

  21. dmkt9 commented on Nov 5, 2025

    @dmkt9
    Contributor

    @dmkt9 not sure if you saw this post but if you can apply for the Upwork job next time then we can make sure your payment is processed faster

    @heyjennahay Thanks! I did apply to some previous jobs, but I think my Upwork ID wasn’t recorded by Melvin, so I haven’t received automatic offers like other contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions