You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-28] [$250] Manager McTest tooltip does not adjust properly to the icon when searching #71353
Version Number: 9.2.18-6 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#70530 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 18.5 Safari App Component: Other
Action Performed:
Sign in to ND with a new gmail account
Choose the "Track" intent
Go to Create expense > Manual
Enter an amount > next
Type "manager" in the input field - observe the tooltip position (it is below the Manager's contact)
Continue typing characters that will not bring any result
Tap delete button the keyboard until there is a "manager" in the input, the Manager with a tooltip is shown at the top of the results
Continue delete button in the keyboard until all the text is removed
Observe the tooltip - it's pointing on the (you) result as it at the top now
Expected Result:
"Choose our test manager and try it out" tooltip follows the Manager's icon while searching contacts on "Choose recipient" page
Actual Result:
The tooltip does not follow the Manager's icon properly
Please re-state the problem that we are trying to solve in this issue.
The tooltip does not follow the Manager's icon properly
What is the root cause of that problem?
Currently, we only recalculate the tooltip position on resizing and scrolling events. Changes in the order of items within the list are not covered by these two events, which leads to the current issue:
We will calculate the position of the BaseEducationalTooltip within the list and include it in the dependency array of the useEffect hook, allowing the renderTooltip function to be triggered and recalculate the position accordingly.
Note: We can review other cases where tooltips are rendered for items in a list and apply the same approach if necessary.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
If we prefer not to use uniqueID for the EducationalTooltip in InviteMemberListItem, we could consider using the item's key instead. However, this would cause the item to be re-mounted, which may negatively impact performance.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Manager McTest tooltip does not adjust properly to the icon when searching[/-][+][$250] Manager McTest tooltip does not adjust properly to the icon when searching[/+]on Sep 26, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
@dmkt9 not sure if you saw this post but if you can apply for the Upwork job next time then we can make sure your payment is processed faster
@heyjennahay Thanks! I did apply to some previous jobs, but I think my Upwork ID wasn’t recorded by Melvin, so I haven’t received automatic offers like other contributors.
Activity
melvin-bot commentedon Sep 26, 2025
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dmkt9 commentedon Sep 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The tooltip does not follow the Manager's icon properly
What is the root cause of that problem?
Currently, we only recalculate the tooltip position on resizing and scrolling events. Changes in the order of items within the list are not covered by these two events, which leads to the current issue:
App/src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx
Lines 84 to 86 in 5edc01d
App/src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx
Lines 97 to 101 in 5edc01d
What changes do you think we should make in order to solve the problem?
TEST BRANCH
We will calculate the position of the
BaseEducationalTooltipwithin the list and include it in the dependency array of theuseEffecthook, allowing therenderTooltipfunction to be triggered and recalculate the position accordingly.App/src/components/SelectionList/BaseSelectionList.tsx
Line 659 in 5edc01d
index={index} + sectionIndex={section?.indexOffset ?? 0}App/src/components/SelectionList/BaseSelectionListItemRenderer.tsx
Line 113 in 5edc01d
index={index} + sectionIndex={sectionIndex}App/src/components/SelectionList/InviteMemberListItem.tsx
Line 109 in 5edc01d
wrapperStyle={styles.productTrainingTooltipWrapper} + uniqueID={`${sectionIndex}-${index}`}App/src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx
Line 88 in 5edc01d
Note: We can review other cases where tooltips are rendered for items in a list and apply the same approach if necessary.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
If we prefer not to use
uniqueIDfor theEducationalTooltipinInviteMemberListItem, we could consider using the item'skeyinstead. However, this would cause the item to be re-mounted, which may negatively impact performance.Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
2025-09-26.18-20-39.mp4
[-]Manager McTest tooltip does not adjust properly to the icon when searching[/-][+][$250] Manager McTest tooltip does not adjust properly to the icon when searching[/+]melvin-bot commentedon Sep 26, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021971614043585370991
melvin-bot commentedon Sep 26, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)heyjennahay commentedon Sep 26, 2025
Small design bug, low priority but worth fixing
rushatgabhane commentedon Sep 26, 2025
agree with @dmkt9 's root cause 🎀👀🎀
#71353 (comment)
24 remaining items
heyjennahay commentedon Oct 28, 2025
@dmkt9 can you please complete the above checklist and re-star me so I can process the payment for this job?
melvin-bot commentedon Oct 28, 2025
Payment Summary
Upwork Job
BugZero Checklist (@heyjennahay)
dmkt9 commentedon Oct 29, 2025
Hi @heyjennahay, @rushatgabhane is the assigned C+.
fix position on small screen, rerender tooltip on resize
rushatgabhane commentedon Oct 31, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: 1619eb5#r169324425
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/564789
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
garrettmknight commentedon Nov 1, 2025
$250 approved for @rushatgabhane
melvin-bot commentedon Nov 3, 2025
@heyjennahay Whoops! This issue is 2 days overdue. Let's get this updated quick!
heyjennahay commentedon Nov 4, 2025
Hi @dmkt9 can you please accept this Upwork offer so I can pay you? https://www.upwork.com/nx/wm/offer/109354395
dmkt9 commentedon Nov 4, 2025
@heyjennahay Thanks. I've just requested payment.
heyjennahay commentedon Nov 4, 2025
$250 payment process for @dmkt9 on https://www.upwork.com/nx/wm/workroom/42084011/overview
@dmkt9 not sure if you saw this post but if you can apply for the Upwork job next time then we can make sure your payment is processed faster
dmkt9 commentedon Nov 5, 2025
@heyjennahay Thanks! I did apply to some previous jobs, but I think my Upwork ID wasn’t recorded by Melvin, so I haven’t received automatic offers like other contributors.