Skip to content

[$250] [Due for payment 2025-12-11] Split- Distance expense can be split with workspace by creating workspace in Rate upgrade page #71538

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.20-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #71474
Email or phone of affected tester (no customers): dsjiojdsoidjsnsoidjs@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open 1:1 DM.
  3. Click + > Split expense > Distance.
  4. Enter waypoints > Next.
  5. On confirm page, click Rate field.
  6. Click Upgrade > Got it, thanks.
  7. Click RHP back button to return to confirm page.
    BUG 1: "The sum of splits must equal the total amount" error shows up when the split total matches the total amount.
  8. Click Distance.
  9. Edit the waypoints and save it.
  10. Click on the split preview.
    BUG 2: Split preview shows pending instead of distance and rate.
    BUG 3: GBR appears next to the workspace on split details page.

Expected Result:

In Step 7, split expense with workspace should not be made possible because we cannot split expense directly in workspace chat.

Actual Result:

In Step 7, we can split distance expense with workspace by splitting distance in 1:1 DM and creating a new workspace via Rate upgrade page.

This leads to a number of issues after splitting distance expense with workspace:
BUG 1: "The sum of splits must equal the total amount" error shows up when the split total matches the total amount.
BUG 2: Split preview shows pending instead of distance and rate.
BUG 3: GBR appears next to the workspace on split details page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

11.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021999600819256493901
  • Upwork Job ID: 1999600819256493901
  • Last Price Increase: 2025-12-12

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 30, 2025
  2. melvin-bot commented on Sep 30, 2025

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. bernhardoj commented on Sep 30, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User can open the rate page when creating a split distance in DM.

    What is the root cause of that problem?

    Previously, the rate field is pressable only if it's a policy expense chat, then we add another condition for manual distance. But this PR removes both conditions. So the rate is now pressable in DM.

    interactive={!!rate && !isReadOnly}

    What changes do you think we should make in order to solve the problem?

    We can reintroduce the policy expense chat and manual distance.
    https://github.com/Expensify/App/pull/71474/files#diff-f03dbdeb70d463bca4be7ee37933485f3ff1e10e8c5c0e38bd20db4f1273e3f0L508-L536

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

  4. mkzie2 commented on Sep 30, 2025

    @mkzie2
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User can open the rate page when creating a split distance in DM.

    What is the root cause of that problem?

    From this PR, we enable the rate field for IOU as well to facilitate the distance rate upgrade flow. However that should not apply to split distance expense.

    What changes do you think we should make in order to solve the problem?

    Update this line to exclude iouType of SPLIT:

    interactive={!!rate && !isReadOnly}

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. flaviadefaria commented on Oct 3, 2025

    @flaviadefaria
    Contributor

    Reassigning as I'm going on parental leave.

  6. removed their assignment
    on Oct 3, 2025
  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 3, 2025
  8. melvin-bot commented on Oct 3, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  9. mallenexpensify commented on Oct 7, 2025

    @mallenexpensify
    Contributor

    @allroundexperts 👀 plz since you're working on distance requests

  10. 44 remaining items

  11. changed the title [-][Due for payment 2025-12-11] Split- Distance expense can be split with workspace by creating workspace in Rate upgrade page[/-] [+][$250] [Due for payment 2025-12-11] Split- Distance expense can be split with workspace by creating workspace in Rate upgrade page[/+] on Dec 12, 2025
  12. melvin-bot commented on Dec 12, 2025

    @melvin-bot
  13. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 12, 2025
  14. melvin-bot commented on Dec 12, 2025

    @melvin-bot

    Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

  15. mallenexpensify commented on Dec 12, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @mkzie2 paid $250 via Upwork
    Contributor+: @allroundexperts due $250 via NewDot

    @mkzie2 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021999600819256493901

  16. mallenexpensify commented on Dec 15, 2025

    @mallenexpensify
    Contributor

    @mkzie2 can you please accept the job below? Please reply here and tag me once you have. (I hired ya)
    https://www.upwork.com/jobs/~021999600819256493901

  17. mkzie2 commented on Dec 16, 2025

    @mkzie2
    Contributor

    @mallenexpensify I accepted the offer.

  18. mallenexpensify commented on Dec 16, 2025

    @mallenexpensify
    Contributor

    @mkzie2 paid, summary updated above.
    Test case created. ^

  19. trjExpensify commented on Jan 5, 2026

    @trjExpensify
    Contributor

    approved $250 for @allroundexperts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions