You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Due for payment 2025-12-11] Split- Distance expense can be split with workspace by creating workspace in Rate upgrade page #71538
Version Number: 9.2.20-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#71474 Email or phone of affected tester (no customers):dsjiojdsoidjsnsoidjs@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Open 1:1 DM.
Click + > Split expense > Distance.
Enter waypoints > Next.
On confirm page, click Rate field.
Click Upgrade > Got it, thanks.
Click RHP back button to return to confirm page.
BUG 1: "The sum of splits must equal the total amount" error shows up when the split total matches the total amount.
Click Distance.
Edit the waypoints and save it.
Click on the split preview.
BUG 2: Split preview shows pending instead of distance and rate.
BUG 3: GBR appears next to the workspace on split details page.
Expected Result:
In Step 7, split expense with workspace should not be made possible because we cannot split expense directly in workspace chat.
Actual Result:
In Step 7, we can split distance expense with workspace by splitting distance in 1:1 DM and creating a new workspace via Rate upgrade page.
This leads to a number of issues after splitting distance expense with workspace:
BUG 1: "The sum of splits must equal the total amount" error shows up when the split total matches the total amount.
BUG 2: Split preview shows pending instead of distance and rate.
BUG 3: GBR appears next to the workspace on split details page.
Please re-state the problem that we are trying to solve in this issue.
User can open the rate page when creating a split distance in DM.
What is the root cause of that problem?
Previously, the rate field is pressable only if it's a policy expense chat, then we add another condition for manual distance. But this PR removes both conditions. So the rate is now pressable in DM.
Please re-state the problem that we are trying to solve in this issue.
User can open the rate page when creating a split distance in DM.
What is the root cause of that problem?
From this PR, we enable the rate field for IOU as well to facilitate the distance rate upgrade flow. However that should not apply to split distance expense.
What changes do you think we should make in order to solve the problem?
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][Due for payment 2025-12-11] Split- Distance expense can be split with workspace by creating workspace in Rate upgrade page[/-][+][$250] [Due for payment 2025-12-11] Split- Distance expense can be split with workspace by creating workspace in Rate upgrade page[/+]on Dec 12, 2025
Activity
melvin-bot commentedon Sep 30, 2025
Triggered auto assignment to @flaviadefaria (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Sep 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User can open the rate page when creating a split distance in DM.
What is the root cause of that problem?
Previously, the rate field is pressable only if it's a policy expense chat, then we add another condition for manual distance. But this PR removes both conditions. So the rate is now pressable in DM.
App/src/components/MoneyRequestConfirmationListFooter.tsx
Line 533 in bda97bb
What changes do you think we should make in order to solve the problem?
We can reintroduce the policy expense chat and manual distance.
https://github.com/Expensify/App/pull/71474/files#diff-f03dbdeb70d463bca4be7ee37933485f3ff1e10e8c5c0e38bd20db4f1273e3f0L508-L536
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
mkzie2 commentedon Sep 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User can open the rate page when creating a split distance in DM.
What is the root cause of that problem?
From this PR, we enable the rate field for IOU as well to facilitate the distance rate upgrade flow. However that should not apply to split distance expense.
What changes do you think we should make in order to solve the problem?
Update this line to exclude
iouTypeofSPLIT:App/src/components/MoneyRequestConfirmationListFooter.tsx
Line 533 in bda97bb
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
flaviadefaria commentedon Oct 3, 2025
Reassigning as I'm going on parental leave.
melvin-bot commentedon Oct 3, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mallenexpensify commentedon Oct 7, 2025
@allroundexperts 👀 plz since you're working on distance requests
44 remaining items
[-][Due for payment 2025-12-11] Split- Distance expense can be split with workspace by creating workspace in Rate upgrade page[/-][+][$250] [Due for payment 2025-12-11] Split- Distance expense can be split with workspace by creating workspace in Rate upgrade page[/+]melvin-bot commentedon Dec 12, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021999600819256493901
melvin-bot commentedon Dec 12, 2025
Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.
mallenexpensify commentedon Dec 12, 2025
Payment Summary
Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @allroundexperts due $250 via NewDot
@mkzie2 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~021999600819256493901
mallenexpensify commentedon Dec 15, 2025
@mkzie2 can you please accept the job below? Please reply here and tag me once you have. (I hired ya)
https://www.upwork.com/jobs/~021999600819256493901
mkzie2 commentedon Dec 16, 2025
@mallenexpensify I accepted the offer.
mallenexpensify commentedon Dec 16, 2025
@mkzie2 paid, summary updated above.
Test case created. ^
trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.