You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment 2025-11-10] [$250] Report field - RHP shows Not here page while it closes after deleting the report field #71859
The optimistic update of deleteReportField makes reportField become null
Navigation goBack() not completing in time
Component re-rendering with reportField = null → triggering the condition to show "not found"
What changes do you think we should make in order to solve the problem?
We should wrap in deleteReportField in the delay mechanism to ensure navigation completes before the optimistic update occurs like the way we did with delete taxes here
const handleReportFieldDelete = () => {
setIsDeleteModalVisible(false);
goBack();
// Delay the deletion to avoid a race condition with navigation
setTimeout(() => {
deleteReportField(report.reportID, reportField);
}, CONST.ANIMATED_TRANSITION); // 300ms
};
Note 1: Because InteractionManager.runAfterInteractions is about to be deprecated, we can use another delay mechanism as a replacement — for example, setTimeout or requestIdleCallback as React suggests here.
Note 2: we can check other pages that has the same error and fix in this issue
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Report field - RHP shows Not here page while it closes after deleting the report field[/-][+][$250] Report field - RHP shows Not here page while it closes after deleting the report field[/+]on Oct 7, 2025
We should wrap in deleteReportField in the InteractionManager.runAfterInteractions to ensure navigation completes before the optimistic update occurs like the way we did with delete taxes here
InteractionManager will be deprecated as soon as we upgrade the react native version to the latest (0.82.0). I don't think we should do it here.
Activity
melvin-bot commentedon Oct 4, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Oct 4, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-10-13 16:03:14 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
RHP shows Not here page while it closes after deleting the report field
What is the root cause of that problem?
We have a race condition here
App/src/pages/EditReportFieldPage.tsx
Lines 76 to 80 in b76a740
deleteReportFieldmakesreportFieldbecomenullgoBack()not completing in timeWhat changes do you think we should make in order to solve the problem?
We should wrap in
deleteReportFieldin the delay mechanism to ensure navigation completes before the optimistic update occurs like the way we did with delete taxes hereNote 1: Because InteractionManager.runAfterInteractions is about to be deprecated, we can use another delay mechanism as a replacement — for example,
setTimeoutorrequestIdleCallbackas React suggests here.Note 2: we can check other pages that has the same error and fix in this issue
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Report field - RHP shows Not here page while it closes after deleting the report field[/-][+][$250] Report field - RHP shows Not here page while it closes after deleting the report field[/+]melvin-bot commentedon Oct 7, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021975653582402707041
melvin-bot commentedon Oct 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)hungvu193 commentedon Oct 9, 2025
InteractionManagerwill be deprecated as soon as we upgrade the react native version to the latest (0.82.0). I don't think we should do it here.FYI: https://reactnative.dev/docs/interactionmanager
45 remaining items
nkdengineer commentedon Nov 21, 2025
@strepanier03 @garrettmknight I get paid via NewDot now.
melvin-bot commentedon Nov 28, 2025
@nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Dec 1, 2025
@nkdengineer Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Dec 2, 2025
@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Dec 4, 2025
@strepanier03 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
dangrous commentedon Dec 11, 2025
Where are we on this one? Is payment all set or do we still need to do something before closing? Thanks!
melvin-bot commentedon Dec 11, 2025
This issue has not been updated in over 14 days. @dangrous, @pecanoro, @strepanier03, @hungvu193, @nkdengineer eroding to Weekly issue.
CortneyOfstad commentedon Dec 22, 2025
Coming from this request, I reviewed and both are paid via Newdot. Confirmed the proposal in Upwork expired, so all set 👍
Payment Summary
@hungvu193 — to be paid $250 via NewDot
@nkdengineer — to be paid $250 via NewDot
twisterdotcom commentedon Mar 11, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-21b1-ac78-98d9-27de04b09094