You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-21] [$250] Report - "New Messages" badge appears briefly on report with new system messages #71962
Long tap on the expense preview and hold the expense.
Long tap on preview again, and remove hold from expense.
Open the report.
Note that "New Messages" badge appears briefly on top of report.
Scroll to the bottom of the report and return to the top.
Note that now, badge remains displayed.
Expected Result:
"New Messages" badge on transaction thread, should remain displayed when the new messages are not visible.
Actual Result:
"New Messages" badge on transaction thread, only appears briefly when there are new system messages on report. Badge only remain displayed after scrolling to the bottom of report and returning to the top.
Please re-state the problem that we are trying to solve in this issue.
"New Messages" badge on transaction thread, only appears briefly when there are new system messages on report. Badge only remain displayed after scrolling to the bottom of report and returning to the top.
What is the root cause of that problem?
when users hold/unhold the request, we'll add the new system messages in the transaction report, users haven't seen this message yet so when they go to the transaction report, isFloatingMessageCounterVisible will be true
and we also have the logic to set it to false when the page is mounted in
if (!shouldScrollToEndAfterLayout) {
setIsFloatingMessageCounterVisible(false);
reportScrollManager.scrollToBottom();
}
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Report - "New Messages" badge appears briefly on report with new system messages[/-][+][$250] Report - "New Messages" badge appears briefly on report with new system messages[/+]on Oct 7, 2025
Please re-state the problem that we are trying to solve in this issue.
"New Messages" badge on transaction thread, only appears briefly when there are new system messages on report. Badge only remain displayed after scrolling to the bottom of report and returning to the top.
What is the root cause of that problem?
Since ReportActionsList is now rendered at the top when isTransactionThreadReport or isMoneyRequestOrInvoiceReport is true:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Account has at least one workspace.
Test:
Navigate to workspace chat.
Create a manual expense.
Long tap on the expense preview and hold the expense.
Long tap on preview again, and remove hold from expense.
Open the report.
Verify that "New Messages" badge appears on top of report when new messages are not visible.
Nice. I confirmed internally that @nkdengineer's NewDot payments eligibility date is before they were hired for this role, so we are good to pay them via NewDot.
Activity
melvin-bot commentedon Oct 7, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Oct 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"New Messages" badge on transaction thread, only appears briefly when there are new system messages on report. Badge only remain displayed after scrolling to the bottom of report and returning to the top.
What is the root cause of that problem?
when users hold/unhold the request, we'll add the new system messages in the transaction report, users haven't seen this message yet so when they go to the transaction report, isFloatingMessageCounterVisible will be true
and we also have the logic to set it to false when the page is mounted in
App/src/pages/home/report/ReportActionsList.tsx
Line 406 in 1ff696b
so the
New messagesbadge disappearWhat changes do you think we should make in order to solve the problem?
setIsFloatingMessageCounterVisible(false)should be called along withreportScrollManager.scrollToBottom();like what we did inApp/src/pages/home/report/ReportActionsList.tsx
Lines 455 to 456 in 1ff696b
App/src/pages/home/report/ReportActionsList.tsx
Lines 462 to 463 in 1ff696b
and other places, so we should move
App/src/pages/home/report/ReportActionsList.tsx
Line 406 in 1ff696b
to
App/src/pages/home/report/ReportActionsList.tsx
Line 408 in 1ff696b
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Report - "New Messages" badge appears briefly on report with new system messages[/-][+][$250] Report - "New Messages" badge appears briefly on report with new system messages[/+]melvin-bot commentedon Oct 7, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021975571349168699803
melvin-bot commentedon Oct 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (
External)dmkt9 commentedon Oct 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"New Messages" badge on transaction thread, only appears briefly when there are new system messages on report. Badge only remain displayed after scrolling to the bottom of report and returning to the top.
What is the root cause of that problem?
Since
ReportActionsListis now rendered at the top whenisTransactionThreadReportorisMoneyRequestOrInvoiceReportis true:App/src/pages/home/report/ReportActionsList.tsx
Line 806 in 6ea9c3f
By default, the list is rendered at the bottom, so the "New messages" badge will be manually disabled here:
App/src/pages/home/report/ReportActionsList.tsx
Lines 405 to 411 in 6ea9c3f
What changes do you think we should make in order to solve the problem?
Therefore, we should remove this
useEffect:App/src/pages/home/report/ReportActionsList.tsx
Lines 399 to 413 in 6ea9c3f
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
22 remaining items
joekaufmanexpensify commentedon Oct 21, 2025
Bumped checklist in Slack. Will issue payment as soon as that's done.
rojiphil commentedon Oct 22, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
rojiphil commentedon Oct 22, 2025
@joekaufmanexpensify BZ Checklist done. Thanks.
joekaufmanexpensify commentedon Oct 22, 2025
Regression issue
joekaufmanexpensify commentedon Oct 22, 2025
Payment Summary
joekaufmanexpensify commentedon Oct 22, 2025
@nkdengineer could you please accept this offer so we can pay you?
nkdengineer commentedon Oct 22, 2025
@joekaufmanexpensify I will request payment via NewDot. Please help update the payment summary to indicate that. Then we're good to close here.
joekaufmanexpensify commentedon Oct 22, 2025
Nice. I confirmed internally that @nkdengineer's NewDot payments eligibility date is before they were hired for this role, so we are good to pay them via NewDot.
joekaufmanexpensify commentedon Oct 22, 2025
@nkdengineer @rojiphil Please request payment at your earliest convenience. Closing as this is otherwise all set.
JmillsExpensify commentedon Oct 27, 2025
$250 approved for @nkdengineer
trjExpensify commentedon Nov 10, 2025
approved $250 for @rojiphil.