You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting Checklist] [Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings #72068
Version Number: v9.2.27-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#71183 Email or phone of affected tester (no customers):ndk.2303+new237@gmail.com Issue reported by: Applause Internal Team Device used: Windows 11 Home/Chrome App Component: Workspace Settings
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Workspace-Able to enable 'Required' in offline without error in Tag settings[/-][+][$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/+]on Oct 13, 2025
@bernhardoj / @brunovjk@garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/-][+][Awaiting Checklist] [Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/+]on Nov 24, 2025
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No PR directly introduced this bug. Our solution was "Don't allow users to make tag list required if it's not a multi-level tag," a case that was not considered previously.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Workspace with the Tags enabled
Test:
Open the Workspaces Tag page
Press the "More" button and select "Settings"
Set "Members must tag all expenses" to disabled.
Deep link to staging.new.expensify.com/workspaces/{{WORKSPACE_ID}}/tag-list/0
Verify the Required field is locked
Press the Required field
Verify Cannot make tag list required modal is shown
Activity
melvin-bot commentedon Oct 8, 2025
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Oct 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
At step 8, user is able to enable 'Required' without error
At step 9, 'Required' is disabled, eror briefly shown
What is the root cause of that problem?
The tag list still appears because all tags are in a tag section with a custom name
Tag.App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx
Line 61 in 94b7ea2
What changes do you think we should make in order to solve the problem?
This page should only appear if the tag is a multilevel tag list. We should show the not found page if the policy tags is not multilevel tag
App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx
Line 332 in 94b7ea2
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
bernhardoj commentedon Oct 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When enabling the tag list item required while offline and then going online, the error is gone.
What is the root cause of that problem?
When we reconnect, the
OPEN_POLICY_TAGS_PAGEis called, which returns an onyx method of set that overwrites the existing error.App/src/pages/workspace/tags/WorkspaceTagsPage.tsx
Line 127 in 94b7ea2
What changes do you think we should make in order to solve the problem?
We have a few options.
or show the lock icon, just like when "Members must tag all expenses" is enabled.
melvin-bot commentedon Oct 13, 2025
@garrettmknight Huh... This is 4 days overdue. Who can take care of this?
[-]Workspace-Able to enable 'Required' in offline without error in Tag settings[/-][+][$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/+]melvin-bot commentedon Oct 13, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021977803846845267235
melvin-bot commentedon Oct 13, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (
External)44 remaining items
melvin-bot commentedon Nov 11, 2025
@bernhardoj / @brunovjk @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
garrettmknight commentedon Nov 21, 2025
Payment Summary
bernhardoj commentedon Nov 23, 2025
Requested in ND.
[-][Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/-][+][Awaiting Checklist] [Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/+]brunovjk commentedon Nov 24, 2025
I will complete the checklist soon.
brunovjk commentedon Nov 24, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No PR directly introduced this bug. Our solution was "Don't allow users to make tag list required if it's not a multi-level tag," a case that was not considered previously.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
staging.new.expensify.com/workspaces/{{WORKSPACE_ID}}/tag-list/0Do we agree 👍 or 👎
brunovjk commentedon Nov 24, 2025
Requested in ND.
JmillsExpensify commentedon Nov 25, 2025
$250 approved for @brunovjk
garrettmknight commentedon Dec 1, 2025
$250 approved for @bernhardoj