Skip to content

[Awaiting Checklist] [Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings #72068

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.27-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #71183
Email or phone of affected tester (no customers): ndk.2303+new237@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 Home/Chrome
App Component: Workspace Settings

Action Performed:

Prerequisites:

  • User with workspace
  • Workspace with the Tags extension enabled
  1. Open https://staging.new.expensify.com/
  2. Go to the "Workspaces settings"
  3. Click on "Tag"
  4. Click "More" button and select "Settings"
  5. Set "Members must tag all expenses" to disabled.
  6. Change path in url from /workspaces/{{WORKSPACE_ID}}/tags/settings to /workspaces/{{WORKSPACE_ID}}/tag-list/0
  7. Go offline
  8. Enable "Required"
  9. Go online

Expected Result:

At step 8, It should cause an error. Click 'x' can dismiss the error
At step 9, error should be still displayed (if not dismiss yet).

Actual Result:

At step 8, user is able to enable 'Required' without error
At step 9, 'Required' is disabled, eror briefly shown

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6968194_1759907512098.User_can_enable_Required_in_offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021977803846845267235
  • Upwork Job ID: 1977803846845267235
  • Last Price Increase: 2025-10-20
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 8, 2025
  2. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Oct 8, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    At step 8, user is able to enable 'Required' without error
    At step 9, 'Required' is disabled, eror briefly shown

    What is the root cause of that problem?

    The tag list still appears because all tags are in a tag section with a custom name Tag.

    function WorkspaceViewTagsPage({route}: WorkspaceViewTagsProps) {

    What changes do you think we should make in order to solve the problem?

    This page should only appear if the tag is a multilevel tag list. We should show the not found page if the policy tags is not multilevel tag

    shouldBeBlocked={!isMultiLevelTagsPolicyUtils(policyTags)}
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. bernhardoj commented on Oct 8, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When enabling the tag list item required while offline and then going online, the error is gone.

    What is the root cause of that problem?

    When we reconnect, the OPEN_POLICY_TAGS_PAGE is called, which returns an onyx method of set that overwrites the existing error.

    const {isOffline} = useNetwork({onReconnect: fetchTags});

    What changes do you think we should make in order to solve the problem?

    We have a few options.

    1. Fix this on the BE so it uses MERGE instead of SET.
    Image
    1. Disable the Required toggle when it's not a multi-level tag
      or show the lock icon, just like when "Members must tag all expenses" is enabled.
    Image
  5. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    @garrettmknight Huh... This is 4 days overdue. Who can take care of this?

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 13, 2025
  7. changed the title [-]Workspace-Able to enable 'Required' in offline without error in Tag settings[/-] [+][$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/+] on Oct 13, 2025
  8. melvin-bot commented on Oct 13, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 13, 2025
  10. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

  11. 44 remaining items

  12. melvin-bot commented on Nov 11, 2025

    @melvin-bot

    @bernhardoj / @brunovjk @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. garrettmknight commented on Nov 21, 2025

    @garrettmknight
    Contributor

    Payment Summary

  14. bernhardoj commented on Nov 23, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  15. changed the title [-][Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/-] [+][Awaiting Checklist] [Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings[/+] on Nov 24, 2025
  16. brunovjk commented on Nov 24, 2025

    @brunovjk
    Contributor

    I will complete the checklist soon.

  17. brunovjk commented on Nov 24, 2025

    @brunovjk
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: No PR directly introduced this bug. Our solution was "Don't allow users to make tag list required if it's not a multi-level tag," a case that was not considered previously.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Workspace with the Tags enabled

    Test:

    1. Open the Workspaces Tag page
    2. Press the "More" button and select "Settings"
    3. Set "Members must tag all expenses" to disabled.
    4. Deep link to staging.new.expensify.com/workspaces/{{WORKSPACE_ID}}/tag-list/0
    5. Verify the Required field is locked
    6. Press the Required field
    7. Verify Cannot make tag list required modal is shown

    Do we agree 👍 or 👎

  18. brunovjk commented on Nov 24, 2025

    @brunovjk
    Contributor

    Requested in ND.

  19. JmillsExpensify commented on Nov 25, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @brunovjk

  20. garrettmknight commented on Dec 1, 2025

    @garrettmknight
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions