Skip to content

[Due for payment 2025-10-28] [$250] Expense - App allows to merge negative expense with IOU expense, negative amount is not saved #72143

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.28-0
Reproducible in staging?: Y
Reproducible in production?: new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #65001
Email or phone of affected tester (no customers): sdijsnoisjnosij@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to 1:1 DM
  3. Submit an expense to the user
  4. Go to workspace chat
  5. Create an expense with negative amount in workspace chat
  6. Open the expense thread
  7. Click More > Merge
  8. Select the IOU expense from Step 3 > Continue
  9. Select the negative amount for Amount section
  10. Select the IOU report for Report section
  11. Click Continue > Merge expenses

Expected Result:

App should not allow to merge negative expense with IOU expense because the negative amount cannot be preserved

Actual Result:

App allows to merge negative expense with IOU expense. Although the negative amount is selected, the amount of the merged expense is not negative

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6969101_1759962567165.Screen_Recording_2025-10-09_at_06.25.32.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021976566116099337958
  • Upwork Job ID: 1976566116099337958
  • Last Price Increase: 2025-10-29
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 8, 2025
  2. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Oct 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. lakchote commented on Oct 9, 2025

    @lakchote
    Contributor
  7. 31 remaining items

  8. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.35-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment through NewDot Manual Requests
  9. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    @Pujan92 @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. melvin-bot commented on Oct 22, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  11. dylanexpensify commented on Oct 28, 2025

    @dylanexpensify
    Contributor

    Payment summary:

    Contributor+: @Pujan92 $250 via NewDot

    Please apply/request!

  12. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @Pujan92 owed $250 via NewDot

    BugZero Checklist (@dylanexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1976566116099337958/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. melvin-bot commented on Oct 29, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  14. melvin-bot commented on Oct 31, 2025

    @melvin-bot

    @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. JmillsExpensify commented on Nov 3, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @Pujan92

  16. melvin-bot commented on Dec 20, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions