Skip to content

Expense - When workspace has bank account, LHN shows GBR after approving negative expense #72198

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.28-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #56092
Email or phone of affected tester (no customers): applausetester+sdosdijodsj11nois@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace is set up with bank account.
  • Admin invites member to the workspace.
  1. Go to staging.new.expensify.com
  2. [Member] Go to workspace chat.
  3. [Member] Create an expense with negative amount (-$11).
  4. [Member] Click Submit on the expense preview.
  5. [Admin] Open member's workspace chat.

Expected Result:

GBR will not appear on member's workspace chat on LHN because the amount is negative and there is no more action required from the admin.

Actual Result:

GBR appears on member's workspace chat on LHN when there is no more action required from the admin.

This issue happens when workspace is set up with bank account.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 9, 2025
  2. melvin-bot commented on Oct 9, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 9, 2025

    @melvin-bot

    Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. lakchote commented on Oct 9, 2025

    @lakchote
    Contributor

    It's an edge case that doesn't affect a core flow. Demoting. Comes from #65001

  7. 30 remaining items

  8. cristipaval commented on Nov 4, 2025

    @cristipaval
    Contributor

    I missed the pings here. I'll have a look, but I think this can be a Weekly. I'll do my best to investigate before EOW

  9. self-assigned this
    on Nov 4, 2025
  10. cristipaval commented on Nov 13, 2025

    @cristipaval
    Contributor

    couldn't get to it last week and I am App deployer this week which slowed me down. I'll look into it early next week

  11. LukasMod commented on Nov 18, 2025

    @LukasMod
    Contributor

    @cristipaval Any updates about this one?

  12. cristipaval commented on Nov 19, 2025

    @cristipaval
    Contributor

    I investigated this a bit and I have a couple questions:

    1. When I do the reproducible steps, at the end, the admin gets the Mark as paid green button after approving (I'm not getting the grey View button as in the recording from the bug report). If the admin clicks it, then the GBR disappears. Am I missing anything?

    2. Is the expected result correct?

    Image

    It says that when the amount is negative, there is no more action required from admin. But I see in the screen recording from the bug report that when the admin opens the expense after approving, the Next steps says it is waiting to be paid.

    Image
  13. cristipaval commented on Nov 20, 2025

    @cristipaval
    Contributor

    This issue happens when workspace is set up with bank account.

    I suspect this is because the report still needs to be marked as paid. You should be able to manually mark a negative expense report as paid. I seem to recall there being an issue for that somewhere. 🤔

    I see @trjExpensify had a great intuition here. So this is no more a bug, is it?

  14. trjExpensify commented on Nov 20, 2025

    @trjExpensify
    Contributor

    IMO, nah it's not. A report with a negative total can be manually marked as paid.

  15. cristipaval commented on Nov 20, 2025

    @cristipaval
    Contributor

    Thanks @trjExpensify! Closing it then.

  16. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions